AsyncMessenger: Don't decrease l_msgr_active_connections if it is negative#57951
Merged
AsyncMessenger: Don't decrease l_msgr_active_connections if it is negative#57951
Conversation
rzarzynski
reviewed
Jun 10, 2024
The counter (msgr_active_connections) can be an anomaly in case if the counter is decrese before increase and initial value is 0. It can be happen while the server daemon is blocked on accept_conn and client sends a disconnect request.To avoid the situation increase the counter at first step in add_accept during accepting a request so that the counter would not be 0 during the decrease operation. Fixes: https://tracker.ceph.com/issues/66231 Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Member
|
I have verified this patch is successful. |
Contributor
Author
Thanks Yite for validate the same. |
rzarzynski
approved these changes
Jun 17, 2024
| listen_addr.is_msgr2(), false); | ||
| conn->accept(std::move(cli_socket), listen_addr, peer_addr); | ||
| accepting_conns.insert(conn); | ||
| w->get_perf_counter()->inc(l_msgr_active_connections); |
Contributor
There was a problem hiding this comment.
Before the change we were decreasing the counter very lately (when connection was only in deleted_conns) while increasing very lately (after the exchanging a few frames).
After the change l_msgr_active_connections is increased early, just after accept. This extends the boundaries a connection is considered active.
Member
NitzanMordhai
pushed a commit
to NitzanMordhai/ceph
that referenced
this pull request
Aug 1, 2024
AsyncMessenger: Don't decrease l_msgr_active_connections if it is negative Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
This was referenced Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The counter (msgr_active_connections) can be an anomaly in case if a server daemon is blocked on accept_conn and the client sends a disconnect request to the server daemon. As the server receives an unregister_conn request it decrease the counter without checking the connection status so decreases the counter only if the previous value is positive.
Fixes: https://tracker.ceph.com/issues/66231
Signed-off-by: Mohit Agrawal moagrawa@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e