msg/mds: print more debug logs from protocol layer#57857
Merged
Conversation
batrick
requested changes
Jun 4, 2024
Member
batrick
left a comment
There was a problem hiding this comment.
mon.yaml too?
Why mgr.yaml?
Please change URL: in commit message to Related: or similar.
| mgr: | ||
| debug mgr: 20 | ||
| debug ms: 1 | ||
| debug ms: 2 |
Member
There was a problem hiding this comment.
If we are changing qa/cephfs/conf then why do we need these changes?
Member
Author
There was a problem hiding this comment.
I thought the conf will be overrode by this ?
Member
Author
Actually this could happen in other components too in theory. For now let's do it in mds only and I will remove the change for mon and mgr. |
We have hitting the issue, which is the messages are stuck in the sender queue, many times. We just suspect it's a bug of the protocol code and we need to know exactly whether the msgs are sent out or not. Related: https://tracker.ceph.com/issues/65309 Signed-off-by: Xiubo Li <xiubli@redhat.com>
Since we have hit this many times in cephfs tests, just increase the debug_ms log level for now. Related: https://tracker.ceph.com/issues/65309 Signed-off-by: Xiubo Li <xiubli@redhat.com>
batrick
approved these changes
Jun 25, 2024
Member
|
This PR is under test in https://tracker.ceph.com/issues/66822. |
Member
works as advertised. |
pereman2
reviewed
Jul 29, 2024
NitzanMordhai
pushed a commit
to NitzanMordhai/ceph
that referenced
this pull request
Aug 1, 2024
* refs/pull/57857/head: qa: set debug_ms=2 for cephfs tests msg: decrease the level to print the sending msgs from the protocol Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug is for many time the MDS sent out the
beaconmsg to monitors,and from the mds and msgr logs we can see that the
beaconmsg wasreally sent out, more exactly is the msg had been enqueued to the protocol
sender queue. But we don't know whether this msg had been sent out or
stuck in the route, and the monitors received it after minutes.
We need to know whether it's a bug in protocol code and need more debug
logs from it.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e