squid: mds: don't add counters in warning for standby-replay MDS#57795
Merged
joscollin merged 2 commits intoceph:squidfrom Jun 14, 2024
Merged
squid: mds: don't add counters in warning for standby-replay MDS#57795joscollin merged 2 commits intoceph:squidfrom
joscollin merged 2 commits intoceph:squidfrom
Conversation
Don't include inode and stray counters in the health warnings printed for standby-replay MDSs. Since these counters are present in the health warnings only due to replay, it can confuse users, and therefore, do not include them. Fixes: https://tracker.ceph.com/issues/63514 Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit 03dcdc1)
- Add tests to verify that inode and stray counters are not replayed/included in the health warnings printed for the standby-replay MDS. - Add "MDS_CACHE_OVERSIZED" health warning to ignorelist to failover.yaml. - Add a helper method to qa.tasks.cephfs.filesystem.Filesystem to get MDS name of standby-replay MDS. Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit 2784e22)
Member
|
Tested in https://tracker.ceph.com/issues/66423 |
joscollin
approved these changes
Jun 14, 2024
joscollin
pushed a commit
to joscollin/ceph
that referenced
this pull request
Jun 27, 2024
* refs/pull/57795/head: qa/cephfs: test that counters are not printed for SR MDS mds: add no counters in warning for standby-replay MDS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/65920
backport of #56065
parent tracker: https://tracker.ceph.com/issues/63514
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh