ec: free plugin memory when it destructs and repeated loads#57592
Merged
ec: free plugin memory when it destructs and repeated loads#57592
Conversation
tchaikov
reviewed
May 23, 2024
tchaikov
reviewed
May 23, 2024
tchaikov
reviewed
May 27, 2024
13b281b to
3cdc19a
Compare
When sanitizer is enabled, unittest_erasure_code_shec_thread shows,
```
=================================================================
==737674==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 1360 byte(s) in 5 object(s) allocated from:
#0 0xaaaadddffb08 in operator new(unsigned long) (/root/ceph/build/bin/unittest_erasure_code_shec_thread+0x1bfb08) (BuildId: 187a0067c45bf30f4d0bd2df83a32e0127ef03a1)
#1 0xffff800bb004 in __erasure_code_init /root/ceph/src/erasure-code/shec/ErasureCodePluginShec.cc:81:36
#2 0xaaaadde08de0 in thread1(void*) /root/ceph/src/test/erasure-code/TestErasureCodeShec_thread.cc:100:5
#3 0xffff7f45d5c4 in start_thread nptl/./nptl/pthread_create.c:442:8
#4 0xffff7f4c5ed8 misc/../sysdeps/unix/sysv/linux/aarch64/clone.S:79
SUMMARY: AddressSanitizer: 1360 byte(s) leaked in 5 allocation(s).
```
When the plugin destructed, memory should be freed without unloading the
dynamic library.
Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
Repeated loading could cause fail, memory should be freed. Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
Member
Author
|
jenkins test make check arm64 |
Contributor
NitzanMordhai
pushed a commit
to NitzanMordhai/ceph
that referenced
this pull request
Aug 1, 2024
ec: free plugin memory when it destructs and repeated loads Reviewed-by: Kefu Chai <tchaikov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sanitizer is enabled, unittest_erasure_code_shec_thread shows,
When the plugin destructed, memory should be freed without unloading the
dynamic library. And repeated loading could cause fail, memory should be freed.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e