Skip to content

qa/cephfs: add MDS_CLIENTS_BROKEN_ROOTSQUASH to ignorelist#57528

Merged
rishabh-d-dave merged 1 commit intoceph:mainfrom
rishabh-d-dave:fix-test_rootsquash_nofeature
May 17, 2024
Merged

qa/cephfs: add MDS_CLIENTS_BROKEN_ROOTSQUASH to ignorelist#57528
rishabh-d-dave merged 1 commit intoceph:mainfrom
rishabh-d-dave:fix-test_rootsquash_nofeature

Conversation

@rishabh-d-dave
Copy link
Contributor

@rishabh-d-dave rishabh-d-dave commented May 16, 2024

MDS_CLIENTS_BROKEN_ROOTSQUASH is generated and expected by
test_rootsquash_nofeature but it hasn't be added to ignorelist as a
result of which QA code marks the job as failed even though all tests
finished running successfully.

Fixes: https://tracker.ceph.com/issues/66075

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@rishabh-d-dave rishabh-d-dave requested review from a team, batrick and vshankar May 16, 2024 16:32
@rishabh-d-dave rishabh-d-dave force-pushed the fix-test_rootsquash_nofeature branch 2 times, most recently from 62fb0d0 to a179e4b Compare May 16, 2024 16:40
batrick
batrick requested changes May 16, 2024
View reviewed changes
Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I knew I'd forget to add that 🙄 ...

The other test_admin failures were masking this eventual clog failure so I didn't notice. Of course, I only proceeded with the #57192 merge because I observed the specific tests I added passed.

@rishabh-d-dave
qa/cephfs: add MDS_CLIENTS_BROKEN_ROOTSQUASH to ignorelist
281183d 
MDS_CLIENTS_BROKEN_ROOTSQUASH is generated and expected by
test_rootsquash_nofeature but it hasn't be added to ignorelist as a
result of which QA code marks the job as failed even though all tests
finished running successfully.

Introduced-by: bccc8ce
Fixes: https://tracker.ceph.com/issues/66075
Signed-off-by: Rishabh Dave <ridave@redhat.com>
@rishabh-d-dave rishabh-d-dave force-pushed the fix-test_rootsquash_nofeature branch from a179e4b to 281183d Compare May 16, 2024 16:43
@batrick
Copy link
Member

batrick commented May 16, 2024

(Feel free to QA this yourself. I just add it to my future branch so I don't have to see those failures.)

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented May 16, 2024 •
edited
Loading

@batrick

(Feel free to QA this yourself. I just add it to my future branch so I don't have to see those failures.)

I'll be doing a quick QA for this, along with 2 other PRs, using builds for recent main on shaman.

rishabh-d-dave added a commit to rishabh-d-dave/ceph that referenced this pull request May 16, 2024
@rishabh-d-dave
Merge PR ceph#57528 into wip-rishabh-testing-20240516.202013-debug
1935450 
* refs/pull/57528/head:
	qa/cephfs: add MDS_CLIENTS_BROKEN_ROOTSQUASH to ignorelist

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
@batrick
Copy link
Member

batrick commented May 17, 2024

jenkins test make check

@batrick
Copy link
Member

batrick commented May 17, 2024

jenkins test make check arm64

@batrick
Copy link
Member

batrick commented May 17, 2024

jenkins test make check

@batrick
Copy link
Member

batrick commented May 17, 2024

jenkins test make check arm64

@batrick
Copy link
Member

batrick commented May 17, 2024

This PR is under test in https://tracker.ceph.com/issues/66086.

vshankar
vshankar approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

rishabh-d-dave added a commit to rishabh-d-dave/ceph that referenced this pull request May 17, 2024
@rishabh-d-dave
Merge PR ceph#57528 into wip-rishabh-testing-20240517.044930-debug
5441429 
* refs/pull/57528/head:
	qa/cephfs: add MDS_CLIENTS_BROKEN_ROOTSQUASH to ignorelist

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented May 17, 2024

make check failed due to package issue - https://jenkins.ceph.com/job/ceph-pull-requests/135174/

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented May 17, 2024

jenkins test make check

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented May 17, 2024

unrelated issues - https://jenkins.ceph.com/job/ceph-pull-requests/135183/

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented May 17, 2024

jenkins test make check

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented May 17, 2024

QA run was successful - https://pulpito.ceph.com/rishabh-2024-05-17_04:50:48-fs:functional-main-testing-default-smithi/.

@rishabh-d-dave rishabh-d-dave merged commit b494674 into ceph:main May 17, 2024
@rishabh-d-dave rishabh-d-dave deleted the fix-test_rootsquash_nofeature branch May 17, 2024 12:27
This was referenced Jun 25, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar approved these changes

@batrick batrick batrick approved these changes

Assignees

No one assigned

Labels

bug-fix cephfs Ceph File System needs-qa tests wip-pdonnell-testing wip-rishabh-testing3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rishabh-d-dave @batrick @vshankar