qa/cephfs: block buggy tests in test_admin.py#57496
Merged
rishabh-d-dave merged 1 commit intoceph:mainfrom May 17, 2024
Merged
Conversation
Contributor
Author
|
Had a conversation with Venky about this, it's good to do a quick QA for this PR so that it can be merge ASAP to make sure test_admin does fine in QA runs - https://pulpito.ceph.com/rishabh-2024-05-16_07:25:57-fs:functional-main-testing-default-smithi/ |
1197f8a to
ca86a59
Compare
Contributor
Author
Contributor
Author
|
This PR is under test in https://tracker.ceph.com/issues/66065. |
rishabh-d-dave
added a commit
to rishabh-d-dave/ceph
that referenced
this pull request
May 16, 2024
* refs/pull/57496/head: qa/cephfs: block buggy tests in test_admin.py
ca86a59 to
d0ba509
Compare
Contributor
Author
|
This PR is under test in https://tracker.ceph.com/issues/66067. |
rishabh-d-dave
added a commit
to rishabh-d-dave/ceph
that referenced
this pull request
May 16, 2024
* refs/pull/57496/head: qa/cephfs: block buggy tests in test_admin.py
batrick
requested changes
May 16, 2024
Contributor
Author
Contributor
Author
d0ba509 to
f0342d4
Compare
rishabh-d-dave
added a commit
to rishabh-d-dave/ceph
that referenced
this pull request
May 16, 2024
* refs/pull/57496/head: qa/cephfs: block buggy tests in test_admin.py
f0342d4 to
2b60c8b
Compare
Contributor
Author
|
Current approach is better than previous because we don't need to import |
rishabh-d-dave
added a commit
to rishabh-d-dave/ceph
that referenced
this pull request
May 16, 2024
* refs/pull/57496/head: qa/cephfs: block buggy tests in test_admin.py
rishabh-d-dave
added a commit
to rishabh-d-dave/ceph
that referenced
this pull request
May 16, 2024
* refs/pull/57496/head: qa/cephfs: block buggy tests in test_admin.py
rishabh-d-dave
added a commit
to rishabh-d-dave/ceph
that referenced
this pull request
May 16, 2024
* refs/pull/57496/head: qa/cephfs: block buggy tests in test_admin.py
batrick
approved these changes
May 17, 2024
Member
|
jenkins test make check |
vshankar
approved these changes
May 17, 2024
Contributor
vshankar
left a comment
There was a problem hiding this comment.
Looks fine. Please link the new trackers for the buggy tests.
Block test_idem_unaffected_root_squash temporarily and test_multifs_single_path_rootsquash. This test fails due to a known bug. Block it temporarily so that test_admin.py can run fully and PRs under QA can be tested fully. Otherwise, this test fails and that halts test_admin.py, which leaves the PR partially untested. This failure is then seen as an unrelated failure which lets the buggy code get merged. This has happened recently. Signed-off-by: Rishabh Dave <ridave@redhat.com>
2b60c8b to
b7d0770
Compare
rishabh-d-dave
added a commit
to rishabh-d-dave/ceph
that referenced
this pull request
May 17, 2024
* refs/pull/57496/head: qa/cephfs: block buggy tests in test_admin.py Reviewed-by: Venky Shankar <vshankar@redhat.com> Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Contributor
Author
|
https://jenkins.ceph.com/job/ceph-pull-requests/135177/ - "slave crashed", looks like transient infra issue |
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
QA run was successful - https://pulpito.ceph.com/rishabh-2024-05-17_04:50:48-fs:functional-main-testing-default-smithi/. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test fails due to a known bug. Block it temporarily so that
test_admin.py can run fully and PRs under QA can be tested fully.
Otherwise, this test fails and that halts test_admin.py, which leaves
the PR partially untested.
This failure is then seen as an unrelated failure which lets the buggy
code get merged. This has happened recently.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e