qa/cephfs: improvements for "mds fail" and "fs fail"#57492
Merged
rishabh-d-dave merged 4 commits intoceph:mainfrom Jul 11, 2024
Merged
qa/cephfs: improvements for "mds fail" and "fs fail"#57492rishabh-d-dave merged 4 commits intoceph:mainfrom
rishabh-d-dave merged 4 commits intoceph:mainfrom
Conversation
14 tasks
fda43e6 to
5213120
Compare
Contributor
Author
|
Rebased so that the commit from PR #57333 (that was merged recently), will go away from this PR branch. This resolves one of two dependency. |
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
5213120 to
773e1de
Compare
Contributor
Author
Code to generate MDS_TRIM and MDS_CACHE_OVERSIZED health warnings is repeated in test methods of TestMDSFail and TestFSFail. Move this code to separate helper methods so that it can be reused instead of duplicating it. And move these helper methods to TestAdminCommands so to make them conveniently available for reuse. Signed-off-by: Rishabh Dave <ridave@redhat.com>
Signed-off-by: Rishabh Dave <ridave@redhat.com>
1. Instead of accepting health report as argument, get one directly. 2. Since it is not being used elsewhere move it to the class where it is being used. Signed-off-by: Rishabh Dave <ridave@redhat.com>
New name will make it easier to find these tests by making it similar to health warnings (MDS_CACHE_OVERSIZED) they do testing for. Signed-off-by: Rishabh Dave <ridave@redhat.com>
773e1de to
0f41207
Compare
batrick
approved these changes
Jun 8, 2024
Member
|
jenkins test make check arm64 |
Contributor
Author
|
This PR is under test in https://tracker.ceph.com/issues/66753. |
rishabh-d-dave
commented
Jul 11, 2024
Contributor
Author
There was a problem hiding this comment.
https://tracker.ceph.com/projects/cephfs/wiki/Main#11-JUL-2024
Testing took some time because first there were issues with building testing branch, then there were too many infra failures, then there were failures due to one of the PRs in the testing branch and finally last run's rerun had new failures that need to be checked.
There were no failures related to this PR, QA was successful.
rishabh-d-dave
added a commit
to rishabh-d-dave/ceph
that referenced
this pull request
Jul 11, 2024
* refs/pull/57492/head: qa/cephfs: rename couple of test methods qa/cephfs: improve and move _get_unhealthy_mds_name to TestMDSFail qa/cephfs: use wait_for_health() instead of the new method qa/cephfs: make code for generating health warnings reusable Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
This was referenced Jul 12, 2024
NitzanMordhai
pushed a commit
to NitzanMordhai/ceph
that referenced
this pull request
Aug 1, 2024
qa/cephfs: improvements for "mds fail" and "fs fail" Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Originally part of PR #57333 but these commits are moved here to keep only inter-dependent bug fixes in it.
First couple of commits on this PR branch are kept here for since latter commits depend on them. They'll vanish when this PR is rebased on latest main after merging of PR #57333.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e