os/bluestore: Recompression, part 5. Testing.#57450
os/bluestore: Recompression, part 5. Testing.#57450
Conversation
ifed01
left a comment
There was a problem hiding this comment.
There are a bunch of failed test cases in store_test:
[ FAILED ] ObjectStore/StoreTestSpecificAUSize.ReproBug41901Test/1, where GetParam() = "bluestore" (1426 ms)
[ FAILED ] ObjectStore/StoreTestSpecificAUSize.BluestoreStatFSTest/1, where GetParam() = "bluestore" (7027 ms)
[ FAILED ] ObjectStore/StoreTestSpecificAUSize.BluestoreFragmentedBlobTest/1, where GetParam() = "bluestore" (4740 ms)
And finally this stops at:
[ RUN ] ObjectStore/StoreTestSpecificAUSize.SyntheticMatrixCsumVsCompression/1
---------------------- 1 / 16 ----------------------
bluestore_min_alloc_size = 4096
max_write = 131072
max_size = 262144
alignment = 512
bluestore_compression_mode = force
bluestore_compression_algorithm = snappy
bluestore_csum_type = crc32c
bluestore_default_buffered_read = true
bluestore_default_buffered_write = true
bluestore_sync_submit_transaction = false
seeding object 0
seeding object 500
Op 0
available_objects: 994 in_flight_objects: 6 total objects: 1000 in_flight 6
Op 1000
available_objects: 998 in_flight_objects: 0 total objects: 998 in_flight 0
Op 2000
available_objects: 1004 in_flight_objects: 0 total objects: 1004 in_flight 0
--- buffer mismatch between offset 0x16c00 and 0x17000, total 0x30000
...
home/if/ceph.3/src/test/objectstore/store_test.cc: In function 'virtual void SyntheticWorkloadState::C_SyntheticOnReadable::finish(int)' thread 7f2a99a8f6c0 time 2024-05-21T00:23:03.209227+0300
/home/if/ceph.3/src/test/objectstore/store_test.cc: 4314: FAILED ceph_assert(bl_eq(state->contents[hoid].data, r2))
fcfbd4e to
ec09451
Compare
ec09451 to
ca39eb4
Compare
5dfbb9b to
27366c2
Compare
38000f6 to
0c85b8f
Compare
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
Introduce printer class that allows to select parts of Blob that are to be printed. It severly reduced amount of clutter in output. Usage: using P = Bluestore::Blob::printer; dout << blob->printer(P::ptr + P::sdisk + P::schk); Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Modify Extent similar to Blob, so that one can use improved Blob printing when printing extents. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Now printing Blob can include buffers. There are 2 variants: - 'buf' same as original in dump_onode - 'sbuf' only fundamental params, no ptr etc. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Added nice replacement for dump_onode function. Introduce printer class that allows to select parts of Onode that are to be printed. It severly reduced amount of clutter in output. Usage: using P = Bluestore::printer; dout << blob->print(P::ptr + P::sdisk + P::schk + P::buf + P::attrs); Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
- moved operator<< to BlueStore_debug file
- upcased Printer {} flags
- more reliable heap begin detection
- fixup after rebase
Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Small improvement on debug output. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Move most logic from Scanner to Estimator. Prepare for future machine learning / adaptive algorithm for estimation. Renamed functions, added interface comments. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Give Estimator proper logic. It now learns expected recompression values, and uses them in next iterations to predict. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Make one estimator per collection. It makes possible for estimator to learn in collection specific compressibility. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
This is borrowed from ceph#57631; selective cherry-picked from commit: os/bluestore: implement data reformatting on reads Signed-off-by: Garry Drankovich <garry.drankovich@clyso.com> Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
In write_v2_compressed use compressor already selected in choose_write_options. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Make Collection create Estimator on first use. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Added missing files to alienstore CMake list. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Tests that use original write path specific knowledge are failing now. For such tests, force conf/bluestore_write_v2=false. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Add admin socket commands: 1) bluestore collections Lists collections. 2) bluestore list <coll> [start object] [max count] Lists collection coll starting from object (optional). Default 100 entries. 0 = unlimited. 3) bluestore onode metadata <object> Prints onode metadata as seen by BlueStore. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
It might happen (usually in tests) that 2 BlueStore instances are created at the same time. Since admin commands are unique, it fails to register. Use first register to detect whether we can register at all. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Add new admin socket command to inspect Estimator stats per collection. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Changed arguments. Passing Onode makes more sense, as logically we scan specific object. And we can dout onode. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
General code cleanup around _do_write_v2_compressed. Changed Estimator::reset to Estimator::cleanup. Now estimator cleans up after work, not before next task. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Improve quality of douts. Simplify expand_left an expand_right. Rename functions. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Using fmt::format requires libfmt for linking Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
BufferSpace blob->onode. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Created ch = CollectionHandle was not reset, causing valgrind & other problems. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Test uses write_v1 triggers for deferred operation. Falling back to write_v1 in these tests. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Logic of _schedule_io got changed in write path v2. This is adaptation to it. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Empty line. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
f7fdafe to
7e96768
Compare
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution! |
This is test part, that accumulates settings done to run unit tests and teuthology tests.
#54075 Nice debugs.
#54504 New write path.
#57448 Segmented onode.
#56975 Main
#57450 Test
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e