Skip to content

reef: ceph.spec.in: remove command-with-macro line#57357

Merged
batrick merged 1 commit intoceph:reeffrom
batrick:reef-rpm-build-fix
May 11, 2024
Merged

reef: ceph.spec.in: remove command-with-macro line#57357
batrick merged 1 commit intoceph:reeffrom
batrick:reef-rpm-build-fix

Conversation

@batrick
Copy link
Member

@batrick batrick commented May 8, 2024 •
edited
Loading

Manual backport as the original PR has no tracker ticket.

@phlogistonjohn @batrick
ceph.spec.in: remove command-with-macro line
a75e4b6 
A comment clearly left as a breadcrumb for a node-proxy manpage is
causing (intermittent) build failures. Remove the line and hope
the manpage is added if/when appropriate.

Fixes: 0dd7364
Signed-off-by: John Mulligan <jmulligan@redhat.com>
(cherry picked from commit 5f25005)
@batrick batrick added this to the v18.2.3 milestone May 8, 2024
@batrick
Copy link
Member Author

batrick commented May 8, 2024

jenkins test api

batrick added a commit to batrick/ceph that referenced this pull request May 9, 2024
@batrick
Merge PR ceph#57357 into wip-pdonnell-testing-20240508.150423-reef
4d26025 
* refs/pull/57357/head:
	ceph.spec.in: remove command-with-macro line
@batrick
Copy link
Member Author

batrick commented May 9, 2024

This PR is under test in https://tracker.ceph.com/issues/65884.

@batrick batrick requested review from guits and phlogistonjohn May 9, 2024 13:13
phlogistonjohn
phlogistonjohn approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for backport

batrick added a commit to batrick/ceph that referenced this pull request May 10, 2024
@batrick
Merge PR ceph#57357 into wip-pdonnell-testing-20240509.171335-reef-debug
ae0eae5 
* refs/pull/57357/head:
	ceph.spec.in: remove command-with-macro line
@batrick
Copy link
Member Author

batrick commented May 11, 2024

https://tracker.ceph.com/issues/65884?issue_count=14&issue_position=1&next_issue_id=65699#note-5

@batrick batrick merged commit 4babcec into ceph:reef May 11, 2024
@batrick batrick deleted the reef-rpm-build-fix branch May 11, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phlogistonjohn phlogistonjohn phlogistonjohn approved these changes

@guits guits Awaiting requested review from guits

Assignees

No one assigned

Labels

build/ops wip-pdonnell-testing2

Projects

None yet

Milestone

v18.2.4

Development

Successfully merging this pull request may close these issues.

2 participants

@batrick @phlogistonjohn