Skip to content

test/common/test_back_trace: skip one more frame when testing w/ ASan#57260

Merged
tchaikov merged 1 commit intoceph:mainfrom
tchaikov:test_back_trace-with-asan
May 17, 2024
Merged

test/common/test_back_trace: skip one more frame when testing w/ ASan#57260
tchaikov merged 1 commit intoceph:mainfrom
tchaikov:test_back_trace-with-asan

Conversation

@tchaikov
Copy link
Contributor

@tchaikov tchaikov commented May 4, 2024

if ASan is enabled, backtrace() returns one more frame, so we need to skip one more frame when testing backtrace facility. this change addresses the following test failure:

[ RUN      ] BackTrace.Basic
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/common/test_back_trace.cc:43: Failure
Value of: std::regex_match(lines[lineno], e)
  Actual: false
Expected: true
[  FAILED  ] BackTrace.Basic (5 ms)

it only manifests itself when testing with ASan enabled.

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

if ASan is enabled, backtrace() returns one more frame, so we need
to skip one more frame when testing backtrace facility. this change
addresses the following test failure:

```
[ RUN      ] BackTrace.Basic
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/common/test_back_trace.cc:43: Failure
Value of: std::regex_match(lines[lineno], e)
  Actual: false
Expected: true
[  FAILED  ] BackTrace.Basic (5 ms)
```

it only manifests itself when testing with ASan enabled.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
@tchaikov tchaikov requested a review from rzarzynski May 4, 2024 03:31
@github-actions github-actions bot added the tests label May 4, 2024
@tchaikov
Copy link
Contributor Author

tchaikov commented May 4, 2024

@rzarzynski hi Radek, could you help review this change?

@tchaikov tchaikov mentioned this pull request May 4, 2024
14 tasks
@Svelar
Copy link
Member

Svelar commented May 8, 2024

#56809 Seems like your resolution is better.

@tchaikov
Copy link
Contributor Author

tchaikov commented May 9, 2024

@rzarzynski hi Radek, could you help review this change?

1 similar comment
@tchaikov
Copy link
Contributor Author

@rzarzynski hi Radek, could you help review this change?

@tchaikov tchaikov merged commit fcb2eb7 into ceph:main May 17, 2024
@tchaikov tchaikov deleted the test_back_trace-with-asan branch May 17, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants