Skip to content

test/test_back_trace: fix failed Basic UT because of different call stacks#56809

Closed
Svelar wants to merge 1 commit intoceph:mainfrom
Svelar:ut_back_trace
Closed

test/test_back_trace: fix failed Basic UT because of different call stacks#56809
Svelar wants to merge 1 commit intoceph:mainfrom
Svelar:ut_back_trace

Conversation

@Svelar
Copy link
Member

@Svelar Svelar commented Apr 10, 2024

Run test on Kunpeng arm machine:
[ RUN ] BackTrace.Basic
bt:
ceph version Development (no_version) squid (dev)
1: (ceph::ClibBackTrace::ClibBackTrace(int)+0x128) [0xaaaac54ff77c]
2: (fooabi:cxx11+0x1fc) [0xaaaac54fe5a4]
3: (BackTrace_Basic_Test::TestBody()+0x284) [0xaaaac54fea80]
4: (void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::)(), char const)+0x1e0) [0xaaaac56a52f4]
5: (void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::)(), char const)+0x25c) [0xaaaac565d274]
6: (testing::Test::Run()+0x310) [0xaaaac56101cc]
7: (testing::TestInfo::Run()+0x338) [0xaaaac5612110]
8: (testing::TestSuite::Run()+0x3e4) [0xaaaac5613710]
9: (testing::internal::UnitTestImpl::RunAllTests()+0xa30) [0xaaaac562f4d4]
10: (bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::)(), char const)+0x1e0) [0xaaaac56af17c]
11: (bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::)(), char const)+0x25c) [0xaaaac56636e8]
12: (testing::UnitTest::Run()+0x274) [0xaaaac562e94c]
13: (RUN_ALL_TESTS()+0x10) [0xaaaac55b36e8]
14: main()
15: /lib/aarch64-linux-gnu/libc.so.6(+0x273fc) [0xffffa01973fc]
16: __libc_start_main()
17: _start()

src/test/common/test_back_trace.cc:44: Failure
Value of: std::regex_match(lines[lineno], e)
Actual: false
Expected: true
[ FAILED ] BackTrace.Basic (5 ms)
[----------] 1 test from BackTrace (5 ms total)

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

stacks

Run test on Kunpeng arm machine:
[ RUN      ] BackTrace.Basic
bt:
 ceph version Development (no_version) squid (dev)
 1: (ceph::ClibBackTrace::ClibBackTrace(int)+0x128) [0xaaaac54ff77c]
 2: (foo[abi:cxx11]()+0x1fc) [0xaaaac54fe5a4]
 3: (BackTrace_Basic_Test::TestBody()+0x284) [0xaaaac54fea80]
 4: (void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)+0x1e0) [0xaaaac56a52f4]
 5: (void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)+0x25c) [0xaaaac565d274]
 6: (testing::Test::Run()+0x310) [0xaaaac56101cc]
 7: (testing::TestInfo::Run()+0x338) [0xaaaac5612110]
 8: (testing::TestSuite::Run()+0x3e4) [0xaaaac5613710]
 9: (testing::internal::UnitTestImpl::RunAllTests()+0xa30) [0xaaaac562f4d4]
 10: (bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)+0x1e0) [0xaaaac56af17c]
 11: (bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)+0x25c) [0xaaaac56636e8]
 12: (testing::UnitTest::Run()+0x274) [0xaaaac562e94c]
 13: (RUN_ALL_TESTS()+0x10) [0xaaaac55b36e8]
 14: main()
 15: /lib/aarch64-linux-gnu/libc.so.6(+0x273fc) [0xffffa01973fc]
 16: __libc_start_main()
 17: _start()

src/test/common/test_back_trace.cc:44: Failure
Value of: std::regex_match(lines[lineno], e)
  Actual: false
Expected: true
[  FAILED  ] BackTrace.Basic (5 ms)
[----------] 1 test from BackTrace (5 ms total)

Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
@github-actions github-actions bot added the tests label Apr 10, 2024
@Svelar Svelar marked this pull request as ready for review April 10, 2024 07:53
@Svelar Svelar requested a review from a team April 11, 2024 02:27
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Jun 10, 2024
@Svelar Svelar closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant