Conversation
BtreeAllocator was added in the commit ceph#41828. Its performance has advantages in some scenarios, but we cannot configure to use btree mode. Fixes: https://tracker.ceph.com/issues/65678 Signed-off-by: tan changzhi <544463199@qq.com>
957a1c3 to
98f7ccf
Compare
ifed01
approved these changes
Apr 29, 2024
ifed01
requested changes
Apr 29, 2024
Contributor
ifed01
left a comment
There was a problem hiding this comment.
Please fix bluefs_allocator as well
NUABO
commented
Apr 29, 2024
Contributor
|
jenkins test make check |
ifed01
approved these changes
Apr 29, 2024
Contributor
|
tested at https://pulpito.ceph.com/kchai-2024-05-04_14:52:58-rados-wip-kefu-testing-2024-05-04-distro-default-smithi/ . but due to the test failures. need to bisect the offending change or to see they are known issues. |
Contributor
Author
I checked the reasons for the two tasks being dead. It should not be related to this modification and it should be a known issue~ |
Contributor
NitzanMordhai
pushed a commit
to NitzanMordhai/ceph
that referenced
this pull request
Aug 1, 2024
os/bluestore: allow use BtreeAllocator
This was referenced Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BtreeAllocator was added in the commit
#41828.
Its performance has advantages in some scenarios,
but we cannot configure to use btree mode.
Fixes: https://tracker.ceph.com/issues/65678
Signed-off-by: tan changzhi 544463199@qq.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e