Skip to content

test/neorados: timeout test won't reconnect at timeout#56982

Merged
yuriw merged 1 commit intoceph:mainfrom
NitzanMordhai:wip-nitzan-neorados-watch-notify-test-reconnect
Jul 16, 2024
Merged

test/neorados: timeout test won't reconnect at timeout#56982
yuriw merged 1 commit intoceph:mainfrom
NitzanMordhai:wip-nitzan-neorados-watch-notify-test-reconnect

Conversation

@NitzanMordhai
Copy link
Contributor

@NitzanMordhai NitzanMordhai commented Apr 18, 2024

Watch-notify tests involve waiting for a notification within a certain timeout period. However, if an error occurs before receiving the notification acknowledgment, attempting to reconnect may lead to unpredictable errors.

Fixes: https://tracker.ceph.com/issues/65449

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

Watch-notify tests involve waiting for a notification within a
certain timeout period. However, if an error occurs before receiving
the notification acknowledgment, attempting to reconnect may lead to
unpredictable errors.

Fixes: https://tracker.ceph.com/issues/65449
Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
@rzarzynski
Copy link
Contributor

Unrelated:

The following tests FAILED:
	  7 - run-tox-mgr-dashboard-py3 (Failed)
	261 - unittest-seastore (Timeout)

@rzarzynski
Copy link
Contributor

jenkins test make check

@rzarzynski
Copy link
Contributor

@adamemerson: ping.

Copy link
Contributor

@adamemerson adamemerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yuriw
Copy link
Contributor

yuriw commented Jul 16, 2024

@yuriw yuriw merged commit e67c794 into ceph:main Jul 16, 2024
NitzanMordhai pushed a commit to NitzanMordhai/ceph that referenced this pull request Aug 1, 2024
…watch-notify-test-reconnect

test/neorados: timeout test won't reconnect at timeout

Reviewed-by: Adam Emerson <aemerson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants