Skip to content

bluestore/bluestore_types: avoid heap-buffer-overflow in another way to keep code uniformity#56937

Merged
yuriw merged 1 commit intoceph:mainfrom
Svelar:asan_bluestore_type
Jul 18, 2024
Merged

bluestore/bluestore_types: avoid heap-buffer-overflow in another way to keep code uniformity#56937
yuriw merged 1 commit intoceph:mainfrom
Svelar:asan_bluestore_type

Conversation

@Svelar
Copy link
Member

@Svelar Svelar commented Apr 17, 2024

bluestore/bluestore_types: avoid heap-buffer-overflow in another way to keep code uniformity

This commit modifies end iterator to keep code uniformity as items container did.

Ref: https://github.com/ceph/ceph/pull/56890/files/19104a6fffe24a6debfd8492c90b3027126eb352#r1567083822

Fixes: https://tracker.ceph.com/issues/65482

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

…to keep code uniformity

Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
@Svelar
Copy link
Member Author

Svelar commented Apr 23, 2024

@ifed01 Hi, could you have a look at this version? Thanks~

@Svelar
Copy link
Member Author

Svelar commented Apr 23, 2024

jenkins test make check arm64

@yuriw
Copy link
Contributor

yuriw commented May 3, 2024

This PR is under test in https://tracker.ceph.com/issues/65796.

@github-actions
Copy link

github-actions bot commented Jul 2, 2024

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Jul 2, 2024
@tchaikov tchaikov removed the stale label Jul 4, 2024
@kamoltat
Copy link
Member

@yuriw yuriw merged commit 17315e1 into ceph:main Jul 18, 2024
NitzanMordhai pushed a commit to NitzanMordhai/ceph that referenced this pull request Aug 1, 2024
bluestore/bluestore_types: avoid heap-buffer-overflow in another way to keep code uniformity

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants