Conversation
…to keep code uniformity Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
This was referenced Apr 17, 2024
Member
Author
|
@ifed01 Hi, could you have a look at this version? Thanks~ |
Member
Author
|
jenkins test make check arm64 |
ifed01
approved these changes
Apr 23, 2024
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/65796. |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
Member
This was referenced Jul 25, 2024
NitzanMordhai
pushed a commit
to NitzanMordhai/ceph
that referenced
this pull request
Aug 1, 2024
bluestore/bluestore_types: avoid heap-buffer-overflow in another way to keep code uniformity Reviewed-by: Igor Fedotov <ifedotov@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bluestore/bluestore_types: avoid heap-buffer-overflow in another way to keep code uniformity
This commit modifies end iterator to keep code uniformity as
items containerdid.Ref: https://github.com/ceph/ceph/pull/56890/files/19104a6fffe24a6debfd8492c90b3027126eb352#r1567083822
Fixes: https://tracker.ceph.com/issues/65482
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e