Skip to content

mds: regular file inode flags are not replicated by the policylock#56935

Merged
batrick merged 2 commits intoceph:mainfrom
batrick:i65518
Apr 30, 2024
Merged

mds: regular file inode flags are not replicated by the policylock#56935
batrick merged 2 commits intoceph:mainfrom
batrick:i65518

Conversation

@batrick
Copy link
Member

@batrick batrick commented Apr 16, 2024

Checklist

  • Tracker (select at least one)
    • References tracker ticket
  • Component impact
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@batrick
Copy link
Member Author

batrick commented Apr 17, 2024

This PR is under test in https://tracker.ceph.com/issues/65530.

@batrick
Copy link
Member Author

batrick commented Apr 17, 2024

jenkins test make check

@batrick
Copy link
Member Author

batrick commented Apr 17, 2024

jenkins test windows

@batrick
Copy link
Member Author

batrick commented Apr 18, 2024

This PR is under test in https://tracker.ceph.com/issues/65562.

@batrick
Copy link
Member Author

batrick commented Apr 20, 2024

This PR is under test in https://tracker.ceph.com/issues/65596.

@batrick
Copy link
Member Author

batrick commented Apr 20, 2024

jenkins test make check

@batrick
Copy link
Member Author

batrick commented Apr 20, 2024

jenkins test windows

@batrick
Copy link
Member Author

batrick commented Apr 22, 2024

jenkins test make check

Copy link
Contributor

@leonid-s-usov leonid-s-usov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

73253f3 is now in conflict with #57020, and it appears that here the fix wasn't correct. We want to go for the xlock_finish for local xlock, rather than silently put it as it's done here.

@batrick
Copy link
Member Author

batrick commented Apr 22, 2024

73253f3 is now in conflict with #57020, and it appears that here the fix wasn't correct. We want to go for the xlock_finish for local xlock, rather than silently put it as it's done here.

ack, thanks. I'll remove from this PR.

batrick added 2 commits April 22, 2024 14:56
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Inode flag F_QUIESCE_BLOCK would not be encoded for regular files.
Unfortunately we're encoding the value twice for directories but it's a
small overhead.

Fixes: https://tracker.ceph.com/issues/65518
Fixes: fb05dd1
Fixes: e2529fc
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
@batrick
Copy link
Member Author

batrick commented Apr 22, 2024

@batrick
Copy link
Member Author

batrick commented Apr 22, 2024

needs rerun as the commit noted above has been removed

Copy link
Contributor

@leonid-s-usov leonid-s-usov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should run it with #57020 included to avoid the said crash

@batrick
Copy link
Member Author

batrick commented Apr 25, 2024

This PR is under test in https://tracker.ceph.com/issues/65661.

batrick added a commit to batrick/ceph that referenced this pull request Apr 29, 2024
* refs/pull/56935/head:
	mds: encode flags for all inode types
	qa: test file inode with F_QUIESCE_BLOCK is replicated
@batrick
Copy link
Member Author

batrick commented Apr 29, 2024

This PR is under test in https://tracker.ceph.com/issues/65694.

@batrick
Copy link
Member Author

batrick commented Apr 30, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants