qa: extend rank 1 lockup for test_quiesce_authpin_wait#56923
qa: extend rank 1 lockup for test_quiesce_authpin_wait#56923
Conversation
There was a problem hiding this comment.
LGTM, let's see how it runs with the patch here
leonid-s-usov
left a comment
There was a problem hiding this comment.
Apparently, this patch takes the approach too far, and it causes multiple failures. Let's be honest, locking up MDS was only good as long as it worked, but now we have a good reason to rethink the strategy behind this test
85cc353 to
0a13d39
Compare
In teuthology, the lockup may not be long enough because clients are much faster there than in a vstart cluster where this test was designed. Fixes: https://tracker.ceph.com/issues/65508 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
|
@leonid-s-usov have another look please. |
|
This PR is under test in https://tracker.ceph.com/issues/65530. |
leonid-s-usov
left a comment
There was a problem hiding this comment.
I'm still not happy with the lockup approach. I'll wait for the test results, but I'd appreciate a different approach to running this test.
We already went as far as adding a dedicated lockup admin command. I'd rather change that to something more precise that would not involve holding the mds lock for a long time. Maybe a command to pause iner-rank messaging, or specific (arbitrary) peer request ops or their acks
Sitting on the |
|
This PR is under test in https://tracker.ceph.com/issues/65562. |
|
This PR is under test in https://tracker.ceph.com/issues/65596. |
|
This PR is under test in https://tracker.ceph.com/issues/65661. |
leonid-s-usov
left a comment
There was a problem hiding this comment.
I'm good with this as long as it's stable 👍🏻
* refs/pull/56923/head: qa: extend rank 1 lockup for test_quiesce_authpin_wait
|
jenkins test make check arm64 |
|
This PR is under test in https://tracker.ceph.com/issues/65694. |
In teuthology, the lockup may not be long enough because clients are much faster there than in a vstart cluster where this test was designed.
Fixes: https://tracker.ceph.com/issues/65508
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e