Conversation
|
@joscollin Why close #56698 in favour of this. That PR could have been updated o_O |
I needed a different branch altogether. It's difficult for me to track without a branch id. |
d516767 to
8e43500
Compare
leonid-s-usov
left a comment
There was a problem hiding this comment.
Shouldn't we set the last_failed_reason also at other error exits of the function, e.g. around lines 513 and 530?
It is out of scope of this PR. Please read the requirement. |
8e43500 to
61531d5
Compare
|
@joscollin what's the status of this change? |
I've completed my work on it. @vshankar It's been waiting for your review. |
|
jenkins test windows |
|
jenkins test make check arm64 |
61531d5 to
7667a25
Compare
|
rebased |
|
jenkins test api |
|
jenkins test api |
|
jenkins test windows |
|
jenkins test make check |
|
jenkins test make check arm64 |
|
This PR is under test in https://tracker.ceph.com/issues/67318. |
|
jenkins test api |
|
jenkins test make check |
* refs/pull/56816/head: doc: mention the peer status failed when snapshot created on the remote filesystem. qa: add test_cephfs_mirror_remote_snap_corrupt_fails_synced_snapshot cephfs_mirror: update peer status for invalid metadata in remote snapshot Reviewed-by: Venky Shankar <vshankar@redhat.com>
0495910 to
4fc49b5
Compare
* refs/pull/56816/head: qa: fixed rwps doc: mention the peer status failed when snapshot created on the remote filesystem. qa: add test_cephfs_mirror_remote_snap_corrupt_fails_synced_snapshot cephfs_mirror: update peer status for invalid metadata in remote snapshot Reviewed-by: Anthony D Atri <anthony.datri@gmail.com> Reviewed-by: Venky Shankar <vshankar@redhat.com>
…shot Fixes: https://tracker.ceph.com/issues/65317 Signed-off-by: Jos Collin <jcollin@redhat.com>
Fixes: https://tracker.ceph.com/issues/65226 Signed-off-by: Jos Collin <jcollin@redhat.com>
…te filesystem. * Update the docs for the failed status, when the snapshot is created on the remote fs. * Mention the read-only restrictions of the remote fs. Fixes: https://tracker.ceph.com/issues/65317 Signed-off-by: Jos Collin <jcollin@redhat.com>
4fc49b5 to
ce10e5e
Compare
|
@vshankar Please do another QA for this PR. |
|
jenkins test make check |
I will add it to the test batch. Could you explain the failure and the fix please? |
@vshankar |
|
jenkins test make check |
* refs/pull/56816/head: doc: mention the peer status failed when snapshot created on the remote filesystem. qa: add test_cephfs_mirror_remote_snap_corrupt_fails_synced_snapshot cephfs_mirror: update peer status for invalid metadata in remote snapshot Reviewed-by: Anthony D Atri <anthony.datri@gmail.com> Reviewed-by: Venky Shankar <vshankar@redhat.com>
Fixes: https://tracker.ceph.com/issues/65317
Fixes: https://tracker.ceph.com/issues/65226
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e