cephfs_mirror: provide metrics for last successful snapshot sync by joscollin · Pull Request #56782 · ceph/ceph

joscollin · 2024-04-09T11:38:15Z

Fixes: https://tracker.ceph.com/issues/65171
Fixes: https://tracker.ceph.com/issues/64483
Fixes: https://tracker.ceph.com/issues/65629

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows
jenkins test rook e2e

src/tools/cephfs_mirror/PeerReplayer.cc

joscollin · 2024-07-03T06:53:06Z

jenkins test api

joscollin · 2024-07-09T09:33:24Z

jenkins test api

joscollin · 2024-07-09T09:33:44Z

jenkins test make check arm64

joscollin · 2024-07-09T11:33:46Z

rebased

joscollin · 2024-07-10T09:01:43Z

jenkins test api

joscollin · 2024-07-10T09:01:54Z

jenkins test make check

joscollin · 2024-07-10T11:20:29Z

jenkins test api

vshankar

Looks fine. IMO we should also add some tests for this change. WDYT @joscollin

joscollin · 2024-07-29T15:57:45Z

Tests passed:
https://pulpito.ceph.com/jcollin-2024-07-29_15:03:32-fs:mirror-wip-jcollin-testing-distro-default-smithi/
https://pulpito.ceph.com/jcollin-2024-07-29_15:03:58-fs:valgrind-wip-jcollin-testing-distro-default-smithi/

joscollin · 2024-07-29T15:57:52Z

jenkins test api

joscollin · 2024-07-29T15:57:59Z

jenkins test make check

joscollin · 2024-07-30T02:09:41Z

jenkins test api

joscollin · 2024-07-30T02:10:07Z

jenkins test make check arm64

joscollin · 2024-07-30T05:30:28Z

@vshankar Updated the doc

Fixes: https://tracker.ceph.com/issues/65629 Signed-off-by: Jos Collin <jcollin@redhat.com>

Fixes: https://tracker.ceph.com/issues/65171 Signed-off-by: Jos Collin <jcollin@redhat.com>

vshankar · 2024-07-30T07:46:39Z

This PR is under test in https://tracker.ceph.com/issues/67252.

joscollin · 2024-07-30T08:28:11Z

@vshankar Updated only the doc.

Fixes: https://tracker.ceph.com/issues/64483 Fixes: https://tracker.ceph.com/issues/65171 Signed-off-by: Jos Collin <jcollin@redhat.com>

Fixes: https://tracker.ceph.com/issues/67251 Signed-off-by: Jos Collin <jcollin@redhat.com>

Fixes: https://tracker.ceph.com/issues/65629 Signed-off-by: Jos Collin <jcollin@redhat.com>

joscollin · 2024-07-30T09:15:38Z

@vshankar Updated only docs.

vshankar · 2024-07-30T09:32:05Z

@vshankar Updated only docs.

kk, I already included a previous version in the branch, so as long as the latest push is doc only, I'm fine with that.

joscollin · 2024-07-30T09:55:19Z

jenkins test docs

* refs/pull/56782/head: doc: update 'sync_bytes' in peer status doc: update current_syncing_snap in peer status doc: document labelled perf metrics for mds/cephfs-mirror qa: check last successful snapshot sync metrics in perf counters cephfs_mirror: provide metrics for last successful snapshot sync cephfs_mirror: show 'sync_bytes' in peer status Reviewed-by: Venky Shankar <vshankar@redhat.com>

joscollin · 2024-08-01T09:08:07Z

jenkins test make check

joscollin · 2024-08-06T09:54:39Z

jenkins test make check

vshankar

https://tracker.ceph.com/projects/cephfs/wiki/Main#wip-vshankar-testing-20240731064922-debug

joscollin marked this pull request as draft April 9, 2024 11:38

github-actions bot added the cephfs Ceph File System label Apr 9, 2024

joscollin added the DNM label Apr 9, 2024

joscollin force-pushed the wip-B65171-support-replication-start-end-notifications branch 2 times, most recently from 298b06e to 336b056 Compare April 10, 2024 09:20

joscollin marked this pull request as ready for review April 10, 2024 09:22

joscollin removed the DNM label Apr 10, 2024

joscollin requested review from a team and vshankar April 10, 2024 10:30

joscollin requested a review from a team as a code owner April 10, 2024 12:48

github-actions bot added the documentation label Apr 10, 2024

joscollin mentioned this pull request Apr 10, 2024

doc: document labelled perf metrics for mds/cephfs-mirror #55687

Closed

14 tasks

joscollin force-pushed the wip-B65171-support-replication-start-end-notifications branch from 622aeb2 to ddc7145 Compare April 17, 2024 15:27

joscollin marked this pull request as draft April 23, 2024 14:54

joscollin force-pushed the wip-B65171-support-replication-start-end-notifications branch from ddc7145 to 66c3727 Compare April 24, 2024 15:26

joscollin marked this pull request as ready for review April 24, 2024 15:29

joscollin mentioned this pull request Apr 24, 2024

cephfs_mirror: show 'sync_bytes' in peer status #57050

Closed

joscollin force-pushed the wip-B65171-support-replication-start-end-notifications branch 2 times, most recently from 0f15ed0 to 6939ad5 Compare May 27, 2024 04:42

vshankar requested changes Jun 13, 2024

View reviewed changes

src/tools/cephfs_mirror/PeerReplayer.cc Outdated Show resolved Hide resolved

joscollin force-pushed the wip-B65171-support-replication-start-end-notifications branch from 6939ad5 to 18b51c2 Compare June 14, 2024 03:40

joscollin force-pushed the wip-B65171-support-replication-start-end-notifications branch from 18b51c2 to 43ada7e Compare July 9, 2024 11:33

vshankar reviewed Jul 16, 2024

View reviewed changes

joscollin force-pushed the wip-B65171-support-replication-start-end-notifications branch from daf7d74 to bf1b697 Compare July 30, 2024 05:30

joscollin added 3 commits July 30, 2024 11:01

cephfs_mirror: show 'sync_bytes' in peer status

cc721a5

Fixes: https://tracker.ceph.com/issues/65629 Signed-off-by: Jos Collin <jcollin@redhat.com>

cephfs_mirror: provide metrics for last successful snapshot sync

fb985c4

Fixes: https://tracker.ceph.com/issues/65171 Signed-off-by: Jos Collin <jcollin@redhat.com>

qa: check last successful snapshot sync metrics in perf counters

5535e72

Fixes: https://tracker.ceph.com/issues/65171 Signed-off-by: Jos Collin <jcollin@redhat.com>

joscollin force-pushed the wip-B65171-support-replication-start-end-notifications branch from bf1b697 to 867b13e Compare July 30, 2024 05:31

joscollin added 3 commits July 30, 2024 14:09

doc: document labelled perf metrics for mds/cephfs-mirror

7c32d15

Fixes: https://tracker.ceph.com/issues/64483 Fixes: https://tracker.ceph.com/issues/65171 Signed-off-by: Jos Collin <jcollin@redhat.com>

doc: update current_syncing_snap in peer status

3fd00eb

Fixes: https://tracker.ceph.com/issues/67251 Signed-off-by: Jos Collin <jcollin@redhat.com>

doc: update 'sync_bytes' in peer status

091625e

Fixes: https://tracker.ceph.com/issues/65629 Signed-off-by: Jos Collin <jcollin@redhat.com>

joscollin force-pushed the wip-B65171-support-replication-start-end-notifications branch from 98eacbf to 091625e Compare July 30, 2024 09:14

vshankar approved these changes Aug 6, 2024

View reviewed changes

vshankar merged commit c9ab079 into ceph:main Aug 7, 2024

vshankar removed the wip-vshankar-testing4 label Aug 7, 2024

joscollin deleted the wip-B65171-support-replication-start-end-notifications branch August 7, 2024 04:22

This was referenced Aug 7, 2024

squid: cephfs_mirror: provide metrics for last successful snapshot sync #59070

Merged

reef: cephfs_mirror: provide metrics for last successful snapshot sync #59071

Merged

Conversation

joscollin commented Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution Guidelines

Checklist

Uh oh!

Uh oh!

joscollin commented Jul 3, 2024

Uh oh!

joscollin commented Jul 9, 2024

Uh oh!

joscollin commented Jul 9, 2024

Uh oh!

joscollin commented Jul 9, 2024

Uh oh!

joscollin commented Jul 10, 2024

Uh oh!

joscollin commented Jul 10, 2024

Uh oh!

joscollin commented Jul 10, 2024

Uh oh!

vshankar left a comment

Choose a reason for hiding this comment

Uh oh!

joscollin commented Jul 29, 2024

Uh oh!

joscollin commented Jul 29, 2024

Uh oh!

joscollin commented Jul 29, 2024

Uh oh!

joscollin commented Jul 30, 2024

Uh oh!

joscollin commented Jul 30, 2024

Uh oh!

joscollin commented Jul 30, 2024

Uh oh!

vshankar commented Jul 30, 2024

Uh oh!

joscollin commented Jul 30, 2024

Uh oh!

joscollin commented Jul 30, 2024

Uh oh!

vshankar commented Jul 30, 2024

Uh oh!

joscollin commented Jul 30, 2024

Uh oh!

joscollin commented Aug 1, 2024

Uh oh!

joscollin commented Aug 6, 2024

Uh oh!

vshankar left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

joscollin commented Apr 9, 2024 •

edited

Loading