Skip to content

reef: qa: Add multifs root_squash testcase#56690

Merged
vshankar merged 3 commits intoceph:reeffrom
kotreshhr:wip-64940-reef
Nov 9, 2024
Merged

reef: qa: Add multifs root_squash testcase#56690
vshankar merged 3 commits intoceph:reeffrom
kotreshhr:wip-64940-reef

Conversation

@kotreshhr
Copy link
Contributor

@kotreshhr kotreshhr commented Apr 4, 2024 •
edited
Loading

backport tracker: https://tracker.ceph.com/issues/64940

backport of #55833
parent tracker: https://tracker.ceph.com/issues/64641

backport tracker: https://tracker.ceph.com/issues/65908

backport of #56846
parent tracker: https://tracker.ceph.com/issues/65246

Bot the trackers need to be backported as the #55833 has a bug.

@kotreshhr kotreshhr added this to the reef milestone Apr 4, 2024
@kotreshhr kotreshhr added the tests label Apr 4, 2024
@github-actions github-actions bot added the cephfs Ceph File System label Apr 4, 2024
@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Apr 12, 2024

Marking this as DNM because this test is broken, which wasn't discovered since it wasn't tested with vstart_runner.py or teuthology. A fix has been written for it (#56846). Both of them needs to be backported together to avoid passing same bug to release branches.

@github-actions
Copy link

github-actions bot commented May 11, 2024

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@lxbsz
Copy link
Member

lxbsz commented Jul 23, 2024

@kotreshhr Please resolve the conflicts. Thanks.

kotreshhr and others added 3 commits August 1, 2024 22:47
@kotreshhr
qa: Add multifs root_squash testcase
e0a4358 
Fixes: https://tracker.ceph.com/issues/64641
Signed-off-by: Kotresh HR <khiremat@redhat.com>
(cherry picked from commit 1fda8ed)

Conflicts:
  qa/tasks/cephfs/test_admin.py - Few of the other tests got added
in between.
@rishabh-d-dave @kotreshhr
qa/cephfs: run test_multifs_single_path_rootsquash for kclient too
6918bc1 
Root squash is valid for kclient too, Kotresh ran test recently fo it
against main branch. Therefore it is safe to remove.
ceph#56846 (comment)

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 422d98c)
@rishabh-d-dave @kotreshhr
qa/cephfs: fix test_multifs_single_path_rootsquash
08ede14 
test_multifs_single_path_rootsquash was never run with vstart_runner.py
or with teuthology and is therefore full of bugs. Fix it to make sure it
runs fine.

Introduced-by: 1fda8ed
Fixes: https://tracker.ceph.com/issues/65246
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit d9752a6)
@kotreshhr kotreshhr removed the DNM label Aug 1, 2024
@kotreshhr
Copy link
Contributor Author

kotreshhr commented Aug 1, 2024

@kotreshhr Please resolve the conflicts. Thanks.

Done

@kotreshhr
Copy link
Contributor Author

kotreshhr commented Aug 1, 2024

Marking this as DNM because this test is broken, which wasn't discovered since it wasn't tested with vstart_runner.py or teuthology. A fix has been written for it (#56846). Both of them needs to be backported together to avoid passing same bug to release branches.

Included the required PR

@kotreshhr kotreshhr requested review from a team and rishabh-d-dave August 1, 2024 17:23
@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Sep 10, 2024

This PR is under test in https://tracker.ceph.com/issues/67981.

vshankar
vshankar approved these changes Nov 9, 2024
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://tracker.ceph.com/projects/cephfs/wiki/Reef#wip-rishabh-testing-20240910100730-reef

@vshankar vshankar merged commit c13c07f into ceph:reef Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar approved these changes

@rishabh-d-dave rishabh-d-dave Awaiting requested review from rishabh-d-dave

Assignees

No one assigned

Labels

cephfs Ceph File System tests wip-rishabh-testing9

Projects

None yet

Milestone

reef

Development

Successfully merging this pull request may close these issues.

4 participants

@kotreshhr @rishabh-d-dave @lxbsz @vshankar