mgr/stats: initialize mx_last_updated in FSPerfStats#56525
Merged
mgr/stats: initialize mx_last_updated in FSPerfStats#56525
Conversation
Member
Author
|
jenkins test make check arm64 |
b8583ca to
a7a2503
Compare
Contributor
|
@joscollin I'm not understanding how a bug in mgr/stats is fixed by patching test_fstop.py. By reading the commit message it looks to me that this is an optimization, so, I'm assuming a real fix will be followed up shortly? |
a7a2503 to
7c77f9e
Compare
Member
Author
@vshankar Fixed. |
neesingh-rh
approved these changes
Apr 1, 2024
vshankar
reviewed
Apr 1, 2024
vshankar
reviewed
Apr 1, 2024
7c77f9e to
d6f2cdb
Compare
Fixes the error in teuthology log: AttributeError: 'FSPerfStats' object has no attribute 'mx_last_updated' Fixes: https://tracker.ceph.com/issues/65073 Signed-off-by: Jos Collin <jcollin@redhat.com>
d6f2cdb to
b96ad61
Compare
Member
Author
|
jenkins test make check arm64 |
vshankar
approved these changes
Apr 8, 2024
vshankar
added a commit
to vshankar/ceph
that referenced
this pull request
Apr 12, 2024
* refs/pull/56525/head: mgr/stats: initialize mx_last_updated in FSPerfStats Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com> Reviewed-by: Venky Shankar <vshankar@redhat.com>
vshankar
added a commit
to vshankar/ceph
that referenced
this pull request
Apr 30, 2024
* refs/pull/56525/head: mgr/stats: initialize mx_last_updated in FSPerfStats Reviewed-by: Venky Shankar <vshankar@redhat.com> Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
vshankar
added a commit
to vshankar/ceph
that referenced
this pull request
May 6, 2024
* refs/pull/56525/head: mgr/stats: initialize mx_last_updated in FSPerfStats Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com> Reviewed-by: Venky Shankar <vshankar@redhat.com>
vshankar
approved these changes
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/65073
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e