Skip to content

mgr/dashboard: replace deprecated table panel in grafana with a newer table panel#56509

Merged
aaSharma14 merged 1 commit intoceph:mainfrom
rhcs-dashboard:replace-table-panel-grafana
Apr 3, 2024
Merged

mgr/dashboard: replace deprecated table panel in grafana with a newer table panel#56509
aaSharma14 merged 1 commit intoceph:mainfrom
rhcs-dashboard:replace-table-panel-grafana

Conversation

@aaSharma14
Copy link
Contributor

@aaSharma14 aaSharma14 commented Mar 27, 2024 •
edited
Loading

Since the grafana table panel is deprectaed in the latest grafana versions, the existing panels should be replaced with the newer table panel

Before:

Screenshot from 2024-03-28 10-26-08

After:

Screenshot from 2024-04-02 11-49-57

Before:

Screenshot from 2024-04-02 11-37-47

After:

Screenshot from 2024-04-02 12-19-40

Before:

Screenshot from 2024-03-28 10-27-36

After:

Screenshot from 2024-04-02 12-20-21

Before:

Screenshot from 2024-03-28 10-27-59

After:

Screenshot from 2024-03-28 14-38-13

Fixes: https://tracker.ceph.com/issues/65174

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@aaSharma14 aaSharma14 requested a review from a team as a code owner March 27, 2024 08:20
@aaSharma14 aaSharma14 force-pushed the replace-table-panel-grafana branch from bfa693b to e172f7a Compare March 27, 2024 12:34
nizamial09
nizamial09 approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@nizamial09 nizamial09 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from the dropdown in this chart, everything looks good to me. thanks

Screenshot from 2024-03-27 14-59-19

@cloudbehl
Copy link
Contributor

cloudbehl commented Mar 27, 2024

should go after this: #56509

@cloudbehl
Copy link
Contributor

cloudbehl commented Mar 27, 2024

can you record a demo and point which one are you replace and screenshot of comparison

@nizamial09
Copy link
Member

nizamial09 commented Mar 27, 2024

should go after this: #56509

the PR you pasted here is the same PR.

@nizamial09
Copy link
Member

nizamial09 commented Mar 27, 2024 

jsonnet-lint: exit 1 (0.75 seconds) /home/jenkins-build/build/workspace/ceph-pull-requests/monitoring/ceph-mixin> ./lint-jsonnet.sh --test pid=1860617
  jsonnet-lint: FAIL code 1 (11.04=setup[10.29]+cmd[0.75] seconds)
  evaluation failed :( (11.71 seconds)

@nizamial09 nizamial09 mentioned this pull request Mar 27, 2024
Merged
14 tasks
@aaSharma14 aaSharma14 force-pushed the replace-table-panel-grafana branch 3 times, most recently from d6619a2 to 0fa8017 Compare March 28, 2024 10:06
@aaSharma14 aaSharma14 mentioned this pull request Mar 29, 2024
Merged
14 tasks
@aaSharma14 aaSharma14 force-pushed the replace-table-panel-grafana branch from 0fa8017 to 2229f45 Compare March 29, 2024 06:31
@cloudbehl
Copy link
Contributor

cloudbehl commented Mar 29, 2024

Hey @aaSharma14 In pool overview table.

Top slow ops per host -> Before and After is not matching, the instance value is changed with time.

type -> Type and values is Replica:3(in my cluster and yours says replicated) or Erasure coded 2+2/4+2

image

Highest Write latencies: We can put 0.00 rather than NaN

Read and write latencies needs to be sorted by latency, its not visible in screenshot I hope its working.

mgr/dashboard: replace deprecated table panel in grafana with a newer
c2f4aa7 
table panel

Fixes: https://tracker.ceph.com/issues/65174

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
@aaSharma14 aaSharma14 force-pushed the replace-table-panel-grafana branch from 2229f45 to c2f4aa7 Compare April 2, 2024 06:53
@aaSharma14
Copy link
Contributor Author

aaSharma14 commented Apr 2, 2024

Hey @aaSharma14 In pool overview table.

Top slow ops per host -> Before and After is not matching, the instance value is changed with time.

type -> Type and values is Replica:3(in my cluster and yours says replicated) or Erasure coded 2+2/4+2

image

Highest Write latencies: We can put 0.00 rather than NaN

Read and write latencies needs to be sorted by latency, its not visible in screenshot I hope its working.

Thanks @cloudbehl , Updated the PR

@aaSharma14
Copy link
Contributor Author

aaSharma14 commented Apr 2, 2024

jenkins test dashboard cephadm

@aaSharma14
Copy link
Contributor Author

aaSharma14 commented Apr 3, 2024

jenkins test dashboard cephadm

1 similar comment
@aaSharma14
Copy link
Contributor Author

aaSharma14 commented Apr 3, 2024

jenkins test dashboard cephadm

@aaSharma14 aaSharma14 merged commit 2354b84 into ceph:main Apr 3, 2024
@aaSharma14 aaSharma14 deleted the replace-table-panel-grafana branch April 3, 2024 07:40
This was referenced Apr 3, 2024
Merged
Merged
Merged
aaSharma14 pushed a commit to rhcs-dashboard/ceph that referenced this pull request Apr 6, 2024
mgr/dashboard: add Table Schema to grafonnet
0b778c8 
Backport of ceph#56509 in reef didn't include the Table Schema in the
utils.libsonnet because of which the json generation ias failing. This
PR tends to add the Table Schema

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
@aaSharma14 aaSharma14 mentioned this pull request Apr 6, 2024
Merged
14 tasks
aaSharma14 pushed a commit to rhcs-dashboard/ceph that referenced this pull request Apr 6, 2024
mgr/dashboard: add Table Schema to grafonnet
f81cd18 
Backport of ceph#56509 in quincy didn't include the Table Schema in the utils.libsonnet because of which the json generation ias failing. This PR tends to add the Table Schema

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
@aaSharma14 aaSharma14 mentioned this pull request Apr 6, 2024
Merged
14 tasks
mkogan1 pushed a commit to mkogan1/ceph that referenced this pull request Apr 10, 2024
@aaSharma14
mgr/dashboard: add Table Schema to grafonnet
8d3bb51 
Backport of ceph#56509 in quincy didn't include the Table Schema in the utils.libsonnet because of which the json generation ias failing. This PR tends to add the Table Schema

Resolves: rhbz#2272988

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit f81cd18)
mkogan1 pushed a commit to mkogan1/ceph that referenced this pull request May 8, 2024
@aaSharma14
mgr/dashboard: add Table Schema to grafonnet
6392459 
Backport of ceph#56509 in reef didn't include the Table Schema in the
utils.libsonnet because of which the json generation ias failing. This
PR tends to add the Table Schema

Resolve: rhbz#2272997

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit 0b778c8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cloudbehl cloudbehl cloudbehl approved these changes

@nizamial09 nizamial09 nizamial09 approved these changes

Assignees

No one assigned

Labels

dashboard monitoring

Projects

Ceph-Dashboard
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aaSharma14 @cloudbehl @nizamial09