Skip to content

cephfs_mirror: increment sync_failures when sync_perms() and sync_snaps() fails#56135

Merged
vshankar merged 1 commit intoceph:mainfrom
joscollin:wip-inc-failures-sync-perms
May 13, 2024
Merged

cephfs_mirror: increment sync_failures when sync_perms() and sync_snaps() fails#56135
vshankar merged 1 commit intoceph:mainfrom
joscollin:wip-inc-failures-sync-perms

Conversation

@joscollin
Copy link
Member

@joscollin joscollin commented Mar 12, 2024

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@github-actions github-actions bot added the cephfs Ceph File System label Mar 12, 2024
@joscollin joscollin force-pushed the wip-inc-failures-sync-perms branch from 761ba16 to ac83a5a Compare March 12, 2024 06:19
@joscollin
Copy link
Member Author

jenkins test api

Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@joscollin joscollin requested a review from vshankar March 14, 2024 13:13
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

@joscollin joscollin force-pushed the wip-inc-failures-sync-perms branch from 81ead13 to 3fde866 Compare March 14, 2024 14:26
@joscollin joscollin requested a review from vshankar March 14, 2024 14:26
@joscollin joscollin force-pushed the wip-inc-failures-sync-perms branch from 3fde866 to 2a7b12a Compare March 15, 2024 01:46
@joscollin joscollin requested a review from vshankar March 15, 2024 01:47
@joscollin
Copy link
Member Author

jenkins test api

@joscollin
Copy link
Member Author

@rishabh-d-dave Please do qa

@vshankar
Copy link
Contributor

vshankar commented Apr 5, 2024

@joscollin please create a tracker and link it in the commit message. This needs to be backported.

@joscollin joscollin changed the title cephfs_mirror: inc sync_failures when sync_perms() fails cephfs_mirror: increment sync_failures when sync_perms() and sync_snaps() fails Apr 5, 2024
@joscollin joscollin force-pushed the wip-inc-failures-sync-perms branch from 2a7b12a to aefa6e2 Compare April 5, 2024 05:35
@joscollin
Copy link
Member Author

@joscollin please create a tracker and link it in the commit message. This needs to be backported.

@vshankar Linked https://tracker.ceph.com/issues/65345.

@joscollin
Copy link
Member Author

jenkins test api

@joscollin joscollin force-pushed the wip-inc-failures-sync-perms branch from aefa6e2 to feb929b Compare April 8, 2024 07:29
@joscollin
Copy link
Member Author

jenkins test make check

…ps() fails

When sync_perms() fails  _inc_failed_count() is called for incrementing the failed count.
So it's better reflect that in the metrics too. Does the same for sync_snaps() too.

Fixes: https://tracker.ceph.com/issues/65345
Signed-off-by: Jos Collin <jcollin@redhat.com>
@joscollin joscollin force-pushed the wip-inc-failures-sync-perms branch from feb929b to 57ec7c7 Compare April 10, 2024 12:16
vshankar added a commit to vshankar/ceph that referenced this pull request Apr 12, 2024
* refs/pull/56135/head:
	cephfs_mirror: increment sync_failures when sync_perms() and sync_snaps() fails

Reviewed-by: Venky Shankar <vshankar@redhat.com>
@joscollin
Copy link
Member Author

jenkins test make check

Copy link
Contributor

@rishabh-d-dave rishabh-d-dave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vshankar added a commit to vshankar/ceph that referenced this pull request Apr 30, 2024
* refs/pull/56135/head:
	cephfs_mirror: increment sync_failures when sync_perms() and sync_snaps() fails

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
vshankar added a commit to vshankar/ceph that referenced this pull request May 6, 2024
* refs/pull/56135/head:
	cephfs_mirror: increment sync_failures when sync_perms() and sync_snaps() fails

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants