Skip to content

DNM: RGW: Make RADOS handles in RGW to be a configurable option#5612

Closed
prallabh wants to merge 2 commits intoceph:hammerfrom
prallabh:hammer
Closed

DNM: RGW: Make RADOS handles in RGW to be a configurable option#5612
prallabh wants to merge 2 commits intoceph:hammerfrom
prallabh:hammer

Conversation

@prallabh
Copy link

@loic-bot
Copy link

@ghost
Copy link

ghost commented Aug 21, 2015

@prallabh could you please cherry-pick -x the commit to be backported and repush ?

git reset --hard ceph/hammer
git cherry-pick -x 77e0084
git push --force origin hammer

assuming origin is the remote of your github clone and ceph is the remote of the official repository.

@ghost ghost self-assigned this Aug 21, 2015
@ghost ghost added feature rgw labels Aug 21, 2015
@ghost ghost added this to the hammer milestone Aug 21, 2015
@ghost
Copy link

ghost commented Aug 21, 2015

@yehudasa could you please confirm that this feature should be backported to hammer ?

@prallabh
Copy link
Author

@dachary This PR is with your suggestion of 'cheery-pick -x', please let me know if am missing anything else.

@yehudasa
Copy link
Member

@dachary confirmed

@loic-bot
Copy link

@ghost
Copy link

ghost commented Aug 21, 2015

@prallabh could you please rebase and repush to trigger the bot again ? It looks like this is a not a real error.

@ghost
Copy link

ghost commented Aug 21, 2015

@prallabh this PR has a single commit 15234a9 and it is not the result of cherry-pick -x b3c3a24

Pavan Rallabhandi added 2 commits August 24, 2015 20:58
Having a configurable number of RADOS handles is resulting
in significant performance boost for all types of workloads.
Each RGW worker thread would now get to pick a RADOS handle
for its lifetime, from the available bunch.

Signed-off-by: Pavan Rallabhandi <pavan.rallabhandi@sandisk.com>
(cherry picked from commit b3c3a24)
Signed-off-by: Pavan Rallabhandi <pavan.rallabhandi@sandisk.com>
(cherry picked from commit 7476e94)
@ghost
Copy link

ghost commented Aug 24, 2015

@prallabh looks good, thanks

@loic-bot
Copy link

ghost pushed a commit that referenced this pull request Aug 30, 2015
…igurable option

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost
Copy link

ghost commented Aug 30, 2015

@prallabh is there an issue matching this change in http://tracker.ceph.com/ ?

@prallabh
Copy link
Author

@dachary if you are referring to, whether we have a tracker for this change set, there ain't any. Do you want me to create one? We never had one even for the original PR on the master.

ghost pushed a commit that referenced this pull request Aug 31, 2015
…igurable option

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost ghost changed the title RGW: Make RADOS handles in RGW to be a configurable option DNM: RGW: Make RADOS handles in RGW to be a configurable option Sep 1, 2015
@ghost
Copy link

ghost commented Sep 1, 2015

@prallabh it's ok to create an issue even after the commits have been merged. And it helps with tracking backports. Could you create one for the original PR on the master ? I'll take care of the things related to the backport.

@ghost
Copy link

ghost commented Sep 1, 2015

Marked DNM because it's already included in #5717

@prallabh
Copy link
Author

prallabh commented Sep 1, 2015

@dachary Please find the tracker http://tracker.ceph.com/issues/12893. Please update the relevant fields in the tracker appropriately if they are out of place.

@theanalyst
Copy link
Member

Merged in #5717 onto hammer branch .. this can be closed.

@theanalyst theanalyst closed this Oct 5, 2015
@ghost
Copy link

ghost commented Oct 5, 2015

@theanalyst nice catch :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants