Skip to content

qa: enhance per-client labelled perf counters test#56052

Merged
vshankar merged 2 commits intoceph:mainfrom
joscollin:wip-B64486-enhance-per-client-perf-counter-tests
Jun 25, 2024
Merged

qa: enhance per-client labelled perf counters test#56052
vshankar merged 2 commits intoceph:mainfrom
joscollin:wip-B64486-enhance-per-client-perf-counter-tests

Conversation

@joscollin
Copy link
Member

@joscollin joscollin commented Mar 8, 2024 •
edited
Loading

Fixes: https://tracker.ceph.com/issues/65497

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@github-actions github-actions bot added cephfs Ceph File System tests labels Mar 8, 2024
@joscollin joscollin force-pushed the wip-B64486-enhance-per-client-perf-counter-tests branch from 641265e to fd611b0 Compare March 8, 2024 04:07
@joscollin joscollin changed the title qa: enhance per-client labelled perf counters qa: enhance per-client labelled perf counters test Mar 8, 2024
@joscollin joscollin force-pushed the wip-B64486-enhance-per-client-perf-counter-tests branch 3 times, most recently from e99b42c to ff96a32 Compare March 8, 2024 16:37
@joscollin
Copy link
Member Author

joscollin commented Mar 11, 2024

jenkins test make check

@joscollin joscollin force-pushed the wip-B64486-enhance-per-client-perf-counter-tests branch from ff96a32 to ace7509 Compare March 11, 2024 08:46
@joscollin
Copy link
Member Author

joscollin commented Mar 11, 2024

Tests passed: https://pulpito.ceph.com/jcollin-2024-03-11_08:54:59-fs:functional-wip-ssharon-test2-2024-03-10-1648-distro-default-smithi/

@vshankar
Copy link
Contributor

vshankar commented Mar 12, 2024

jenkins retest this please

@vshankar vshankar requested a review from a team March 12, 2024 10:44
vshankar
vshankar reviewed Mar 12, 2024
View reviewed changes
@joscollin
Copy link
Member Author

joscollin commented Mar 13, 2024

jenkins test make check

vshankar
vshankar requested changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Suggest also adding verifying perf counters when new clients connect and some clients disconnect/reconnect.

@joscollin
Copy link
Member Author

joscollin commented Mar 13, 2024

Looks fine. Suggest also adding verifying perf counters when new clients connect and some clients disconnect/reconnect.

Do we have such events already tested somewhere? Or need to create a new test?

@joscollin
Copy link
Member Author

joscollin commented Mar 13, 2024

Looks fine. Suggest also adding verifying perf counters when new clients connect and some clients disconnect/reconnect.

Do we have such events already tested somewhere? Or need to create a new test?

never mind, got it.

@joscollin joscollin force-pushed the wip-B64486-enhance-per-client-perf-counter-tests branch from ace7509 to f841125 Compare March 13, 2024 13:13
@joscollin
Copy link
Member Author

joscollin commented Mar 13, 2024

Looks fine. Suggest also adding verifying perf counters when new clients connect and some clients disconnect/reconnect.

@vshankar Added more tests. Please take a look.

@joscollin joscollin force-pushed the wip-B64486-enhance-per-client-perf-counter-tests branch from f841125 to 7c641c8 Compare March 13, 2024 15:37
@joscollin joscollin marked this pull request as draft March 14, 2024 01:31
@joscollin joscollin force-pushed the wip-B64486-enhance-per-client-perf-counter-tests branch from 7c641c8 to 8e2453f Compare March 14, 2024 06:01
@joscollin joscollin marked this pull request as ready for review March 14, 2024 06:01
@joscollin joscollin force-pushed the wip-B64486-enhance-per-client-perf-counter-tests branch from 8e2453f to d66fce6 Compare March 14, 2024 07:27
@joscollin joscollin marked this pull request as draft March 14, 2024 10:40
@joscollin joscollin force-pushed the wip-B64486-enhance-per-client-perf-counter-tests branch from d66fce6 to 07e71f2 Compare March 14, 2024 14:01
@joscollin joscollin marked this pull request as ready for review March 14, 2024 14:02
@joscollin
Copy link
Member Author

joscollin commented Mar 14, 2024

Tests passed: https://pulpito.ceph.com/jcollin-2024-03-14_13:02:11-fs:functional-main-distro-default-smithi/

@joscollin joscollin requested a review from vshankar March 14, 2024 14:03
vshankar
vshankar requested changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

@joscollin joscollin force-pushed the wip-B64486-enhance-per-client-perf-counter-tests branch from ea7e37c to 0553515 Compare May 3, 2024 10:47
@vshankar
Copy link
Contributor

vshankar commented May 6, 2024

jenkins retest this please

@joscollin joscollin force-pushed the wip-B64486-enhance-per-client-perf-counter-tests branch from 0553515 to 2366958 Compare May 6, 2024 06:55
vshankar added a commit to vshankar/ceph that referenced this pull request May 6, 2024
@vshankar
Merge PR ceph#56052 into wip-vshankar-testing-20240506.153513
8e169dd 
* refs/pull/56052/head:
	qa/suites: ignore unresponsive client when the test passes
	qa: enhance per-client labelled perf counters test

Reviewed-by: Venky Shankar <vshankar@redhat.com>
@joscollin
Copy link
Member Author

joscollin commented May 9, 2024

jenkins test make check

@vshankar
Copy link
Contributor

vshankar commented May 9, 2024

https://pulpito.ceph.com/vshankar-2024-05-07_03:44:24-fs-wip-vshankar-testing-20240506.153513-testing-default-smithi/

(unfortunately, failed are infra issues related to cephadm - would need a rebuild)

@vshankar
Copy link
Contributor

vshankar commented May 9, 2024

jenkins test make check

@vshankar
Copy link
Contributor

vshankar commented May 9, 2024

This PR is under test in https://tracker.ceph.com/issues/65882.

@vshankar
Copy link
Contributor

vshankar commented May 16, 2024

None of the tests in this change ran since the job ran into https://tracker.ceph.com/issues/65841 (fix for which is under dev/test). I'm afraid, this change has to be retested :/

@joscollin
Copy link
Member Author

joscollin commented May 16, 2024

None of the tests in this change ran since the job ran into https://tracker.ceph.com/issues/65841 (fix for which is under dev/test). I'm afraid, this change has to be retested :/

@vshankar
Please retest it in your another test branch. It should be the issue with https://tracker.ceph.com/issues/65841, as it passed in my tests.

@github-actions
Copy link

github-actions bot commented May 17, 2024

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

joscollin added 2 commits May 17, 2024 20:56
@joscollin
qa: enhance per-client labelled perf counters test
5337a12 
Fixes: https://tracker.ceph.com/issues/65497
Signed-off-by: Jos Collin <jcollin@redhat.com>
@joscollin
qa/suites: ignore unresponsive client when the test passes
5f2a3a7 
Ignores the unresponsive client caused by fs.fail() in test_per_client_labeled_perf_counters_on_client_reconnect

Fixes: https://tracker.ceph.com/issues/65497
Signed-off-by: Jos Collin <jcollin@redhat.com>
@joscollin joscollin force-pushed the wip-B64486-enhance-per-client-perf-counter-tests branch from 2366958 to 5f2a3a7 Compare May 17, 2024 15:28
@joscollin
Copy link
Member Author

joscollin commented May 17, 2024

rebased

@joscollin
Copy link
Member Author

joscollin commented May 27, 2024

jenkins test windows

@vshankar
Copy link
Contributor

vshankar commented Jun 3, 2024

This PR is under test in https://tracker.ceph.com/issues/66327.

@vshankar
Copy link
Contributor

vshankar commented Jun 17, 2024

This PR is under test in https://tracker.ceph.com/issues/66522.

@joscollin
Copy link
Member Author

joscollin commented Jun 18, 2024

jenkins test windows

vshankar
vshankar approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://tracker.ceph.com/projects/cephfs/wiki/Main#wip-vshankar-testing-20240617094253-debug

(https://tracker.ceph.com/issues/66522)

@vshankar vshankar merged commit d17c681 into ceph:main Jun 25, 2024
@joscollin joscollin deleted the wip-B64486-enhance-per-client-perf-counter-tests branch June 25, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar approved these changes

Assignees

No one assigned

Labels

cephfs Ceph File System tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joscollin @vshankar