Skip to content

mgr/volumes: fix dangling symlink in clone index#55838

Merged
rishabh-d-dave merged 2 commits intoceph:mainfrom
neesingh-rh:wip-58090
Feb 28, 2025
Merged

mgr/volumes: fix dangling symlink in clone index#55838
rishabh-d-dave merged 2 commits intoceph:mainfrom
neesingh-rh:wip-58090

Conversation

@neesingh-rh
Copy link
Contributor

@neesingh-rh neesingh-rh commented Feb 29, 2024 •
edited
Loading

Fixes: https://tracker.ceph.com/issues/58090
Signed-off-by: Neeraj Pratap Singh neesingh@redhat.com

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@neesingh-rh neesingh-rh marked this pull request as draft February 29, 2024 11:32
@github-actions github-actions bot added cephfs Ceph File System pybind labels Feb 29, 2024
@neesingh-rh neesingh-rh marked this pull request as ready for review March 4, 2024 06:07
@vshankar vshankar requested a review from a team March 14, 2024 17:44
dparmar18
dparmar18 reviewed Mar 19, 2024
View reviewed changes
@dparmar18
Copy link
Contributor

dparmar18 commented Mar 19, 2024

Having a test case here would be good IMO

dparmar18
dparmar18 reviewed Mar 19, 2024
View reviewed changes
dparmar18
dparmar18 reviewed Mar 19, 2024
View reviewed changes
dparmar18
dparmar18 reviewed Mar 19, 2024
View reviewed changes
dparmar18
dparmar18 reviewed Mar 19, 2024
View reviewed changes
@vshankar vshankar requested a review from a team April 2, 2024 05:32
@neesingh-rh neesingh-rh force-pushed the wip-58090 branch 2 times, most recently from e998d03 to f08f967 Compare April 4, 2024 11:55
@github-actions github-actions bot added the tests label Apr 17, 2024
@neesingh-rh neesingh-rh force-pushed the wip-58090 branch 2 times, most recently from b5e6d6e to d9632ef Compare April 24, 2024 10:02
@neesingh-rh
Copy link
Contributor Author

neesingh-rh commented May 1, 2024

jenkins test windows

@neesingh-rh neesingh-rh force-pushed the wip-58090 branch 3 times, most recently from 1836a1f to c94c5b2 Compare May 9, 2024 11:52
@neesingh-rh neesingh-rh requested a review from a team as a code owner June 12, 2024 10:15
@neesingh-rh neesingh-rh requested review from Pegonzal and nizamial09 and removed request for a team June 12, 2024 10:15
vshankar
vshankar reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

rishabh-d-dave
rishabh-d-dave approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@rishabh-d-dave rishabh-d-dave left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@rishabh-d-dave rishabh-d-dave added the wip-rishabh-testing Rishabh's testing label label Nov 19, 2024
vshankar
vshankar approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

@neesingh-rh neesingh-rh force-pushed the wip-58090 branch 3 times, most recently from 0b07442 to af26025 Compare November 20, 2024 08:17
piyushagarwal1411 pushed a commit to piyushagarwal1411/ceph that referenced this pull request Nov 26, 2024
mgr/vol : shortening the name of function
6c3e5a2 
Fixes: https://tracker.ceph.com/issues/66815
Introduced by:ceph#55838 (comment)
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
@kotreshhr
Copy link
Contributor

kotreshhr commented Nov 28, 2024

jenkins test make check

@kotreshhr
Copy link
Contributor

kotreshhr commented Nov 28, 2024

jenkins test make check arm64

@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Nov 29, 2024 •
edited
Loading

@neesingh-rh make check failure is related

flake8 error -

flake8: commands[0] /home/jenkins-build/build/workspace/ceph-pull-requests/qa> flake8 --select=F,E9 --exclude=venv,.tox
./tasks/cephfs/test_volumes.py:18:1: F811 redefinition of unused 'safe_while' from line 16

tox failure -

volumes/fs/operations/versions/__init__.py:9: note: In module imported here,
volumes/fs/operations/subvolume.py:6: note: ... from here,
volumes/fs/volume.py:24: note: ... from here,
volumes/module.py:9: note: ... from here,
volumes/__init__.py:2: note: ... from here:
volumes/fs/operations/versions/subvolume_v1.py: note: In member "get_pending_clones" of class "SubvolumeV1":
volumes/fs/operations/versions/subvolume_v1.py:811: error: Incompatible types in assignment (expression has type "Path", variable has type "str")  [assignment]
volumes/fs/operations/versions/subvolume_v1.py:813: error: "str" has no attribute "parent"  [attr-defined]
Found 2 errors in 1 file (checked 32 source files)

@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Nov 29, 2024

jenkins test api

JonBailey1993 pushed a commit to JonBailey1993/ceph that referenced this pull request Dec 2, 2024
@JonBailey1993
mgr/vol : shortening the name of function
5cb241e 
Fixes: https://tracker.ceph.com/issues/66815
Introduced by:ceph#55838 (comment)
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Dec 4, 2024

@neesingh-rh make check failure is related

flake8 error -

flake8: commands[0] /home/jenkins-build/build/workspace/ceph-pull-requests/qa> flake8 --select=F,E9 --exclude=venv,.tox
./tasks/cephfs/test_volumes.py:18:1: F811 redefinition of unused 'safe_while' from line 16

tox failure -

volumes/fs/operations/versions/__init__.py:9: note: In module imported here,
volumes/fs/operations/subvolume.py:6: note: ... from here,
volumes/fs/volume.py:24: note: ... from here,
volumes/module.py:9: note: ... from here,
volumes/__init__.py:2: note: ... from here:
volumes/fs/operations/versions/subvolume_v1.py: note: In member "get_pending_clones" of class "SubvolumeV1":
volumes/fs/operations/versions/subvolume_v1.py:811: error: Incompatible types in assignment (expression has type "Path", variable has type "str")  [assignment]
volumes/fs/operations/versions/subvolume_v1.py:813: error: "str" has no attribute "parent"  [attr-defined]
Found 2 errors in 1 file (checked 32 source files)

@neesingh-rh ping

@rishabh-d-dave rishabh-d-dave removed the wip-rishabh-testing Rishabh's testing label label Dec 4, 2024
mgr/volumes: handling dangling symlinks gracefully
efb119e 
If we come across situations where we encounter dangling
symlinks for clones due to any reason,like older versions
may have produced dangling clone symlinks which remained
post-upgrade, it needs to be handled gracefully by deleting
it, presence of which may not allow deletion of the snapshot.
We are now cleaning those up in the snapshot info command.

Fixes: https://tracker.ceph.com/issues/58090
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
qa: add tests for fixing dangling symlink
82d4647 
Fixes: https://tracker.ceph.com/issues/58090
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
@rishabh-d-dave rishabh-d-dave added the wip-rishabh-testing Rishabh's testing label label Dec 4, 2024
joscollin pushed a commit to joscollin/ceph that referenced this pull request Dec 12, 2024
@rishabh-d-dave
Merge PR ceph#55838 into wip-rishabh-testing-20241204.130505
bcd3af8 
* refs/pull/55838/head:
	qa: add tests for fixing dangling symlink
	mgr/volumes: handling dangling symlinks gracefully

Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
@github-actions
Copy link

github-actions bot commented Feb 2, 2025

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@neesingh-rh
Copy link
Contributor Author

neesingh-rh commented Feb 2, 2025

@rishabh-d-dave ping?

@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Feb 4, 2025

@rishabh-d-dave ping?

Working on a BZ, will catch up on this ASAP.

@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Feb 7, 2025

This PR is under test in https://tracker.ceph.com/issues/69872.

@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Feb 7, 2025

This PR is under test in https://tracker.ceph.com/issues/69873.

rishabh-d-dave
rishabh-d-dave approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@rishabh-d-dave rishabh-d-dave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA run was successful. https://tracker.ceph.com/projects/cephfs/wiki/Main#wip-rishabh-testing-20250207204003-debug-4

This was referenced Mar 4, 2025
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dparmar18 dparmar18 dparmar18 left review comments

@vshankar vshankar vshankar approved these changes

@rishabh-d-dave rishabh-d-dave rishabh-d-dave approved these changes

@kotreshhr kotreshhr kotreshhr approved these changes

+1 more reviewer

@leonid-s-usov leonid-s-usov leonid-s-usov left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@rishabh-d-dave rishabh-d-dave

@kotreshhr kotreshhr

Labels

cephfs Ceph File System pybind tests wip-rishabh-testing Rishabh's testing label

Projects

Ceph-Dashboard
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@neesingh-rh @dparmar18 @rishabh-d-dave @kotreshhr @vshankar @leonid-s-usov