Skip to content

cephfs-shell: fixing cephfs-shell test failures#55808

Merged
vshankar merged 1 commit intoceph:mainfrom
neesingh-rh:wip-63700
Oct 17, 2024
Merged

cephfs-shell: fixing cephfs-shell test failures#55808
vshankar merged 1 commit intoceph:mainfrom
neesingh-rh:wip-63700

Conversation

@neesingh-rh
Copy link
Contributor

@neesingh-rh neesingh-rh commented Feb 28, 2024 •
edited
Loading

Seeing cephfs-shell failures in Ubuntu22.04 due to its weird behaviour with python3-cmd2's version

Fixes: https://tracker.ceph.com/issues/63700
Signed-off-by: Neeraj Pratap Singh neesingh@redhat.com

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@neesingh-rh neesingh-rh marked this pull request as draft February 28, 2024 08:39
@github-actions github-actions bot added cephfs Ceph File System tests labels Feb 28, 2024
@neesingh-rh neesingh-rh removed cephfs Ceph File System tests labels Feb 28, 2024
@github-actions github-actions bot added cephfs Ceph File System tests labels Feb 28, 2024
@neesingh-rh neesingh-rh force-pushed the wip-63700 branch 2 times, most recently from e0b5191 to daef686 Compare February 29, 2024 12:44
@neesingh-rh neesingh-rh force-pushed the wip-63700 branch 5 times, most recently from 2ee4b2c to 240a386 Compare March 14, 2024 18:56
@vshankar vshankar requested a review from a team April 1, 2024 14:33
@vshankar
Copy link
Contributor

vshankar commented Apr 1, 2024

@neesingh-rh status of this?

@neesingh-rh
Copy link
Contributor Author

neesingh-rh commented Apr 2, 2024

@neesingh-rh status of this?

The issue is not still fixed, in progress!

@vshankar
Copy link
Contributor

vshankar commented May 15, 2024

@neesingh-rh any update on this?

@neesingh-rh
Copy link
Contributor Author

neesingh-rh commented May 23, 2024

@neesingh-rh any update on this?

Need to re-visit this issue

@batrick
Copy link
Member

batrick commented Jun 4, 2024

Status?

batrick
batrick reviewed Jun 4, 2024
View reviewed changes
Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please title your commits according to the conventions of this project. This is required for your PR to be merged.

See this article on GitHub on how to amend commits and update your pull request.

batrick
batrick previously requested changes Jun 4, 2024
View reviewed changes
Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please annotate the commit message which fixes/resolves a Ceph tracker issue with:

Fixes: http://tracker.ceph.com/issues/...

This is essential when examining the history of the repository (this commit fixes what) and helps merge scripts identify issues that have been resolved by a merge. See this article on GitHub on how to amend commits and update your pull request.

@neesingh-rh
Copy link
Contributor Author

neesingh-rh commented Jun 5, 2024

Please annotate the commit message which fixes/resolves a Ceph tracker issue with:

Fixes: http://tracker.ceph.com/issues/...

This is essential when examining the history of the repository (this commit fixes what) and helps merge scripts identify issues that have been resolved by a merge. See this article on GitHub on how to amend commits and update your pull request.

I will change title and commit message after the fix is ready, its just that the issue is not still fixed and this PR was created to test the changes and debug the issue on teuthology

@github-actions
Copy link

github-actions bot commented Aug 4, 2024

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Aug 4, 2024
@vshankar vshankar removed the stale label Aug 5, 2024
@vshankar
Copy link
Contributor

vshankar commented Aug 12, 2024

@neesingh-rh Any update on this?

@neesingh-rh neesingh-rh requested review from a team and vshankar September 30, 2024 08:15
@vshankar
Copy link
Contributor

vshankar commented Sep 30, 2024

For now, we should go with this fix to avoid our test run failures.
Test Run after this fix: https://pulpito.ceph.com/neesingh-2024-09-28_02:13:02-fs:shell-wip-neesingh-testing2-270924-distro-default-smithi/

Can't that block of code catch errno 127 and then retry with run_script?

@neesingh-rh
Copy link
Contributor Author

neesingh-rh commented Sep 30, 2024

For now, we should go with this fix to avoid our test run failures.
Test Run after this fix: https://pulpito.ceph.com/neesingh-2024-09-28_02:13:02-fs:shell-wip-neesingh-testing2-270924-distro-default-smithi/

Can't that block of code catch errno 127 and then retry with run_script?

We may end up cancelling the actual possibility for error no 127 by this way,no?

@vshankar
Copy link
Contributor

vshankar commented Sep 30, 2024

For now, we should go with this fix to avoid our test run failures.
Test Run after this fix: https://pulpito.ceph.com/neesingh-2024-09-28_02:13:02-fs:shell-wip-neesingh-testing2-270924-distro-default-smithi/

Can't that block of code catch errno 127 and then retry with run_script?

We may end up cancelling the actual possibility for error no 127 by this way,no?

the exception block would invoke run_script which would fail again IMO. WDYT?

@neesingh-rh
Copy link
Contributor Author

neesingh-rh commented Sep 30, 2024 •
edited
Loading

For now, we should go with this fix to avoid our test run failures.
Test Run after this fix: https://pulpito.ceph.com/neesingh-2024-09-28_02:13:02-fs:shell-wip-neesingh-testing2-270924-distro-default-smithi/

Can't that block of code catch errno 127 and then retry with run_script?

And one more thing due to the same reason we are seeing this failure in Ubuntu22.04 even after the #55725 fix: https://pulpito.ceph.com/neesingh-2024-09-26_09:20:05-fs:shell-main-distro-default-smithi/ , I ran this test after commenting out all uses of run_script and found that this is failing due to the same reason.

@neesingh-rh
Copy link
Contributor Author

neesingh-rh commented Sep 30, 2024

For now, we should go with this fix to avoid our test run failures.
Test Run after this fix: https://pulpito.ceph.com/neesingh-2024-09-28_02:13:02-fs:shell-wip-neesingh-testing2-270924-distro-default-smithi/

Can't that block of code catch errno 127 and then retry with run_script?

We may end up cancelling the actual possibility for error no 127 by this way,no?

the exception block would invoke run_script which would fail again IMO. WDYT?

Due to this reason too #55808 (comment), I think we should go ahead with the current fix for now.

@neesingh-rh
Copy link
Contributor Author

neesingh-rh commented Sep 30, 2024 •
edited
Loading

The fact is that it is going to affect the whole cephfs-shell script wherever cmd2 version being used that's why I added this globally at the start.

vshankar
vshankar reviewed Oct 1, 2024
View reviewed changes
vshankar
vshankar reviewed Oct 3, 2024
View reviewed changes
src/tools/cephfs/shell/cephfs-shell
# XXX: In cmd2 versions < 1.0.1, we'll get SystemExit(2) instead of
# Cmd2ArgparseError
if Version(cmd2_version) >= Version("1.0.1"):
DFLAG = False
Copy link
Contributor

@vshankar vshankar Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please comment the usage of this flag and maybe its better to call it an override.

cephfs-shell: fixing the cephfs-shell test failures
8d2d54f 
cephfs-shell is failing in Ubuntu22.04, because it is
behaving weirdly with cmd2's version. It is taking cmd2
version as 0.0.0 instead of the correct version.

Fixes: https://tracker.ceph.com/issues/63700
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
@neesingh-rh neesingh-rh requested a review from vshankar October 3, 2024 20:00
@neesingh-rh
Copy link
Contributor Author

neesingh-rh commented Oct 4, 2024

jenkins retest this please

@vshankar
Copy link
Contributor

vshankar commented Oct 7, 2024

@neesingh-rh please run this through cephfs-shell tests and post the results here.

@vshankar
Copy link
Contributor

vshankar commented Oct 7, 2024

jenkins test api

@neesingh-rh
Copy link
Contributor Author

neesingh-rh commented Oct 8, 2024

@neesingh-rh please run this through cephfs-shell tests and post the results here.

@vshankar Here's the run link: https://pulpito.ceph.com/neesingh-2024-09-28_02:13:02-fs:shell-wip-neesingh-testing2-270924-distro-default-smithi/

@vshankar
Copy link
Contributor

vshankar commented Oct 15, 2024

jenkins test api

@vshankar
Copy link
Contributor

vshankar commented Oct 16, 2024

jenkins test api

@vshankar vshankar dismissed batrick’s stale review October 17, 2024 06:30

Comment addressed.

@vshankar vshankar merged commit 20af41d into ceph:main Oct 17, 2024
This was referenced Oct 21, 2024
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar approved these changes

@batrick batrick Awaiting requested review from batrick

Assignees

No one assigned

Labels

cephfs Ceph File System ready-to-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@neesingh-rh @vshankar @batrick