Conversation
04141d1 to
5d8d636
Compare
Member
Author
|
jenkins test make check |
vshankar
requested changes
Feb 27, 2024
Contributor
vshankar
left a comment
There was a problem hiding this comment.
This change would require mentions in documentation and PendingReleaseNotes.
5d8d636 to
d0e5b77
Compare
Member
Author
|
@vshankar Will update the documentation. |
d0e5b77 to
70bd491
Compare
Member
Author
|
@vshankar Updated the documentation. Please check. |
vshankar
requested changes
Feb 28, 2024
Contributor
vshankar
left a comment
There was a problem hiding this comment.
We might include/change qa tests that needs fixing. Please check those.
70bd491 to
bb8b899
Compare
Member
Author
@vshankar Updated the qa changes. |
f2bc443 to
2389f00
Compare
Contributor
chrisphoffman
left a comment
There was a problem hiding this comment.
You missed adding --yes-i-really-really-mean-it to one instance of cephfs-journal-tool journal reset
see:
ceph/src/tools/cephfs/first-damage.py
Line 28 in 2389f00
2389f00 to
13a847d
Compare
Member
Author
Fixed |
Member
Author
|
@vshankar @chrisphoffman ping |
vshankar
requested changes
Mar 19, 2024
Contributor
vshankar
left a comment
There was a problem hiding this comment.
@joscollin This would require a rebase since more invocations of the journal tool were recently merged.
qa/tasks/cephfs/test_journal_migration.py: # Verify that cephfs-journal-tool can now read the rewritten journal
qa/tasks/vstart_runner.py: require_binaries = ["ceph-dencoder", "cephfs-journal-tool", "cephfs-data-scan",
qa/workunits/fs/damage/test-first-damage-lost-found.sh: cephfs-journal-tool --rank="$FS":0 event recover_dentries summary
qa/workunits/fs/damage/test-first-damage-lost-found.sh: cephfs-journal-tool --rank="$FS":0 journal reset
qa/workunits/fs/damage/test-first-damage-lost-found.sh: cephfs-journal-tool --rank="$FS":0 journal reset
qa/workunits/fs/damage/test-first-damage-lost-found.sh: cephfs-journal-tool --rank="$FS":0 event recover_dentries summary
qa/workunits/fs/damage/test-first-damage-lost-found.sh: cephfs-journal-tool --rank="$FS":0 journal reset
qa/workunits/fs/damage/test-first-damage.sh: cephfs-journal-tool --rank="$FS":0 event recover_dentries summary
qa/workunits/fs/damage/test-first-damage.sh: cephfs-journal-tool --rank="$FS":0 journal reset
qa/workunits/suites/cephfs_journal_tool_smoke.sh:export BIN="${BIN:-cephfs-journal-tool --rank=cephfs:0}"
vshankar
added a commit
to vshankar/ceph
that referenced
this pull request
Apr 30, 2024
* refs/pull/55758/head: doc: update 'journal reset' command with --yes-i-really-really-mean-it qa: fix cephfs-journal-tool commands cephfs-journal-tool: Fix the error code cephfs-journal-tool: stop execution if the fs is active cephfs-journal-tool: Add warning messages during 'journal reset' Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
vshankar
requested changes
May 3, 2024
Contributor
vshankar
left a comment
There was a problem hiding this comment.
@joscollin I think there are a few more instance in tests to fix. See: https://pulpito.ceph.com/vshankar-2024-05-01_17:34:00-fs-wip-vshankar-testing-20240430.111407-debug-testing-default-smithi/7683778/
2024-05-01T22:10:13.292 INFO:tasks.cephfs_test_runner:======================================================================
2024-05-01T22:10:13.292 INFO:tasks.cephfs_test_runner:ERROR: test_journal_migration (tasks.cephfs.test_journal_migration.TestJournalMigration)
2024-05-01T22:10:13.292 INFO:tasks.cephfs_test_runner:----------------------------------------------------------------------
2024-05-01T22:10:13.293 INFO:tasks.cephfs_test_runner:Traceback (most recent call last):
2024-05-01T22:10:13.293 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/git.ceph.com_ceph-c_5ef2baf9bfba0061cb137abe5d8fc74e1acd4bd8/qa/tasks/cephfs/test_journal_migration.py", line 70, in test_journal_migration
2024-05-01T22:10:13.293 INFO:tasks.cephfs_test_runner: inspect_out = self.fs.journal_tool(["journal", "inspect"], 0)
2024-05-01T22:10:13.293 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/git.ceph.com_ceph-c_5ef2baf9bfba0061cb137abe5d8fc74e1acd4bd8/qa/tasks/cephfs/filesystem.py", line 1715, in journal_tool
2024-05-01T22:10:13.293 INFO:tasks.cephfs_test_runner: return self._run_tool("cephfs-journal-tool", args, fs_rank, quiet)
2024-05-01T22:10:13.293 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/git.ceph.com_ceph-c_5ef2baf9bfba0061cb137abe5d8fc74e1acd4bd8/qa/tasks/cephfs/filesystem.py", line 1694, in _run_tool
2024-05-01T22:10:13.293 INFO:tasks.cephfs_test_runner: r = self.tool_remote.sh(script=base_args + args, stdout=StringIO()).strip()
2024-05-01T22:10:13.293 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/git.ceph.com_teuthology_1ae7ad82388e92a475afff437d49054826c019a1/teuthology/orchestra/remote.py", line 97, in sh
2024-05-01T22:10:13.293 INFO:tasks.cephfs_test_runner: proc = self.run(**kwargs)
2024-05-01T22:10:13.293 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/git.ceph.com_teuthology_1ae7ad82388e92a475afff437d49054826c019a1/teuthology/orchestra/remote.py", line 523, in run
2024-05-01T22:10:13.293 INFO:tasks.cephfs_test_runner: r = self._runner(client=self.ssh, name=self.shortname, **kwargs)
2024-05-01T22:10:13.293 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/git.ceph.com_teuthology_1ae7ad82388e92a475afff437d49054826c019a1/teuthology/orchestra/run.py", line 455, in run
2024-05-01T22:10:13.293 INFO:tasks.cephfs_test_runner: r.wait()
2024-05-01T22:10:13.293 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/git.ceph.com_teuthology_1ae7ad82388e92a475afff437d49054826c019a1/teuthology/orchestra/run.py", line 161, in wait
2024-05-01T22:10:13.293 INFO:tasks.cephfs_test_runner: self._raise_for_status()
2024-05-01T22:10:13.293 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/git.ceph.com_teuthology_1ae7ad82388e92a475afff437d49054826c019a1/teuthology/orchestra/run.py", line 181, in _raise_for_status
2024-05-01T22:10:13.294 INFO:tasks.cephfs_test_runner: raise CommandFailedError(
2024-05-01T22:10:13.294 INFO:tasks.cephfs_test_runner:teuthology.exceptions.CommandFailedError: Command failed on smithi016 with status 255: 'cephfs-journal-tool --debug-mds=20 --debug-ms=1 --debug-objecter=1 --rank cephfs:0 journal inspect'
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
Member
Author
@vshankar |
92b3251 to
5c74d4a
Compare
Member
Author
This is fixed and the changes are pushed. There's a similar failure with test_flush.py, which is WIP. |
Member
|
jenkins test make check arm64 |
5c74d4a to
cab86fd
Compare
Member
Author
|
@vshankar The qa failures are fixed. This PR is ready for another review and qa. |
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
…prevent execution on active fs Fixes: https://tracker.ceph.com/issues/62925 Signed-off-by: Jos Collin <jcollin@redhat.com>
Fixes: https://tracker.ceph.com/issues/62925 Signed-off-by: Jos Collin <jcollin@redhat.com>
Fixes: https://tracker.ceph.com/issues/62925 Signed-off-by: Jos Collin <jcollin@redhat.com>
cab86fd to
42953ec
Compare
Contributor
|
@joscollin Could you update here how the assert in the tests was fixed? |
Member
Author
The AssertionError [1] was not because of string mismatch. When we do |
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/66035. |
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/66063. |
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/66090. |
vshankar
approved these changes
May 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e