Skip to content

cmake/arrow: don't treat warnings as errors#55303

Merged
cbodley merged 1 commit intoceph:mainfrom
cbodley:wip-63130-debug
Jan 26, 2024
Merged

cmake/arrow: don't treat warnings as errors#55303
cbodley merged 1 commit intoceph:mainfrom
cbodley:wip-63130-debug

Conversation

@cbodley
Copy link
Contributor

@cbodley cbodley commented Jan 24, 2024

with arrow's default BUILD_WARNING_LEVEL, -Werror is added to cflags and debug builds fail on a warning about _FORTIFY_SOURCE

Fixes: https://tracker.ceph.com/issues/63130

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@cbodley
cmake/arrow: don't treat warnings as errors
5c1a57a 
with arrow's default BUILD_WARNING_LEVEL, -Werror is added to cflags and
debug builds fail on a warning about _FORTIFY_SOURCE

Fixes: https://tracker.ceph.com/issues/63130

Signed-off-by: Casey Bodley <cbodley@redhat.com>
@leonid-s-usov
Copy link
Contributor

leonid-s-usov commented Jan 24, 2024

Appreciate this, @cbodley !
I'll cherry-pick and try running the shaman build with the change, then report here

@cbodley
Copy link
Contributor Author

cbodley commented Jan 24, 2024

builds still pending in https://shaman.ceph.com/builds/ceph/wip-63130-debug/..

@leonid-s-usov
Copy link
Contributor

leonid-s-usov commented Jan 24, 2024

I don't understand, I also pushed my builds but they were ignored??

https://jenkins.ceph.com/job/ceph-dev-new-trigger/48990/:

[Started by an SCM change](https://jenkins.ceph.com/job/ceph-dev-new-trigger/48990/pollingLog)
[Started by GitHub push by yuvalif](https://jenkins.ceph.com/job/ceph-dev-new-trigger/48990/pollingLog) (4 times)
[Started by GitHub push by leonid-s-usov](https://jenkins.ceph.com/job/ceph-dev-new-trigger/48990/pollingLog) (2 times)
[Started by GitHub push by guits](https://jenkins.ceph.com/job/ceph-dev-new-trigger/48990/pollingLog) (2 times)

The polling log contains my test branch

...
Seen branch in repository origin/wip-lusov-qdb-qe-debug-centos8-only
...

but no build jobs in shaman or jenkins

image

@cbodley
Copy link
Contributor Author

cbodley commented Jan 24, 2024

jenkins test this please

@cbodley
Copy link
Contributor Author

cbodley commented Jan 24, 2024

all green in https://shaman.ceph.com/builds/ceph/wip-63130-debug/

@leonid-s-usov
Copy link
Contributor

leonid-s-usov commented Jan 24, 2024

Yes, this works
https://quay.ceph.io/repository/ceph-ci/ceph/manifest/sha256:e194eec9c82904be33835413f4fd0a68ef74d22c7f0834f26dd4bd02ded89373?tab=layers

@cbodley
Copy link
Contributor Author

cbodley commented Jan 25, 2024

The following tests FAILED:
33 - run-rbd-unit-tests-109.sh (Failed)

@cbodley
Copy link
Contributor Author

cbodley commented Jan 25, 2024

jenkins test make check

@leonid-s-usov
Copy link
Contributor

leonid-s-usov commented Jan 25, 2024 

=================================== FAILURES ===================================
_______________ TestSchedule.test_created_now[simple_schedule3] ________________

self = <snap_schedule.tests.fs.test_schedule.TestSchedule object at 0x7fb530c08c70>
simple_schedule = <snap_schedule.fs.schedule.Schedule object at 0x7fb52c52ac50>

    def test_created_now(self, simple_schedule):
        now = datetime.datetime.now(datetime.timezone.utc)
>       assert simple_schedule.created.minute == now.minute
E       assert 47 == 48
E        +  where 47 = datetime.datetime(2024, 1, 25, 3, 47, 59, 993684, tzinfo=datetime.timezone.utc).minute
E        +    where datetime.datetime(2024, 1, 25, 3, 47, 59, 993684, tzinfo=datetime.timezone.utc) = <snap_schedule.fs.schedule.Schedule object at 0x7fb52c52ac50>.created
E        +  and   48 = datetime.datetime(2024, 1, 25, 3, 48, 0, 18585, tzinfo=datetime.timezone.utc).minute

snap_schedule/tests/fs/test_schedule.py:65: AssertionError

this doesn't look related to the change

@leonid-s-usov
Copy link
Contributor

leonid-s-usov commented Jan 25, 2024

jenkins test make check

@cbodley
Copy link
Contributor Author

cbodley commented Jan 25, 2024

snap_schedule/tests/fs/test_schedule.py:65: AssertionError
The following tests FAILED:
4 - run-tox-mgr (Failed)

@cbodley
Copy link
Contributor Author

cbodley commented Jan 25, 2024

jenkins test make check

@cbodley
Copy link
Contributor Author

cbodley commented Jan 25, 2024

CMake Error at src/seastar/CMakeLists.txt:782 (message):
Sanitizers not found!

@cbodley
Copy link
Contributor Author

cbodley commented Jan 25, 2024

jenkins test make check

@cbodley
Copy link
Contributor Author

cbodley commented Jan 25, 2024

The following tests FAILED:
147 - check-generated.sh (Failed)
198 - unittest_osdmap (Subprocess aborted)

i fixed the check-generated.sh one in #55315

@cbodley
Copy link
Contributor Author

cbodley commented Jan 25, 2024

jenkins test make check

@cbodley
Copy link
Contributor Author

cbodley commented Jan 25, 2024

CMake Error at src/seastar/CMakeLists.txt:782 (message):
Sanitizers not found!

@cbodley
Copy link
Contributor Author

cbodley commented Jan 25, 2024

jenkins test make check

@cbodley cbodley merged commit 1112689 into ceph:main Jan 26, 2024
@cbodley cbodley deleted the wip-63130-debug branch January 26, 2024 14:18
@cbodley cbodley mentioned this pull request May 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@batrick batrick Awaiting requested review from batrick

1 more reviewer

@leonid-s-usov leonid-s-usov leonid-s-usov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build/ops

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cbodley @leonid-s-usov