Skip to content

mon: zero-initialize MonCommand::flags#55315

Merged
cbodley merged 1 commit intoceph:mainfrom
cbodley:wip-moncommand-dencoder
Jan 25, 2024
Merged

mon: zero-initialize MonCommand::flags#55315
cbodley merged 1 commit intoceph:mainfrom
cbodley:wip-moncommand-dencoder

Conversation

@cbodley
Copy link
Contributor

@cbodley cbodley commented Jan 25, 2024

causing failures in check-generated.sh:

2 MonCommand
/tmp/typ-qmnDZ1ahR /tmp/typ-lIgJTZiUe differ: byte 100, line 6 **** MonCommand test 1 dump_json check failed ****
   ceph-dencoder type MonCommand select_test 1 dump_json > /tmp/typ-qmnDZ1ahR
   ceph-dencoder type MonCommand select_test 1 encode decode dump_json > /tmp/typ-lIgJTZiUe
6c6
<     "flags": 94661933599904
---
>     "flags": 94342467308704
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

causing failures in check-generated.sh:

2 MonCommand
/tmp/typ-qmnDZ1ahR /tmp/typ-lIgJTZiUe differ: byte 100, line 6
**** MonCommand test 1 dump_json check failed ****
   ceph-dencoder type MonCommand select_test 1 dump_json > /tmp/typ-qmnDZ1ahR
   ceph-dencoder type MonCommand select_test 1 encode decode dump_json > /tmp/typ-lIgJTZiUe
6c6
<     "flags": 94661933599904
---
>     "flags": 94342467308704

Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley cbodley requested a review from a team as a code owner January 25, 2024 14:46
@cbodley
Copy link
Contributor Author

cbodley commented Jan 25, 2024

@NitzanMordhai looks related to #52871

@cbodley cbodley mentioned this pull request Jan 25, 2024
14 tasks
Copy link
Contributor

@tchaikov tchaikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@cbodley cbodley merged commit 93d1587 into ceph:main Jan 25, 2024
@cbodley cbodley deleted the wip-moncommand-dencoder branch January 25, 2024 17:20
@NitzanMordhai
Copy link
Contributor

@NitzanMordhai looks related to #52871

Yes, #52871 added that type, and now it is being tested, thanks for fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants