cephfs: allow FS rename only if refuse_client_session is set#54306
Closed
rishabh-d-dave wants to merge 4 commits intoceph:mainfrom
Closed
cephfs: allow FS rename only if refuse_client_session is set#54306rishabh-d-dave wants to merge 4 commits intoceph:mainfrom
rishabh-d-dave wants to merge 4 commits intoceph:mainfrom
Conversation
Signed-off-by: Rishabh Dave <ridave@redhat.com>
vshankar
reviewed
Nov 2, 2023
| """ | ||
| rename volume (orch MDS service, file system, pools) | ||
| """ | ||
| errno, errmsg = _perform_checks_before_renaming_vol(mgr, volname) |
Contributor
There was a problem hiding this comment.
Is there a need for this check here since the check (involving CEPH_MDSMAP_REFUSE_CLIENT_SESSION) is done in the monitor?
b762a3e to
ad6eb39
Compare
Reject the attempt to rename the CephFS is the CephFS is not offline. Add new tests for this and update current tests accordingly. Fixes: https://tracker.ceph.com/issues/63154 Signed-off-by: Rishabh Dave <ridave@redhat.com>
Move tests for "ceph fs volume rename" command to a new class. This makes it possible to run this group of tests in a single command. This provides a convenient way to execute these tests which is necessary after the changes has been made to the code for the "ceph fs volume rename" command. Signed-off-by: Rishabh Dave <ridave@redhat.com>
client_refuse_session must be set for a CephFS before an attempt to rename a CephFS can be made. Add a new test for this, and update current tests (test_admin.py and test_volumes.py) accordingly. Signed-off-by: Rishabh Dave <ridave@redhat.com>
ad6eb39 to
fab5dbe
Compare
Contributor
Author
|
Since a patch for mgr/vol has been deleted this PR, I am moving the commit of this PR (the final commit on the PR branch) to PR #53899 and closing this PR. |
Merged
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on PR #53899. It also includes commits from that PR so that it's easy to rebase this PR when that PR merges.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows