qa/distros: bump container host distros from centos 8->9#53901
qa/distros: bump container host distros from centos 8->9#53901
Conversation
adk3798
left a comment
There was a problem hiding this comment.
container_hosts also has an ubuntu 20.04 that I see you removed in your other PR. Do we want to remove that here as well?
c98109f to
7d90c18
Compare
|
@adk3798 i believe that our shaman builds for centos8 are the only ones that build container images. are you familiar with how that works? can you help me figure out what needs to happen to move that to the centos9 builds? edit: i don't think that will block progress on this pr, but we'll need to switch the base container image to centos9 before we can stop doing shaman builds for these old distros |
I'm pretty it's some script from https://github.com/ceph/ceph-build that is doing the centos 8 builds clones the ceph-container repo and runs https://github.com/ceph/ceph-container/blob/main/contrib/build-push-ceph-container-imgs.sh, but I'm not sure where in the ceph-build repo we'd have to update to get it to do that for the centos 9 builds. |
|
See http://wiki.front.sepia.ceph.com/doku.php?id=production:jenkins.ceph.com#how_jobs_are_run for a top-level description of the builds. The actual building is done with a script from ceph-container, which is why those jobs also clone that repo. There might also be some code in the ceph-build job .yml itself for limiting containers to centos8; I can't recall. I remember being sad that there needed to be more than one test. It won't be that hard to unravel. |
|
One of the jobs' container code: https://github.com/ceph/ceph-build/blob/main/ceph-dev-new-build/build/build_rpm#L84-L108 |
|
@yuriw could i please ask your help with qa on this one? i believe it just needs fs, rados, and orch suites |
|
@adk3798 have you guys put any more thought into building centos9 containers? |
|
fwiw, I've been experimenting with ceph-container lately for other purposes (trying to allow for building "staging" containers when preparing a Ceph release) and may have a better idea of how to go about adding CentOS9/making it the default |
|
Yuri ran several suites against main over the weekend in https://pulpito.ceph.com/?branch=wip-yuri5-testing-2023-11-10-0828. there were several failures, but the most consistent one was i tried removing this could i ask someone's help to work through these failures in the orch suite? i assume that will resolve the failures in other suites |
@adk3798 who would be a good person to help me follow up on this? |
I can take a look and do some testing around this PR. I've never seen that error it's printing about |
|
@vshankar i've replaced
the description shows that rhel 8 is sneaking back in via |
Thx @cbodley for catching this. That yaml can be replaced by an equivalent rhel9 (9.3) yaml. I'll have a change up for that. |
Update: PR #55233 should fix this automatically (its a change to fix another issue related to cephfs-shell packaging though). |
thanks @vshankar i added that pr to a suite-branch based on wip-yuri8-testing-2024-01-18-0823 and scheduled a --rerun at https://pulpito.ceph.com/cbodley-2024-01-22_19:46:51-fs-wip-yuri8-testing-2024-01-18-0823-distro-default-smithi/ |
|
@cbodley on a second run, the failures from #53901 (comment) are gone, which is good! I noticed two others that I hadn't noticed before, since these tests are already failing for different known reasons. Although, we should fix these new issues before the PR is merged:
On a centos 9 container, I ran the following command, which shows that nodejs 16 is not available for centos9 (only 18 or 20). Running I created this commit to address the issue, which I verified on a centos 9 container if you'd like to use it: c18b763
Otherwise, things are looking good! Current summary: https://tracker.ceph.com/projects/rados/wiki/MAIN#httpstrellocomcYjrx9ygD1911-wip-yuri8-testing-2024-01-18-0823-old-wip-yuri8-testing-2023-12-15-0911 |
Signed-off-by: Laura Flores <lflores@ibm.com>
I'll have a look at the run tomorrow when its done (its nearly done btw)... |
|
@cbodley was there a resolution for |
|
jenkins retest this please |
no, i haven't had a chance yet to figure out what's missing in rados |
|
@cbodley - There are a few more references to centos8 in fs suite. Need to also fix: qa/suites/fs/upgrade/featureful_client/old_client/centos_8.stream.yaml .. and also https://github.com/ceph/ceph/pull/55233/files#r1465005933 @batrick |
oops, i think my change there broke @adk3798's earlier fix for however, there's a @adk3798 how would you like to manage that set of container distros you run against? should that symlink point to a separate |
thanks @vshankar. it looks like all of those upgrade tests start on old releases (i see nautilus, octopus, and pacific) which don't have centos9 packages, so they'd have to start on centos8. but once we stop building centos8 packages for main/squid, we won't be able to install the upgraded packages there for squid we'll only support upgrades from quincy and reef, both of which can start on centos9. so if you're able to drop these old releases, you could replace the centos_8.stream.yaml links with centos_9.stream.yaml but if you need to keep testing these old clients, you'll probably need to use the |
The basis for testing older release is to catch any bugs before changes hit downstream.
ACK. That's something I haven't looked into yet. Thanks for that info! So, as far as this change is concerned, the only pending item from cephfs pov is to test with #55233. I'm on it. |
@adk3798 i pushed a commit for this, does it look ok? |
The setup of supported-container-hosts itself looks fine, but do we need to update all the things pointing to regular container-hosts to point there instead? For example, I know orch/cephadm itself has and a number of them (but not all I think) just symlink to container-hosts. Same goes for some of the 0-random-distro$ like the one in upgrade/quincy-x/parallel/ and some 0-distro that are outside of suites/orch/cephadm. If we don't update those as well, they could still pick centos 8 for their tests I think. |
Signed-off-by: Casey Bodley <cbodley@redhat.com>
9f7889d to
849a58b
Compare
|
thanks @adk3798, i amended that last commit to fix the remaining symlinks to qa/distros/container-hosts there was a single qa/suites/upgrade/telemetry-upgrade/pacific-x/0-random-distro$ that won't be able to use centos9, so i left it as-is. someone will need to remove upgrade/telemetry-upgrade/pacific-x (and add a reef-x?) for squid |
|
jenkins test docs |
why? we're going to stop building ceph packages for centos 8 and rhel for the squid release. these distros were removed from most suites in #53517. i didn't touch container host distros there, but testing showed that jobs relying on the container host distros also installed ceph packages. these jobs would fail once we stop building them
so we either need to stop using these old distros as the container host, or change the suites to stop installing ceph packages there. this pr takes the former (easier) approach
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows