Skip to content

qa/distros: remove centos/rhel8 and ubuntu20.04 from supported distros#53517

Merged
yuriw merged 9 commits intoceph:mainfrom
cbodley:wip-qa-distros-s
Oct 9, 2023
Merged

qa/distros: remove centos/rhel8 and ubuntu20.04 from supported distros#53517
yuriw merged 9 commits intoceph:mainfrom
cbodley:wip-qa-distros-s

Conversation

@cbodley
Copy link
Contributor

@cbodley cbodley commented Sep 18, 2023

the S release will drop support for these distros, so stop testing them on main. as discussed on dev@ceph.io

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley cbodley added the tests label Sep 18, 2023
@cbodley
Copy link
Contributor Author

cbodley commented Sep 18, 2023

note that RHEL 8 is still present in qa/distros/supported-random-distro$/rhel_latest.yaml. this should be removed too, but nobody has added RHEL 9 yet

Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley
Copy link
Contributor Author

cbodley commented Sep 20, 2023

removed rhel8 after clt discussion

@cbodley
Copy link
Contributor Author

cbodley commented Sep 20, 2023

i found that several suites still have symlinks to these old distro files:

qa/suites/fs/verify/distro/rhel_8.yaml
qa/suites/fs/mixed-clients/distro/rhel_8.yaml
qa/suites/fs/workload/0-rhel_8.yaml

i'll go through and change any that aren't upgrade tests to use the {distro}_latest.yaml instead

@cbodley cbodley requested a review from a team as a code owner September 20, 2023 16:04
@cbodley
Copy link
Contributor Author

cbodley commented Sep 20, 2023

several of the upgrade suites had broken symlinks to qa/distros/supported/*.yaml, so i replaced those with links under qa/distros/all/

@cbodley cbodley changed the title qa/distros: remove centos8 and ubuntu20.04 from supported distros qa/distros: remove centos/rhel8 and ubuntu20.04 from supported distros Sep 20, 2023
Copy link
Contributor

@idryomov idryomov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not clear why rbd label is present, but since I got here... ;)

  • What about things like qa/distros/single-container-host.yaml which specify:

    os_type: centos
    os_version: "8.stream"
    
  • qa/distros/supported-all-distro degenerated into just Ubuntu. Should CentOS be re-added there?

  • What is the difference between qa/distros/supported and qa/distros/supported-all-distro? If none, it would be nice to ditch one of them while at it.

@cbodley
Copy link
Contributor Author

cbodley commented Sep 20, 2023

  • What about things like qa/distros/single-container-host.yaml which specify:
    os_type: centos
    os_version: "8.stream"

my only objective here is to stop building/testing ceph packages for these old distros. i'll leave any decisions about container host distros to folks that maintain a cephadm suite

  • What is the difference between qa/distros/supported and qa/distros/supported-all-distro? If none, it would be nice to ditch one of them while at it.

thanks, i added a commit to replace qa/distros/supported-all-distro with qa/distros/supported

the subsuite had a supported-all-distro$/ subdirectory, but that only
contained centos_8.yaml. qa/tasks/rabbitmq.py is hardcoded to use 'yum'
and rpm packages, so replace supported-all-distro$ with a link to
centos_latest.yaml

Signed-off-by: Casey Bodley <cbodley@redhat.com>
remove links to rhel_8.yaml, and replace links to specific centos/ubuntu
versions with links to {distro}_latest.yaml

Signed-off-by: Casey Bodley <cbodley@redhat.com>
replace the broken links to qa/distros/supported/centos_8.stream.yaml
with links under qa/distros/all/

Signed-off-by: Casey Bodley <cbodley@redhat.com>
replace the broken links to qa/distros/supported/*.yaml with links under
qa/distros/all/

Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@ljflores
Copy link
Member

ljflores commented Oct 3, 2023

@ljflores
Copy link
Member

ljflores commented Oct 3, 2023

However, @cbodley I do see some centos 8 stream jobs that were scheduled in the run: https://pulpito.ceph.com/yuriw-2023-10-02_20:49:32-rados-wip-yuri5-testing-2023-10-02-1105-distro-default-smithi/

Can you confirm whether the results here worked as intended? If so, feel free to merge.

@ljflores
Copy link
Member

ljflores commented Oct 3, 2023

@yuriw don't merge this; let Casey respond to the above comment ^

@ljflores
Copy link
Member

ljflores commented Oct 4, 2023

@cbodley it scheduled centos 8 stream, as opposed to centos 8 which I see you removed. I think it did work as expected.

@cbodley
Copy link
Contributor Author

cbodley commented Oct 4, 2023

  • What about things like qa/distros/single-container-host.yaml which specify:
    os_type: centos
    os_version: "8.stream"

@ljflores it scheduled lots of rados/cephadm jobs using centos8 and rhel as the container host, but i chose not to touch container hosts as discussed above. i also see some rados/thrash-old-clients jobs that pulled in qa/distros/container-hosts/centos_8.stream_container_tools.yaml

but now that i look at those logs, i see that even the cephadm jobs are installing ceph packages. when we stop building packages for these old distros, those jobs will start to fail

@ljflores
Copy link
Member

ljflores commented Oct 4, 2023

@cbodley I see; so does that mean this PR needs further modifications?

@cbodley
Copy link
Contributor Author

cbodley commented Oct 5, 2023

@cbodley I see; so does that mean this PR needs further modifications?

@ljflores i'd rather follow up on container host stuff in a separate pr. i'm willing to switch centos 8->9 in those yaml files for testing, but would need someone else to debug and fix any issues that uncovers

@yuriw
Copy link
Contributor

yuriw commented Oct 9, 2023

@ljflores @cbodley can this be merged?

@cbodley
Copy link
Contributor Author

cbodley commented Oct 9, 2023

i've opened #53901 to hopefully address the issue with container hosts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants