Skip to content

quincy: client: readdir_r_cb: get rstat for dir only if using rbytes for size#53360

Closed
k0ste wants to merge 2 commits intoceph:quincyfrom
k0ste:wip-62005-quincy
Closed

quincy: client: readdir_r_cb: get rstat for dir only if using rbytes for size#53360
k0ste wants to merge 2 commits intoceph:quincyfrom
k0ste:wip-62005-quincy

Conversation

@k0ste
Copy link
Contributor

@k0ste k0ste commented Sep 10, 2023

backport tracker: https://tracker.ceph.com/issues/62005


backport of #46960
parent tracker: https://tracker.ceph.com/issues/61999

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

When `client_dirsize_rbytes` is off, there should be no need for getting
rstat on readdir operations.

This fixes performance when `client_dirsize_rbytes` is off after ceph#38222.

Fixes: https://tracker.ceph.com/issues/61999
Signed-off-by: Pinghao Wu <xdavidwuph@gmail.com>
(cherry picked from commit 69decab)
kclient also has this option, and is unchangeable unless remounted.
Let's keep parity with kclient.

Signed-off-by: Pinghao Wu <xdavidwuph@gmail.com>
(cherry picked from commit 05a48a4)
@github-actions github-actions bot added cephfs Ceph File System common labels Sep 10, 2023
@github-actions github-actions bot added this to the quincy milestone Sep 10, 2023
@lxbsz
Copy link
Member

lxbsz commented Aug 2, 2024

This PR is under test in https://tracker.ceph.com/issues/67315.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Nov 26, 2024
@github-actions
Copy link

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants