Skip to content

client: set CEPH_STAT_RSTAT mask for dir in readdir_r_cb#38222

Merged
batrick merged 1 commit intoceph:masterfrom
candychencan:readdir
Dec 17, 2020
Merged

client: set CEPH_STAT_RSTAT mask for dir in readdir_r_cb#38222
batrick merged 1 commit intoceph:masterfrom
candychencan:readdir

Conversation

@candychencan
Copy link
Contributor

@candychencan candychencan commented Nov 21, 2020

Fixes: https://tracker.ceph.com/issues/48318
Signed-off-by: chencan chen.can2@zte.com.cn

In the readdir operation, If the dirent is directory, the directory's size is "in -> rstat.rbytes", needs to set CEPH_STAT_RSTAT mask in getattr to get the latest value.

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@github-actions github-actions bot added the cephfs Ceph File System label Nov 21, 2020
@batrick batrick requested a review from jtlayton November 30, 2020 15:51
jtlayton
jtlayton suggested changes Nov 30, 2020
View reviewed changes
@jtlayton jtlayton self-requested a review December 3, 2020 12:16
@jtlayton jtlayton self-assigned this Dec 3, 2020
jtlayton
jtlayton suggested changes Dec 3, 2020
View reviewed changes
jtlayton
jtlayton suggested changes Dec 6, 2020
View reviewed changes
@batrick
Copy link
Member

batrick commented Dec 17, 2020

https://pulpito.ceph.com/?branch=wip-pdonnell-testing-20201214.211711

@batrick batrick merged commit 7830534 into ceph:master Dec 17, 2020
This was referenced Jan 18, 2021
Merged
Merged
@xdavidwu xdavidwu mentioned this pull request Jul 5, 2022
Merged
14 tasks
xdavidwu added a commit to xdavidwu/ceph that referenced this pull request Sep 4, 2022
@xdavidwu
client: readdir_r_cb: get rstat for dir only if using rbytes for size
10dff3e 
When `client_dirsize_rbytes` is off, there should be no need for getting
rstat on readdir operations.

This fixes performance when `client_dirsize_rbytes` is off after ceph#38222.

Signed-off-by: Pinghao Wu <xdavidwuph@gmail.com>
xdavidwu added a commit to xdavidwu/ceph that referenced this pull request Sep 4, 2022
@xdavidwu
client: readdir_r_cb: get rstat for dir only if using rbytes for size
a973f5d 
When `client_dirsize_rbytes` is off, there should be no need for getting
rstat on readdir operations.

This fixes performance when `client_dirsize_rbytes` is off after ceph#38222.

Signed-off-by: Pinghao Wu <xdavidwuph@gmail.com>
rishabh-d-dave pushed a commit to rishabh-d-dave/ceph that referenced this pull request Mar 10, 2023
@xdavidwu
client: readdir_r_cb: get rstat for dir only if using rbytes for size
0b0ae98 
When `client_dirsize_rbytes` is off, there should be no need for getting
rstat on readdir operations.

This fixes performance when `client_dirsize_rbytes` is off after ceph#38222.

Signed-off-by: Pinghao Wu <xdavidwuph@gmail.com>
rishabh-d-dave pushed a commit to rishabh-d-dave/ceph that referenced this pull request Jun 16, 2023
@xdavidwu
client: readdir_r_cb: get rstat for dir only if using rbytes for size
310a5dd 
When `client_dirsize_rbytes` is off, there should be no need for getting
rstat on readdir operations.

This fixes performance when `client_dirsize_rbytes` is off after ceph#38222.

Signed-off-by: Pinghao Wu <xdavidwuph@gmail.com>
xdavidwu added a commit to xdavidwu/ceph that referenced this pull request Jul 13, 2023
@xdavidwu
client: readdir_r_cb: get rstat for dir only if using rbytes for size
736cd31 
When `client_dirsize_rbytes` is off, there should be no need for getting
rstat on readdir operations.

This fixes performance when `client_dirsize_rbytes` is off after ceph#38222.

Fixes: https://tracker.ceph.com/issues/61999
Signed-off-by: Pinghao Wu <xdavidwuph@gmail.com>
rishabh-d-dave pushed a commit to xdavidwu/ceph that referenced this pull request Jul 13, 2023
@xdavidwu @rishabh-d-dave
client: readdir_r_cb: get rstat for dir only if using rbytes for size
69decab 
When `client_dirsize_rbytes` is off, there should be no need for getting
rstat on readdir operations.

This fixes performance when `client_dirsize_rbytes` is off after ceph#38222.

Fixes: https://tracker.ceph.com/issues/61999
Signed-off-by: Pinghao Wu <xdavidwuph@gmail.com>
joscollin pushed a commit to joscollin/ceph that referenced this pull request Jul 31, 2023
@xdavidwu @joscollin
client: readdir_r_cb: get rstat for dir only if using rbytes for size
76e4408 
When `client_dirsize_rbytes` is off, there should be no need for getting
rstat on readdir operations.

This fixes performance when `client_dirsize_rbytes` is off after ceph#38222.

Fixes: https://tracker.ceph.com/issues/61999
Signed-off-by: Pinghao Wu <xdavidwuph@gmail.com>
xdavidwu added a commit to xdavidwu/ceph that referenced this pull request Aug 13, 2023
@xdavidwu
client: readdir_r_cb: get rstat for dir only if using rbytes for size
5864d64 
When `client_dirsize_rbytes` is off, there should be no need for getting
rstat on readdir operations.

This fixes performance when `client_dirsize_rbytes` is off after ceph#38222.

Signed-off-by: Pinghao Wu <xdavidwuph@gmail.com>
xdavidwu added a commit to xdavidwu/ceph that referenced this pull request Aug 14, 2023
@xdavidwu
client: readdir_r_cb: get rstat for dir only if using rbytes for size
10d75d4 
When `client_dirsize_rbytes` is off, there should be no need for getting
rstat on readdir operations.

This fixes performance when `client_dirsize_rbytes` is off after ceph#38222.

Signed-off-by: Pinghao Wu <xdavidwuph@gmail.com>
k0ste pushed a commit to k0ste/ceph that referenced this pull request Sep 10, 2023
@xdavidwu @k0ste
client: readdir_r_cb: get rstat for dir only if using rbytes for size
ef37c16 
When `client_dirsize_rbytes` is off, there should be no need for getting
rstat on readdir operations.

This fixes performance when `client_dirsize_rbytes` is off after ceph#38222.

Fixes: https://tracker.ceph.com/issues/61999
Signed-off-by: Pinghao Wu <xdavidwuph@gmail.com>
(cherry picked from commit 69decab)
k0ste pushed a commit to k0ste/ceph that referenced this pull request Sep 10, 2023
@xdavidwu @k0ste
client: readdir_r_cb: get rstat for dir only if using rbytes for size
0f68f9d 
When `client_dirsize_rbytes` is off, there should be no need for getting
rstat on readdir operations.

This fixes performance when `client_dirsize_rbytes` is off after ceph#38222.

Fixes: https://tracker.ceph.com/issues/61999
Signed-off-by: Pinghao Wu <xdavidwuph@gmail.com>
(cherry picked from commit 69decab)
aaSharma14 pushed a commit to rhcs-dashboard/ceph that referenced this pull request Sep 25, 2023
@xdavidwu
client: readdir_r_cb: get rstat for dir only if using rbytes for size
313686d 
When `client_dirsize_rbytes` is off, there should be no need for getting
rstat on readdir operations.

This fixes performance when `client_dirsize_rbytes` is off after ceph#38222.

Fixes: https://tracker.ceph.com/issues/61999
Signed-off-by: Pinghao Wu <xdavidwuph@gmail.com>
aaSharma14 pushed a commit to rhcs-dashboard/ceph that referenced this pull request Oct 11, 2023
@xdavidwu
client: readdir_r_cb: get rstat for dir only if using rbytes for size
9fbbf5e 
When `client_dirsize_rbytes` is off, there should be no need for getting
rstat on readdir operations.

This fixes performance when `client_dirsize_rbytes` is off after ceph#38222.

Fixes: https://tracker.ceph.com/issues/61999
Signed-off-by: Pinghao Wu <xdavidwuph@gmail.com>
rishabh-d-dave pushed a commit to rishabh-d-dave/ceph that referenced this pull request Oct 25, 2023
@xdavidwu @rishabh-d-dave
client: readdir_r_cb: get rstat for dir only if using rbytes for size
d1d4cac 
When `client_dirsize_rbytes` is off, there should be no need for getting
rstat on readdir operations.

This fixes performance when `client_dirsize_rbytes` is off after ceph#38222.

Fixes: https://tracker.ceph.com/issues/61999
Signed-off-by: Pinghao Wu <xdavidwuph@gmail.com>
(cherry picked from commit 69decab)
aaSharma14 pushed a commit to rhcs-dashboard/ceph that referenced this pull request Nov 7, 2023
@xdavidwu
client: readdir_r_cb: get rstat for dir only if using rbytes for size
f7af7c5 
When `client_dirsize_rbytes` is off, there should be no need for getting
rstat on readdir operations.

This fixes performance when `client_dirsize_rbytes` is off after ceph#38222.

Fixes: https://tracker.ceph.com/issues/61999
Signed-off-by: Pinghao Wu <xdavidwuph@gmail.com>
k0ste pushed a commit to k0ste/ceph that referenced this pull request Nov 24, 2023
@xdavidwu @k0ste
client: readdir_r_cb: get rstat for dir only if using rbytes for size
fa59d38 
When `client_dirsize_rbytes` is off, there should be no need for getting
rstat on readdir operations.

This fixes performance when `client_dirsize_rbytes` is off after ceph#38222.

Fixes: https://tracker.ceph.com/issues/61999
Signed-off-by: Pinghao Wu <xdavidwuph@gmail.com>
(cherry picked from commit 69decab)
aaSharma14 pushed a commit to rhcs-dashboard/ceph that referenced this pull request Jan 2, 2024
@xdavidwu
client: readdir_r_cb: get rstat for dir only if using rbytes for size
1769df1 
When `client_dirsize_rbytes` is off, there should be no need for getting
rstat on readdir operations.

This fixes performance when `client_dirsize_rbytes` is off after ceph#38222.

Fixes: https://tracker.ceph.com/issues/61999
Signed-off-by: Pinghao Wu <xdavidwuph@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jtlayton jtlayton jtlayton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cephfs Ceph File System needs-qa wip-pdonnell-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@candychencan @batrick @jtlayton