quincy: cephfs-journal-tool: disambiguate usage of all keyword (in tool help).#53285
Merged
yuriw merged 1 commit intoceph:quincyfrom Oct 9, 2023
Merged
quincy: cephfs-journal-tool: disambiguate usage of all keyword (in tool help).#53285yuriw merged 1 commit intoceph:quincyfrom
yuriw merged 1 commit intoceph:quincyfrom
Conversation
The fs:all for rank option description was confusing. It seemd like the fs was optional, but it is mandatory. This change modifies the help message to reflect the correct way to use all in the --rank option. Fixes: https://tracker.ceph.com/issues/61753 Signed-off-by: Manish M Yathnalli <myathnal@redhat.com> (cherry picked from commit 52c033f)
vshankar
added a commit
to vshankar/ceph
that referenced
this pull request
Oct 9, 2023
* refs/pull/53285/head: cephfs-journal-tool: disambiguate usage of all keyword (in tool help).
vshankar
added a commit
to vshankar/ceph
that referenced
this pull request
Oct 9, 2023
* refs/pull/53285/head: cephfs-journal-tool: disambiguate usage of all keyword (in tool help).
vshankar
commented
Oct 9, 2023
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
Reviewed-by: Venky Shankar vshankar@redhat.com |
This was referenced Oct 9, 2023
yuriw
approved these changes
Oct 9, 2023
Contributor
yuriw
left a comment
There was a problem hiding this comment.
Reviewed-by: Venky Shankar vshankar@redhat.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
like the fs was optional, but it is mandatory. This change modifies the help message to reflect the correct way to use all in the --rank option.
Fixes: https://tracker.ceph.com/issues/61753
Signed-off-by: Manish M Yathnalli myathnal@redhat.com
(cherry picked from commit 52c033f)
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows