qa: align quota.max_bytes to 4MB or 4KB in test_volumes.py#53160
Closed
qa: align quota.max_bytes to 4MB or 4KB in test_volumes.py#53160
Conversation
The quota.max_bytes must be aligned to 4MB if greater than or equal to 4MB, otherwise must align to 4KB. Signed-off-by: Xiubo Li <xiubli@redhat.com>
14 tasks
dparmar18
reviewed
Aug 31, 2023
|
|
||
| # create 4 files of 1MB | ||
| self._do_subvolume_io(subvolname, subvolume_group=group, number_of_files=4) | ||
| # create 7 files of 1MB |
Contributor
There was a problem hiding this comment.
any reason to bump up number of files from 4 to 7?
Member
Author
There was a problem hiding this comment.
Yeah, because the osize value changed from 4MB --> 8MB.
dparmar18
reviewed
Aug 31, 2023
Comment on lines
+1523
to
+1524
| # create one file of 8MB | ||
| file_size=self.DEFAULT_FILE_SIZE*8 |
Contributor
There was a problem hiding this comment.
This is going to be 8MB and not 8MiB, I hope this is not going to cause problems at IS_ALIGNED(x, a) (((x) & (int64_t(a) - 1)) == 0)
Contributor
There was a problem hiding this comment.
here the a is going to be 1 << 22 or 1 << 12
dparmar18
reviewed
Aug 31, 2023
|
|
||
| # try creating w/ same subvolume name with size -- should set quota | ||
| self._fs_cmd("subvolumegroup", "create", self.volname, group, "1000000000") | ||
| self._fs_cmd("subvolumegroup", "create", self.volname, group, "1073741824") // 1GB |
Member
Author
|
Will fix this together with #50910. |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The quota.max_bytes must be aligned to 4MB if greater than or equal to 4MB, otherwise must align to 4KB.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows