Skip to content

mds,client,qa: misc fixes for quota and quota.max_bytes#50910

Closed
lxbsz wants to merge 16 commits intoceph:mainfrom
lxbsz:fix_sizequota
Closed

mds,client,qa: misc fixes for quota and quota.max_bytes#50910
lxbsz wants to merge 16 commits intoceph:mainfrom
lxbsz:fix_sizequota

Conversation

@lxbsz
Copy link
Member

@lxbsz lxbsz commented Apr 6, 2023 •
edited
Loading

The size quota must be aligned to 4MiB or 4KiB.

Fixes: https://tracker.ceph.com/issues/59344
Fixes: https://tracker.ceph.com/issues/59346
Fixes: https://tracker.ceph.com/issues/59348

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@lxbsz lxbsz added the needs-qa label Apr 6, 2023
@lxbsz lxbsz requested a review from a team April 6, 2023 05:06
@lxbsz lxbsz marked this pull request as draft April 6, 2023 05:06
@github-actions github-actions bot added the tests label Apr 6, 2023
vshankar
vshankar reviewed Apr 6, 2023
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we not see the failures when running integration tests @rishabh-d-dave ?

@vshankar
Copy link
Contributor

vshankar commented Apr 6, 2023

BTW - this failure was seen in https://tracker.ceph.com/projects/cephfs/wiki/Main#31-Mar-2023

http://pulpito.front.sepia.ceph.com/rishabh-2023-03-11_05:54:03-fs-wip-rishabh-2023Mar10-1727-testing-default-smithi/7204053

@github-actions github-actions bot added cephfs Ceph File System documentation labels Apr 6, 2023
@lxbsz lxbsz marked this pull request as ready for review April 6, 2023 15:45
@lxbsz lxbsz requested a review from a team as a code owner April 6, 2023 15:45
@lxbsz lxbsz requested a review from dparmar18 April 6, 2023 15:46
@lxbsz
Copy link
Member Author

lxbsz commented Apr 6, 2023

BTW - this failure was seen in https://tracker.ceph.com/projects/cephfs/wiki/Main#31-Mar-2023

http://pulpito.front.sepia.ceph.com/rishabh-2023-03-11_05:54:03-fs-wip-rishabh-2023Mar10-1727-testing-default-smithi/7204053

Yeah, correct.

dparmar18
dparmar18 reviewed Apr 6, 2023
View reviewed changes
dparmar18
dparmar18 reviewed Apr 6, 2023
View reviewed changes
dparmar18
dparmar18 reviewed Apr 10, 2023
View reviewed changes
dparmar18
dparmar18 reviewed Apr 10, 2023
View reviewed changes
dparmar18
dparmar18 reviewed Apr 10, 2023
View reviewed changes
dparmar18
dparmar18 reviewed Apr 10, 2023
View reviewed changes
dparmar18
dparmar18 reviewed Apr 10, 2023
View reviewed changes
dparmar18
dparmar18 approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@dparmar18 dparmar18 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestion above, else LGTM

EDIT: all resolved.

@lxbsz
Copy link
Member Author

lxbsz commented Apr 11, 2023

jenkins retest this please

@lxbsz lxbsz changed the title qa: fix invalidate ceph.quota.max_bytes values mds,client,qa: misc fixes for quota and quota.max_bytes Apr 12, 2023
@lxbsz
Copy link
Member Author

lxbsz commented Apr 12, 2023

@dparmar18 Just added 3 new commits to fix https://tracker.ceph.com/issues/59346. The previous ones didn't change.

@dparmar18 dparmar18 self-requested a review April 12, 2023 05:53
@lxbsz
client: flush the Fw dirty cap immediately if file size increased
7719a23 
If any of the parent directory enables the size quota, we should
flush the dirty caps as soon as possible to make sure the quota to
be enforced.

Fixes: https://tracker.ceph.com/issues/59346
Signed-off-by: Xiubo Li <xiubli@redhat.com>
@lxbsz
qa: align quota.max_bytes to 4MB or 4KB in test_volumes.py
289a440 
The quota.max_bytes must be aligned to 4MB if greater than or equal
to 4MB, otherwise must align to 4KB.

Signed-off-by: Xiubo Li <xiubli@redhat.com>
@lxbsz
Copy link
Member Author

lxbsz commented Sep 26, 2024

Any plans to revive this? Is it possible to coordinate the reviewing and the rebasing so that it could be merged ?

@lxbsz Is it possible to rebase and push an update? @rishabh-d-dave can then pick this up for running it through fs suite.

Sorry for late update. Done!

@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Sep 26, 2024

jenkins test api

@rptaylor
Copy link

rptaylor commented Oct 22, 2024

@rishabh-d-dave Are there any changes needed as a result of the testing? Thanks!

@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Oct 24, 2024

@rishabh-d-dave Are there any changes needed as a result of the testing? Thanks!

Can't tell. The last QA run was long and there have been push after it. So this needs to be tested again. Also, CI jobs failed. No idea if they failed to related or unrelated reasons since logs have been deleted for them.

I'll keep a check and move this PR towards a merge.

@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Oct 24, 2024

jenkins test api

@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Oct 24, 2024

jenkins test make check

@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Oct 24, 2024

jenkins test make check arm64

@github-actions
Copy link

github-actions bot commented Oct 24, 2024

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@github-actions
Copy link

github-actions bot commented Dec 23, 2024

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Dec 23, 2024
@dparmar18 dparmar18 removed the stale label Dec 26, 2024
@dparmar18
Copy link
Contributor

dparmar18 commented Dec 31, 2024

@vshankar @rishabh-d-dave can this be QAed again? This is low hanging fruit sort of PR, should run fine.

@github-actions
Copy link

github-actions bot commented Mar 1, 2025

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Mar 1, 2025
@github-actions
Copy link

github-actions bot commented Mar 31, 2025

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this Mar 31, 2025
@github-actions
Copy link

github-actions bot commented Jun 14, 2025

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Jun 14, 2025
@dparmar18 dparmar18 removed the stale label Jun 16, 2025
@github-actions
Copy link

github-actions bot commented Aug 15, 2025

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Aug 15, 2025
@github-actions
Copy link

github-actions bot commented Sep 14, 2025

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this Sep 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar left review comments

@gregsfortytwo gregsfortytwo gregsfortytwo requested changes

@dparmar18 dparmar18 dparmar18 approved these changes

@rishabh-d-dave rishabh-d-dave rishabh-d-dave requested changes

Assignees

@rishabh-d-dave rishabh-d-dave

Labels

build/ops cephfs Ceph File System documentation needs-rebase stale tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lxbsz @vshankar @rptaylor @rishabh-d-dave @dparmar18 @gregsfortytwo