mgr/snap_schedule: add support for monthly snapshots by mchangir · Pull Request #53070 · ceph/ceph

mchangir · 2023-08-21T16:12:16Z

swap 'M' and 'm' specifiers to mean 'm' for minutes and 'M' for months
add period mutlipliers for months and years
add test case to test: minute, hourly, daily, weekly, monthly, yearly and bad period specifiers

Fixes: https://tracker.ceph.com/issues/62494
Signed-off-by: Milind Changire mchangir@redhat.com

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows

mchangir · 2023-08-22T06:04:00Z

Teuthology jobs: 1 failed out of 6 due to POOL_APP_NOT_ENABLED

mchangir · 2023-08-22T06:05:02Z

jenkins test make check

dparmar18 · 2023-08-22T10:31:32Z

Since m and M are different now, we should document this somewhere like a note stating the difference.

qa/tasks/cephfs/test_snap_schedules.py

src/pybind/mgr/snap_schedule/fs/schedule.py

qa/tasks/cephfs/test_snap_schedules.py

mchangir · 2023-08-23T06:07:15Z

jenkins test make check arm64

dparmar18 · 2023-08-23T10:59:13Z

changes lgtm, just a minor nit to add tracker to rest seven commits would be good. Also since the second last commit(where the test cases are added) makes use of minor change made in other qa commits; i think they can be clubbed together?

dparmar18 · 2023-08-23T11:08:08Z

more negative tests like snap_schedule='1', snap_schedule='M', snap_schedule='-1m', snap_schedule='' can also be added

mchangir · 2023-08-23T12:14:39Z

more negative tests like snap_schedule='1', snap_schedule='M', snap_schedule='-1m', snap_schedule='' can also be added

added these negative tests
a ValueError exception will be thrown for bad values

mchangir · 2023-08-24T02:22:35Z

added tracker to all commits
Teuthology Jobs with 2 failed jobs out of 6 with POOL_APP_NOT_ENABLED

vshankar · 2023-08-24T04:25:21Z

added tracker to all commits

Teuthology Jobs with 2 failed jobs out of 6 with POOL_APP_NOT_ENABLED

rebase+rerun with updated qa change, no need to rebuild.

vshankar · 2023-08-24T04:29:57Z

@mchangir Let's squash the mgr/snap_schedule changes in one commit and the qa changes squashed into another commit. Also add a note in PendingReleaseNotes.

dparmar18 · 2023-08-24T06:38:27Z

last commit needs tracker link, else the changes LGTM

mchangir · 2023-08-24T15:47:25Z

Teuthology Jobs: 1 dead and 5 pass out of 6

mchangir · 2023-08-25T07:26:41Z

last commit needs tracker link, else the changes LGTM

PendingReleaseNotes doesn't require a tracker.

mchangir · 2023-08-25T07:27:05Z

jenkins test make check arm64

mchangir · 2023-08-29T14:59:20Z

rebase; with a small typo correction in PendingReleaseNotes for the subsystem name of an earlier PR

vshankar · 2023-09-07T10:34:28Z

jenkins test make check

Problem: As per the issue tracker, the period spec specifier 'M' is not consistent with what is used elsewhere, like the period specifiers displayed in the 'ceph status' command output. The 'M' period specifier is used as a 'minute' level period specifier by the cephfs team. The issue reporter suggests to use 'M' as a 'month' period specifier. Solution: Since the 'minute' level period specifer, 'M', is used internally by the development team, it is failrly easy to swap the 'minute' ('M') level and 'month' ('m') level period specifers to finally mean that 'm' implies 'minute' level period and 'M' implies 'month' level period. Also, since this is the first time that somebody has ever reported that neither the 'M' nor the 'm' level specifiers work in production, it is a good idea to fix them once and for all. Fixes: https://tracker.ceph.com/issues/62494 Signed-off-by: Milind Changire <mchangir@redhat.com>

Fixes: https://tracker.ceph.com/issues/62494 Signed-off-by: Milind Changire <mchangir@redhat.com>

mchangir · 2023-09-12T08:36:16Z

updated YAML to use 'm' as minute period multiplier

Signed-off-by: Milind Changire <mchangir@redhat.com>

Fixes: https://tracker.ceph.com/issues/62494 Signed-off-by: Milind Changire <mchangir@redhat.com>

Signed-off-by: Milind Changire <mchangir@redhat.com>

vshankar · 2023-09-13T13:01:24Z

https://pulpito.ceph.com/vshankar-2023-09-13_10:54:59-fs-wip-vshankar-testing-20230913.074344-testing-default-smithi/

vshankar

https://pulpito.ceph.com/vshankar-2023-09-14_07:38:15-fs-wip-vshankar-testing-20230913.074344-testing-default-smithi/

Introduced-by: ceph#53070 Fixes: https://tracker.ceph.com/issues/65350 Signed-off-by: Milind Changire <mchangir@redhat.com>

Introduced-by: ceph/ceph#53070 Fixes: https://tracker.ceph.com/issues/65350 Signed-off-by: Milind Changire <mchangir@redhat.com>

Introduced-by: ceph#53070 Fixes: https://tracker.ceph.com/issues/65350 Signed-off-by: Milind Changire <mchangir@redhat.com> (cherry picked from commit 7151415)

Introduced-by: ceph/ceph#53070 Fixes: https://tracker.ceph.com/issues/65350 Signed-off-by: Milind Changire <mchangir@redhat.com> (cherry picked from commit 7151415)

Resolves: rhbz#2280638 Introduced-by: ceph#53070 Fixes: https://tracker.ceph.com/issues/65350 Signed-off-by: Milind Changire <mchangir@redhat.com> (cherry picked from commit 7151415) (cherry picked from commit c45450f)

github-actions bot added cephfs Ceph File System pybind tests labels Aug 21, 2023

mchangir force-pushed the mgr-snap_schedule-add-support-for-monthly-snapshots branch from 589d2b1 to 788cc80 Compare August 22, 2023 03:50

vshankar requested a review from a team August 22, 2023 09:30

dparmar18 reviewed Aug 22, 2023

View reviewed changes

qa/tasks/cephfs/test_snap_schedules.py Show resolved Hide resolved

mchangir requested a review from a team as a code owner August 22, 2023 11:09

github-actions bot added the documentation label Aug 22, 2023

dparmar18 reviewed Aug 22, 2023

View reviewed changes

qa/tasks/cephfs/test_snap_schedules.py Show resolved Hide resolved

vshankar reviewed Aug 22, 2023

View reviewed changes

src/pybind/mgr/snap_schedule/fs/schedule.py Show resolved Hide resolved

qa/tasks/cephfs/test_snap_schedules.py Show resolved Hide resolved

mchangir changed the title ~~mgr/snap schedule: add support for monthly snapshots~~ mgr/snap_schedule: add support for monthly snapshots Aug 22, 2023

mchangir force-pushed the mgr-snap_schedule-add-support-for-monthly-snapshots branch 2 times, most recently from a78537d to c92bcab Compare August 23, 2023 05:58

mchangir force-pushed the mgr-snap_schedule-add-support-for-monthly-snapshots branch from c92bcab to 941c6b0 Compare August 23, 2023 12:04

mchangir force-pushed the mgr-snap_schedule-add-support-for-monthly-snapshots branch from 941c6b0 to 9867fb6 Compare August 24, 2023 02:20

mchangir force-pushed the mgr-snap_schedule-add-support-for-monthly-snapshots branch from 9867fb6 to e5ee740 Compare August 24, 2023 05:32

mchangir force-pushed the mgr-snap_schedule-add-support-for-monthly-snapshots branch from f3ad862 to a749f3b Compare August 29, 2023 14:57

vshankar added the wip-vshankar-testing1 label Sep 7, 2023

mchangir added 2 commits September 12, 2023 13:58

qa: change minute duration specifier from M to m

e7218e0

Fixes: https://tracker.ceph.com/issues/62494 Signed-off-by: Milind Changire <mchangir@redhat.com>

mchangir force-pushed the mgr-snap_schedule-add-support-for-monthly-snapshots branch from a749f3b to fcba9cc Compare September 12, 2023 08:32

mchangir added 3 commits September 12, 2023 14:11

qa: update minute period multiplier to m

9c88234

Signed-off-by: Milind Changire <mchangir@redhat.com>

doc/cephfs: add note about monthly scheduling and retention period

7431b81

Fixes: https://tracker.ceph.com/issues/62494 Signed-off-by: Milind Changire <mchangir@redhat.com>

PendingReleaseNotes: add note about 'm' and 'M' periods

7e2546f

Signed-off-by: Milind Changire <mchangir@redhat.com>

mchangir force-pushed the mgr-snap_schedule-add-support-for-monthly-snapshots branch from fcba9cc to 7e2546f Compare September 12, 2023 08:41

neesingh-rh approved these changes Sep 12, 2023

View reviewed changes

vshankar approved these changes Sep 14, 2023

View reviewed changes

vshankar merged commit 98758ee into ceph:main Sep 14, 2023

vshankar removed the wip-vshankar-testing1 label Sep 14, 2023

mchangir mentioned this pull request Dec 14, 2023

quincy: mgr/snap_schedule: add support for monthly snapshots #54894

Merged

This was referenced Jan 17, 2024

reef: mgr/snap_schedule: add support for monthly snapshots #55208

Merged

pacific: mgr/snap_schedule: add support for monthly snapshots #55209

Closed

mchangir added a commit to mchangir/ceph that referenced this pull request Apr 5, 2024

mgr/snap_schedule: restore yearly spec to lowercase y

2685bc0

Introduced-by: ceph#53070 Fixes: https://tracker.ceph.com/issues/65350 Signed-off-by: Milind Changire <mchangir@redhat.com>

mchangir added a commit to mchangir/ceph that referenced this pull request Apr 16, 2024

mgr/snap_schedule: restore yearly spec to lowercase y

e3fce09

Introduced-by: ceph#53070 Fixes: https://tracker.ceph.com/issues/65350 Signed-off-by: Milind Changire <mchangir@redhat.com>

mchangir added a commit to mchangir/ceph that referenced this pull request Apr 17, 2024

mgr/snap_schedule: restore yearly spec to lowercase y

7151415

Introduced-by: ceph#53070 Fixes: https://tracker.ceph.com/issues/65350 Signed-off-by: Milind Changire <mchangir@redhat.com>

rishabh-d-dave pushed a commit to ceph/ceph-ci that referenced this pull request Apr 30, 2024

mgr/snap_schedule: restore yearly spec to lowercase y

7b5e83f

Introduced-by: ceph/ceph#53070 Fixes: https://tracker.ceph.com/issues/65350 Signed-off-by: Milind Changire <mchangir@redhat.com>

rishabh-d-dave pushed a commit to ceph/ceph-ci that referenced this pull request May 1, 2024

mgr/snap_schedule: restore yearly spec to lowercase y

21ca4c6

Introduced-by: ceph/ceph#53070 Fixes: https://tracker.ceph.com/issues/65350 Signed-off-by: Milind Changire <mchangir@redhat.com>

Conversation

mchangir commented Aug 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution Guidelines

Checklist

Uh oh!

mchangir commented Aug 22, 2023

Uh oh!

mchangir commented Aug 22, 2023

Uh oh!

dparmar18 commented Aug 22, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mchangir commented Aug 23, 2023

Uh oh!

dparmar18 commented Aug 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dparmar18 commented Aug 23, 2023

Uh oh!

mchangir commented Aug 23, 2023

Uh oh!

mchangir commented Aug 24, 2023

Uh oh!

vshankar commented Aug 24, 2023

Uh oh!

vshankar commented Aug 24, 2023

Uh oh!

dparmar18 commented Aug 24, 2023

Uh oh!

mchangir commented Aug 24, 2023

Uh oh!

mchangir commented Aug 25, 2023

Uh oh!

mchangir commented Aug 25, 2023

Uh oh!

mchangir commented Aug 29, 2023

Uh oh!

vshankar commented Sep 7, 2023

Uh oh!

mchangir commented Sep 12, 2023

Uh oh!

vshankar commented Sep 13, 2023

Uh oh!

vshankar left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mchangir commented Aug 21, 2023 •

edited

Loading

dparmar18 commented Aug 23, 2023 •

edited

Loading