qa: inherit RunCephCmd in CephTestCase instead of CephFSTestCase by rishabh-d-dave · Pull Request #52924 · ceph/ceph

rishabh-d-dave · 2023-08-10T12:39:28Z

MgrTestCase also needs RunCephCmd. If RunCephCmd is inherited by
CephTestCase, instead of CephFSTestCase, MgrTestCase will automatically
inherit RunCephCmd because it inhertis CephTestCase.

Fixes: https://tracker.ceph.com/issues/62084

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows

adk3798

LGTM code wise. Let's see how it goes in testing

rishabh-d-dave · 2023-08-11T08:09:14Z

tox failure is related to this PR -

flake8: commands[0] /home/jenkins-build/build/workspace/ceph-pull-requests/qa> flake8 --select=F,E9 --exclude=venv,.tox
./tasks/cephfs/cephfs_test_case.py:5:1: F401 'io.StringIO' imported but unused

Fixing the issue...

qa/tasks/ceph_test_case.py

vshankar · 2023-08-23T14:43:36Z

Am I right in understanding that PR #52556 is also trying to fix the same issue? If that's the case, can we have a single PR?

@adk3798 @rishabh-d-dave

rishabh-d-dave · 2023-08-23T15:53:04Z

@vshankar

Am I right in understanding that PR #52556 is also trying to fix the same issue? If that's the case, can we have a single PR?

Yes, Adam King and I are aware of each other's PRs. In fact I created this PR after talking to him. This PR is better fix and if this works, we'll merge this and close the other one. Otherwise, vice versa.

MgrTestCase also needs RunCephCmd. If RunCephCmd is inherited by CephTestCase, instead of CephFSTestCase, MgrTestCase will automatically inherit RunCephCmd because it inhertis CephTestCase. Fixes: https://tracker.ceph.com/issues/62084 Signed-off-by: Rishabh Dave <ridave@redhat.com>

rishabh-d-dave · 2023-08-24T18:19:30Z

http://pulpito.front.sepia.ceph.com/rishabh-2023-08-24_18:19:09-orch-wip-rishabh-2023Aug1-b4-testing-default-smithi/

rishabh-d-dave · 2023-08-24T19:23:27Z

http://pulpito.front.sepia.ceph.com/rishabh-2023-08-24_18:19:09-orch-wip-rishabh-2023Aug1-b4-testing-default-smithi/

@adk3798 This job passed which means this patch works now!

nly_export'
2023-08-24T19:06:31.626 INFO:tasks.cephfs_test_runner:test_write_to_read_only_export (tasks.cephfs.test_nfs.TestNFS) ... ok
2023-08-24T19:06:31.627 INFO:tasks.cephfs_test_runner:
2023-08-24T19:06:31.627 INFO:tasks.cephfs_test_runner:----------------------------------------------------------------------
2023-08-24T19:06:31.627 INFO:tasks.cephfs_test_runner:Ran 24 tests in 1039.493s
2023-08-24T19:06:31.627 INFO:tasks.cephfs_test_runner:
2023-08-24T19:06:31.628 INFO:tasks.cephfs_test_runner:OK

vshankar · 2023-08-25T02:28:50Z

jenkins test api

qa/tasks/cephfs/cephfs_test_case.py

vshankar · 2023-08-25T12:23:09Z

@rishabh-d-dave please share the fs suite run.

rishabh-d-dave · 2023-08-25T20:11:33Z

@adk3798 test_nfs.py is running successfully with this patch. I've ran a CephFS integration tests, these too ran fine. A couple of failed jobs from this run needs to be investigate but there are not related to this PR.

https://pulpito.ceph.com/rishabh-2023-08-25_06:38:25-fs-wip-rishabh-2023aug3-b5-testing-default-smithi/

@vshankar If it looks good, can you please approve this PR?

vshankar · 2023-08-28T04:03:16Z

@adk3798 test_nfs.py is running successfully with this patch. I've ran a CephFS integration tests, these too ran fine. A couple of failed jobs from this run needs to be investigate but there are not related to this PR.

https://pulpito.ceph.com/rishabh-2023-08-25_06:38:25-fs-wip-rishabh-2023aug3-b5-testing-default-smithi/

@vshankar If it looks good, can you please approve this PR?

LGTM. @adk3798 I see you approved a previous revision of this change. Could you take a look at the latest update?

adk3798 · 2023-08-28T13:15:55Z

@adk3798 test_nfs.py is running successfully with this patch. I've ran a CephFS integration tests, these too ran fine. A couple of failed jobs from this run needs to be investigate but there are not related to this PR.
https://pulpito.ceph.com/rishabh-2023-08-25_06:38:25-fs-wip-rishabh-2023aug3-b5-testing-default-smithi/
@vshankar If it looks good, can you please approve this PR?

LGTM. @adk3798 I see you approved a previous revision of this change. Could you take a look at the latest update?

Code still LGTM. I'd like to include this in an orch run as well to verify it fixed our failing test, but if it passes there I'd be happy with merging it

vshankar · 2023-08-29T06:29:55Z

@adk3798 test_nfs.py is running successfully with this patch. I've ran a CephFS integration tests, these too ran fine. A couple of failed jobs from this run needs to be investigate but there are not related to this PR.
https://pulpito.ceph.com/rishabh-2023-08-25_06:38:25-fs-wip-rishabh-2023aug3-b5-testing-default-smithi/
@vshankar If it looks good, can you please approve this PR?

LGTM. @adk3798 I see you approved a previous revision of this change. Could you take a look at the latest update?

Code still LGTM. I'd like to include this in an orch run as well to verify it fixed our failing test, but if it passes there I'd be happy with merging it

Thanks @adk3798 - please do the needful and update when ready. @rishabh-d-dave has run this through fs suite and looks fine.

tasks.cephfs_test_runner:AttributeError: 'TestNFS' object has no attribute 'run_ceph_cmd' ceph#52924 fixes this, reverted back to previous code just for testing out this PR. This commit will be removed. Signed-off-by: Dhairya Parmar <dparmar@redhat.com> (cherry picked from commit 40ffb4d)

rishabh-d-dave · 2023-09-04T13:44:13Z

Removing my label since CephFS tests have already been run.

vshankar · 2023-09-05T07:23:59Z

@rishabh-d-dave Since this has already run through nfs suite, please merge this.

rishabh-d-dave · 2023-09-05T12:40:20Z

http://pulpito.front.sepia.ceph.com/rishabh-2023-09-05_12:16:09-orch:cephadm-wip-rishabh-2023aug3-b5-testing-default-smithi/

vshankar · 2023-09-05T13:00:59Z

http://pulpito.front.sepia.ceph.com/rishabh-2023-09-05_12:16:09-orch:cephadm-wip-rishabh-2023aug3-b5-testing-default-smithi/

Doh. A bunch of failures like

Command failed on smithi029 with status 1: "grep '^nvme_loop' /proc/modules || sudo modprobe nvme_loop && sudo mkdir -p /sys/kernel/config/nvmet/hosts/hostnqn && sudo mkdir -p /sys/kernel/config/nvmet/ports/1 && echo loop | sudo tee /sys/kernel/config/nvmet/ports/1/addr_trtype"

@adk3798 These are the same failures that I see with my PR #52708

rishabh-d-dave · 2023-09-05T14:12:41Z

http://pulpito.front.sepia.ceph.com/rishabh-2023-09-05_12:16:09-orch:cephadm-wip-rishabh-2023aug3-b5-testing-default-smithi/

Failure aren't relevant and test_nfs.py passed.

adk3798 · 2023-09-05T14:23:19Z

http://pulpito.front.sepia.ceph.com/rishabh-2023-09-05_12:16:09-orch:cephadm-wip-rishabh-2023aug3-b5-testing-default-smithi/

Doh. A bunch of failures like
Command failed on smithi029 with status 1: "grep '^nvme_loop' /proc/modules || sudo modprobe nvme_loop && sudo mkdir -p /sys/kernel/config/nvmet/hosts/hostnqn && sudo mkdir -p /sys/kernel/config/nvmet/ports/1 && echo loop | sudo tee /sys/kernel/config/nvmet/ports/1/addr_trtype"
@adk3798 These are the same failures that I see with my PR #52708

I think it's fine. I did a run myself on the same build and didn't see any of htose failures. I really think it's something with how the tests are run. Worst case if I'm wrong we can revert but I don't think my tests will start failing like this after this is merged.

vshankar · 2023-09-05T14:28:22Z

http://pulpito.front.sepia.ceph.com/rishabh-2023-09-05_12:16:09-orch:cephadm-wip-rishabh-2023aug3-b5-testing-default-smithi/

Doh. A bunch of failures like
Command failed on smithi029 with status 1: "grep '^nvme_loop' /proc/modules || sudo modprobe nvme_loop && sudo mkdir -p /sys/kernel/config/nvmet/hosts/hostnqn && sudo mkdir -p /sys/kernel/config/nvmet/ports/1 && echo loop | sudo tee /sys/kernel/config/nvmet/ports/1/addr_trtype"
@adk3798 These are the same failures that I see with my PR #52708
I think it's fine. I did a run myself on the same build and didn't see any of htose failures. I really think it's something with how the tests are run. Worst case if I'm wrong we can revert but I don't think my tests will start failing like this after this is merged.

In that case @adk3798, can you include changes from #52708 in your next test run please?

adk3798 · 2023-09-05T14:35:49Z

http://pulpito.front.sepia.ceph.com/rishabh-2023-09-05_12:16:09-orch:cephadm-wip-rishabh-2023aug3-b5-testing-default-smithi/

Doh. A bunch of failures like
Command failed on smithi029 with status 1: "grep '^nvme_loop' /proc/modules || sudo modprobe nvme_loop && sudo mkdir -p /sys/kernel/config/nvmet/hosts/hostnqn && sudo mkdir -p /sys/kernel/config/nvmet/ports/1 && echo loop | sudo tee /sys/kernel/config/nvmet/ports/1/addr_trtype"
@adk3798 These are the same failures that I see with my PR #52708
I think it's fine. I did a run myself on the same build and didn't see any of htose failures. I really think it's something with how the tests are run. Worst case if I'm wrong we can revert but I don't think my tests will start failing like this after this is merged.
In that case @adk3798, can you include changes from #52708 in your next test run please?

tagged it. As soon as main builds are working I'll make a new build and test it.

rishabh-d-dave

https://tracker.ceph.com/projects/cephfs/wiki/Main#5-Sep-2023

rishabh-d-dave added bug-fix cephfs Ceph File System tests needs-review labels Aug 10, 2023

rishabh-d-dave requested review from a team, adk3798 and dparmar18 August 10, 2023 12:40

adk3798 approved these changes Aug 10, 2023

View reviewed changes

adk3798 added the wip-adk4-testing label Aug 10, 2023

rishabh-d-dave force-pushed the test-nfs-pr-52556 branch from 07470a8 to 69057af Compare August 11, 2023 08:09

adk3798 added wip-adk-testing and removed wip-adk4-testing labels Aug 15, 2023

adk3798 reviewed Aug 21, 2023

View reviewed changes

qa/tasks/ceph_test_case.py Show resolved Hide resolved

rishabh-d-dave force-pushed the test-nfs-pr-52556 branch from 69057af to 4b369cf Compare August 24, 2023 18:16

rishabh-d-dave added the wip-rishabh-testing Rishabh's testing label label Aug 25, 2023

dparmar18 reviewed Aug 25, 2023

View reviewed changes

qa/tasks/cephfs/cephfs_test_case.py Show resolved Hide resolved

rishabh-d-dave removed the wip-rishabh-testing Rishabh's testing label label Sep 4, 2023

vshankar mentioned this pull request Sep 5, 2023

mgr/nfs: include pseudo in JSON output when nfs export apply -i fails #53177

Merged

14 tasks

rishabh-d-dave added the wip-rishabh-testing Rishabh's testing label label Sep 5, 2023

rishabh-d-dave removed the wip-adk-testing label Sep 5, 2023

adk3798 approved these changes Sep 5, 2023

View reviewed changes

rishabh-d-dave commented Sep 5, 2023

View reviewed changes

rishabh-d-dave merged commit 00f23e9 into ceph:main Sep 5, 2023

rishabh-d-dave mentioned this pull request Sep 5, 2023

qa/tasks/test_nfs: have TestNFS inherit from CephFSTestCase #52556

Closed

14 tasks

rishabh-d-dave deleted the test-nfs-pr-52556 branch September 5, 2023 15:51

rishabh-d-dave mentioned this pull request Dec 15, 2023

qa/cephfs: add helper methods in CephFSTestCase #50569

Merged

14 tasks

This was referenced Feb 27, 2024

reef: qa: inherit RunCephCmd in CephTestCase instead of CephFSTestCase #55780

Closed

quincy: qa: inherit RunCephCmd in CephTestCase instead of CephFSTestCase #55781

Closed

vshankar mentioned this pull request Mar 6, 2024

reef: use raw_cluster_cmd instead of run_ceph_cmd #55836

Merged

14 tasks

Conversation

rishabh-d-dave commented Aug 10, 2023

Contribution Guidelines

Checklist

Uh oh!

adk3798 left a comment

Choose a reason for hiding this comment

Uh oh!

rishabh-d-dave commented Aug 11, 2023

Uh oh!

Uh oh!

vshankar commented Aug 23, 2023

Uh oh!

rishabh-d-dave commented Aug 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rishabh-d-dave commented Aug 24, 2023

Uh oh!

rishabh-d-dave commented Aug 24, 2023

Uh oh!

vshankar commented Aug 25, 2023

Uh oh!

Uh oh!

vshankar commented Aug 25, 2023

Uh oh!

rishabh-d-dave commented Aug 25, 2023

Uh oh!

vshankar commented Aug 28, 2023

Uh oh!

adk3798 commented Aug 28, 2023

Uh oh!

vshankar commented Aug 29, 2023

Uh oh!

rishabh-d-dave commented Sep 4, 2023

Uh oh!

vshankar commented Sep 5, 2023

Uh oh!

rishabh-d-dave commented Sep 5, 2023

Uh oh!

vshankar commented Sep 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rishabh-d-dave commented Sep 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adk3798 commented Sep 5, 2023

Uh oh!

vshankar commented Sep 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adk3798 commented Sep 5, 2023

Uh oh!

rishabh-d-dave left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rishabh-d-dave commented Aug 23, 2023 •

edited

Loading

vshankar commented Sep 5, 2023 •

edited

Loading

rishabh-d-dave commented Sep 5, 2023 •

edited

Loading

vshankar commented Sep 5, 2023 •

edited

Loading