Skip to content

xio: sync work#5254

Merged
tchaikov merged 6 commits intoceph:masterfrom
vuhuong:wip-xio
Jul 28, 2015
Merged

xio: sync work#5254
tchaikov merged 6 commits intoceph:masterfrom
vuhuong:wip-xio

Conversation

@vuhuong
Copy link

@vuhuong vuhuong commented Jul 16, 2015

. Revert XioConnection features back to XIO_ALL_FEATURES for now
. Handling connection error event
. Configurable max send inline
. Reduce default depth of accelio msg queue
. Reduce quantum to grow pool allocators

Vu Pham added 2 commits July 15, 2015 16:17
Correctly set XioConnection features with fake features until support
in future

Signed-of-by: Vu Pham <vu@mellanox.com>
Handling connection error event same as orderly-disconnect, closed
or refused events.

Signed-off-by: Vu Pham <vu@mellanox.com>
@loic-bot
Copy link

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vuhuong, is this change included by accident? this is what fails the test.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tchaikov,

Yes, it's a mistake, my bad.

@smithfarm smithfarm added the core label Jul 19, 2015
@vuhuong
Copy link
Author

vuhuong commented Jul 20, 2015

@tchaikov - I fixed the wrong change in ceph-object-corpus

@tchaikov
Copy link
Contributor

@vuhuong could you please squash commit e1faac1 with a60d103, i.e. to squash the fix with the one which introduces the build failure?

@vuhuong vuhuong force-pushed the wip-xio branch 2 times, most recently from 4ca0b6c to 1eb13a2 Compare July 21, 2015 18:43
Vu Pham added 4 commits July 21, 2015 11:43
Transport messages can be safely and completely cleaned up as
long as low level connection is valid

Signed-off-by: Vu Pham <vu@mellanox.com>
Allow configuring the maximum threshold to send inline

Signed-off-by: Vu Pham <vu@mellanox.com>
Signed-off-by: Vu Pham <vu@melanox.com>
Growing pool's allocators with the proper quantum to
reduce memory pressure and waste

Signed-off-by: Vu Pham <vu@mellanox.com>
@vuhuong
Copy link
Author

vuhuong commented Jul 21, 2015

@tchaikov - I squashed these two commits.
Sorry for double pushes of same commits but I hope they are ok.

@loic-bot
Copy link

@vuhuong
Copy link
Author

vuhuong commented Jul 27, 2015

@tchaikov - any update on this? Do I need to do anything else?

tchaikov added a commit that referenced this pull request Jul 28, 2015
@vuhuong sorry for the latency, could you please rebase & repush , to poke the built bot again?

once the build completes, will get it merged.

thanks,
@tchaikov tchaikov merged commit 11e313e into ceph:master Jul 28, 2015
@tchaikov
Copy link
Contributor

@vuhuong sorry for the latency, could you please rebase & repush , to poke the built bot again?

once the build completes, will get it merged.

thanks,

i merged it by accident. will revert it if any of the gitbuilders yells at me.

sorry, i should not take any beer when checking the pull requests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants