Merged
Conversation
added 2 commits
July 15, 2015 16:17
Correctly set XioConnection features with fake features until support in future Signed-of-by: Vu Pham <vu@mellanox.com>
Handling connection error event same as orderly-disconnect, closed or refused events. Signed-off-by: Vu Pham <vu@mellanox.com>
ceph-object-corpus
Outdated
Contributor
There was a problem hiding this comment.
@vuhuong, is this change included by accident? this is what fails the test.
Author
There was a problem hiding this comment.
Yes, it's a mistake, my bad.
Author
|
@tchaikov - I fixed the wrong change in ceph-object-corpus |
Contributor
4ca0b6c to
1eb13a2
Compare
added 4 commits
July 21, 2015 11:43
Transport messages can be safely and completely cleaned up as long as low level connection is valid Signed-off-by: Vu Pham <vu@mellanox.com>
Allow configuring the maximum threshold to send inline Signed-off-by: Vu Pham <vu@mellanox.com>
Signed-off-by: Vu Pham <vu@melanox.com>
Growing pool's allocators with the proper quantum to reduce memory pressure and waste Signed-off-by: Vu Pham <vu@mellanox.com>
Author
|
@tchaikov - I squashed these two commits. |
Author
|
@tchaikov - any update on this? Do I need to do anything else? |
tchaikov
added a commit
that referenced
this pull request
Jul 28, 2015
@vuhuong sorry for the latency, could you please rebase & repush , to poke the built bot again? once the build completes, will get it merged. thanks,
Contributor
i merged it by accident. will revert it if any of the gitbuilders yells at me. sorry, i should not take any beer when checking the pull requests! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
. Revert XioConnection features back to XIO_ALL_FEATURES for now
. Handling connection error event
. Configurable max send inline
. Reduce default depth of accelio msg queue
. Reduce quantum to grow pool allocators