mds: remove calculating caps after adding revokes back#52176
Merged
mds: remove calculating caps after adding revokes back#52176
Conversation
kotreshhr
reviewed
Jun 26, 2023
vshankar
reviewed
Jun 28, 2023
The calc_issued() makes no sense and will blindly set the 'issued' to the 'pending', which is incorrect. For the cap update msg it will pass the client's 'implemented' caps to MDS, and MDS will use the 'implemented' to calculate the 'issued' and 'pending' members and also will adjust the revoke list. The confirm_receipt() has already correctly calculating the 'issued' and 'pending' members. And after add the cap back to the revoke list we should mark it notable, which will move the cap object to the front of session list. Fixes: https://tracker.ceph.com/issues/61781 Signed-off-by: Xiubo Li <xiubli@redhat.com>
vshankar
approved these changes
Jul 13, 2023
vshankar
added a commit
to vshankar/ceph
that referenced
this pull request
Jul 24, 2023
* refs/pull/52176/head: mds: remove calculating caps after adding revokes back Reviewed-by: Venky Shankar <vshankar@redhat.com>
Contributor
|
Running into lots of "failed to fetch package" issues with the run such as - https://pulpito.ceph.com/vshankar-2023-07-25_11:25:54-fs-wip-vshankar-testing-20230725.053049-testing-default-smithi/7350458/ The kernel build are available. @lxbsz suspects bug in teuthology. Will keep you updated. |
vshankar
approved these changes
Jul 27, 2023
Contributor
|
jenkins test api |
Contributor
|
jenkins test windows |
This was referenced Aug 7, 2023
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The calc_issued() makes no sense and will blindly set the 'issued'
to the 'pending', which is incorrect.
For the cap update msg it will pass the client's 'implemented' caps
to MDS, and MDS will use the 'implemented' to calculate the 'issued'
and 'pending' members and also will adjust the revoke list.
The confirm_receipt() has already correctly calculating the 'issued'
and 'pending' members. And after add the cap back to the revoke list
we should mark it notable, which will move the cap object to the
front of session list.
Fixes: https://tracker.ceph.com/issues/61781
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows