Merged
Conversation
a84b9f1 to
63e6b50
Compare
neha-ojha
approved these changes
May 17, 2023
Member
neha-ojha
left a comment
There was a problem hiding this comment.
While you are it, would you mind fixing other occurrences of the same typo (e.g. thrash-backfill-full.yaml)? :)
ljflores
approved these changes
May 17, 2023
Using the default pool size of 2 with random eio thrashing can cause some of the object to mark as lost. fixing typo from 'osd default pool size: 3' to 'osd pool default size: 3' so we will have pool size 3 correctly. Fixes: https://tracker.ceph.com/issues/49888 Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
63e6b50 to
c9d98ec
Compare
Contributor
Author
Added to the exist commit. |
Contributor
Author
Done, for teuthology i'll create another PR, and we will need another discussion regarding that. |
Contributor
Author
|
jenkins test api |
rzarzynski
approved these changes
May 23, 2023
Member
This was referenced May 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the default pool size of 2 with random eio thrashing can cause some of the object to mark as lost.
fixing typo from 'osd default pool size: 3' to 'osd pool default size: 3' so we will have pool size 3 correctly.
Fixes: https://tracker.ceph.com/issues/49888
Signed-off-by: Nitzan Mordechai nmordech@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows