Skip to content

tests: change override to overrides so conf will take affect#51528

Merged
yuriw merged 1 commit intoceph:mainfrom
NitzanMordhai:wip-nitzan-tests-using-override-instead-overrides
May 22, 2023
Merged

tests: change override to overrides so conf will take affect#51528
yuriw merged 1 commit intoceph:mainfrom
NitzanMordhai:wip-nitzan-tests-using-override-instead-overrides

Conversation

@NitzanMordhai
Copy link
Contributor

@NitzanMordhai NitzanMordhai commented May 17, 2023

We have few test suites that using 'override' in yaml file while ceph.py task is looking for 'overrides', in that case those configure params won't take any affects.

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

We have few test suites that using 'override' in yaml file
while ceph.py task is looking for 'overrides', in that case
those configure params won't take any affects.

Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
@NitzanMordhai NitzanMordhai requested a review from a team as a code owner May 17, 2023 10:42
@ljflores
Copy link
Member

@yuriw yuriw merged commit 7873afc into ceph:main May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants