bluestore: Elastic Shared Blobs 1 - mixed preparation#51439
Closed
bluestore: Elastic Shared Blobs 1 - mixed preparation#51439
Conversation
After introduction of lazy statfs updates and mechanism to store them at exit, some tests required tune-up. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Fix it, so it can be enabled and work. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Add more checks on consistency. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Upgrade local foreach_shared_blob into _fsck_foreach_shared_blob that can be used on entire BlueStore scope. Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
This was referenced May 11, 2023
Contributor
Author
|
jenkins test make check |
ifed01
approved these changes
May 15, 2023
Contributor
ifed01
left a comment
There was a problem hiding this comment.
LGTM, single cosmetic fix for fsck output, please...
14 tasks
rzarzynski
reviewed
May 22, 2023
src/os/bluestore/BlueStore.cc
Outdated
| } // for ... extent_map | ||
| } // for ... it->valid | ||
| } //if (it(PREFIX_OBJ)) | ||
| stop_iterating:; |
Contributor
There was a problem hiding this comment.
Is there any reason in favor of goto than return (with a comment maybe)?
When we do fsck with non-repair mode, we do not get any info about shared blobs that actually were corrupted. Now we print them. Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
Make faster exit when sharding not enabled. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
When reshard is applied for the first time, expand reshard range to encompas whole object. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
maybe_reshard is created to filter out unnecessary calls to request_reshard. The intended use is to let just request maybe_reshard, and delegate check if the action is really necessary to the implementation detail level. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
When encode_some fails twice ceph aborts. Now we print object details just before. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Modifed bluestore_blob_t to include current size of csum_data. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Add printing of len to operator<< for const bluestore_blob_t. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
9ea701a to
c36d97e
Compare
11 tasks
14 tasks
14 tasks
Contributor
|
Merged as a part of #53178. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part 1/4 of ESB work.
It contains fixes and improvements that are useful to BlueStore but not necessary, but are necessary to the ESB.
#51439
#51440
#51441
#51442
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows