Skip to content

rgw/aio: fix recursion from tracing changes#51031

Merged
cbodley merged 1 commit intoceph:mainfrom
cbodley:wip-59423
Apr 19, 2023
Merged

rgw/aio: fix recursion from tracing changes#51031
cbodley merged 1 commit intoceph:mainfrom
cbodley:wip-59423

Conversation

@cbodley
Copy link
Contributor

@cbodley cbodley commented Apr 11, 2023

a regression from #47457 that caused aio_abstract() to recurse in the null_yield case

Fixes: https://tracker.ceph.com/issues/59423

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@cbodley
rgw/aio: fix recursion from tracing changes
9f160e4 
Fixes: https://tracker.ceph.com/issues/59423

Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley cbodley requested a review from yuvalif April 11, 2023 14:50
@cbodley cbodley requested a review from a team as a code owner April 11, 2023 14:50
@cbodley
Copy link
Contributor Author

cbodley commented Apr 12, 2023

jenkins test make check

@soumyakoduri
Copy link
Contributor

soumyakoduri commented Apr 15, 2023

@cbodley I had included this fix in my latest teuthology run (http://pulpito.front.sepia.ceph.com/soumyakoduri-2023-04-14_07:23:19-rgw-wip-skoduri-archive-distro-default-smithi/detail).. it reported below valgrind issue -

 Traceback (most recent call last):
    File "/home/teuthworker/src/git.ceph.com_teuthology_8d156aede5efdae00b53d8d3b8d127082980e7ec/teuthology/task/internal/__init__.py", line 48, in base
      yield
    File "/home/teuthworker/src/git.ceph.com_teuthology_8d156aede5efdae00b53d8d3b8d127082980e7ec/teuthology/run_tasks.py", line 192, in run_tasks
      suppress = manager.__exit__(*exc_info)
    File "/usr/lib/python3.8/contextlib.py", line 120, in __exit__
      next(self.gen)
    File "/home/teuthworker/src/git.ceph.com_ceph-c_762676addd7931d50890beb1231874724f333206/qa/tasks/ceph.py", line 1952, in task
      mon0_remote.run(
    File "/usr/lib/python3.8/contextlib.py", line 120, in __exit__
      next(self.gen)
    File "/home/teuthworker/src/git.ceph.com_teuthology_8d156aede5efdae00b53d8d3b8d127082980e7ec/teuthology/contextutil.py", line 55, in nested
      raise exc[1]
    File "/usr/lib/python3.8/contextlib.py", line 131, in __exit__
      self.gen.throw(type, value, traceback)
    File "/home/teuthworker/src/git.ceph.com_ceph-c_762676addd7931d50890beb1231874724f333206/qa/tasks/ceph.py", line 251, in ceph_log
      yield
    File "/home/teuthworker/src/git.ceph.com_teuthology_8d156aede5efdae00b53d8d3b8d127082980e7ec/teuthology/contextutil.py", line 47, in nested
      if exit(*exc):
    File "/usr/lib/python3.8/contextlib.py", line 120, in __exit__
      next(self.gen)
    File "/home/teuthworker/src/git.ceph.com_ceph-c_762676addd7931d50890beb1231874724f333206/qa/tasks/ceph.py", line 362, in valgrind_post
      raise valgrind_exception
  Exception: saw valgrind issues

Not sure if its related to this fix. Can you please review it.

@cbodley
Copy link
Contributor Author

cbodley commented Apr 17, 2023

@cbodley I had included this fix in my latest teuthology run (http://pulpito.front.sepia.ceph.com/soumyakoduri-2023-04-14_07:23:19-rgw-wip-skoduri-archive-distro-default-smithi/detail).. it reported below valgrind issue

earlier in the run, test_librgw_file.sh failed with a tcmalloc crash:

2023-04-14T08:04:02.250 INFO:tasks.workunit.client.0.smithi131.stdout:phase 1.1
2023-04-14T08:04:02.274 INFO:tasks.workunit.client.0.smithi131.stderr:src/tcmalloc.cc:332] Attempt to free invalid pointer 0x55c15800cbd0
2023-04-14T08:04:02.317 DEBUG:teuthology.orchestra.run:got remote process result: 134
2023-04-14T08:04:02.317 INFO:tasks.workunit.client.0.smithi131.stderr:Aborted (core dumped)

that's tracked in https://tracker.ceph.com/issues/59269, and the fix in #51068 needs qa

@cbodley
Copy link
Contributor Author

cbodley commented Apr 19, 2023

jenkins test make check

@cbodley
Copy link
Contributor Author

cbodley commented Apr 19, 2023

verified along with #51068 in https://pulpito.ceph.com/cbodley-2023-04-18_15:15:51-rgw-wip-59269-distro-default-smithi/ - results are messy, but the librgw failures are gone

@cbodley cbodley mentioned this pull request Apr 19, 2023
Merged
@cbodley cbodley merged commit 5609383 into ceph:main Apr 19, 2023
@cbodley cbodley deleted the wip-59423 branch April 19, 2023 15:36
yuvalif added a commit to yuvalif/ceph that referenced this pull request Apr 30, 2023
@yuvalif
Revert "Merge pull request ceph#51031 from cbodley/wip-59423"
689e217 
This reverts commit 5609383, reversing
changes made to fba5b3f.

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
@yuvalif yuvalif mentioned this pull request Apr 30, 2023
Merged
14 tasks
gregsfortytwo added a commit that referenced this pull request Apr 30, 2023
@gregsfortytwo
Merge pull request #51293 from yuvalif/wip-yuval-revert-47457
7179c0e 
revert PRs #47457 and #51031

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dang dang dang approved these changes

@yuvalif yuvalif yuvalif approved these changes

Assignees

No one assigned

Labels

bug-fix ready-to-merge rgw

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cbodley @soumyakoduri @dang @yuvalif