mds: use variable g_ceph_context directly in MDSAuthCaps#50874
Merged
rishabh-d-dave merged 1 commit intoceph:mainfrom Jun 16, 2023
Merged
mds: use variable g_ceph_context directly in MDSAuthCaps#50874rishabh-d-dave merged 1 commit intoceph:mainfrom
rishabh-d-dave merged 1 commit intoceph:mainfrom
Conversation
Contributor
|
the part of code looks much cleaner with this change |
vshankar
approved these changes
Apr 10, 2023
Contributor
|
@rishabh-d-dave please pick this up in your next run. |
Contributor
Author
Yes. |
4 tasks
b4fda46 to
9fd5e81
Compare
Contributor
Author
|
No changes, just a rebase. |
rzarzynski
approved these changes
May 2, 2023
Contributor
rzarzynski
left a comment
There was a problem hiding this comment.
The tiny mon change LGTM.
I hasn't checked the implicit assumption MDSAuthCaps isn't / won't be used in libraries.
| } else if (type == "mds") { | ||
| MDSAuthCaps mdscap; | ||
| if (!mdscap.parse(g_ceph_context, caps, out)) { | ||
| if (!mdscap.parse(caps, out)) { |
Contributor
There was a problem hiding this comment.
From the mon's perspective this should be fine.
Just a note:
It is fine to use dout and derr in daemons, but in library code, you must use ldout and lderr, and pass in your own CephContext object. The compiler will enforce this restriction.
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
Contributor
|
@rishabh-d-dave please rebase and do the needful. |
Contributor
Author
Yes, I am on it. Due to teuthology infra issues, testing wasn't complete but it is now. Will review results once more and merge this PR. |
rishabh-d-dave
commented
Jun 16, 2023
Variable g_ceph_context is global, therefore use it directly instead of passing it as a parameter to method. Signed-off-by: Rishabh Dave <ridave@redhat.com>
9fd5e81 to
64c2712
Compare
rishabh-d-dave
added a commit
to rishabh-d-dave/ceph
that referenced
this pull request
Jun 16, 2023
Since PR ceph#50874 has been merged, this method can do the exact same job in much lesser code. Also since we are here, let's rename variable "type" to "entity". Signed-off-by: Rishabh Dave <ridave@redhat.com>
rishabh-d-dave
added a commit
to rishabh-d-dave/ceph
that referenced
this pull request
Jun 18, 2023
Since PR ceph#50874 has been merged, this method can do the exact same job in much lesser code. Also since we are here, let's rename variable "type" to "entity". Signed-off-by: Rishabh Dave <ridave@redhat.com>
rishabh-d-dave
added a commit
to rishabh-d-dave/ceph
that referenced
this pull request
Jun 18, 2023
Since PR ceph#50874 has been merged, this method can do the exact same job in much lesser code. Also since we are here, let's rename variable "type" to "entity". Signed-off-by: Rishabh Dave <ridave@redhat.com>
rishabh-d-dave
added a commit
to rishabh-d-dave/ceph
that referenced
this pull request
Jun 19, 2023
Since PR ceph#50874 has been merged, this method can do the exact same job in much lesser code. Also since we are here, let's rename variable "type" to "entity". Signed-off-by: Rishabh Dave <ridave@redhat.com>
joscollin
pushed a commit
to joscollin/ceph
that referenced
this pull request
Jul 31, 2023
Since PR ceph#50874 has been merged, this method can do the exact same job in much lesser code. Also since we are here, let's rename variable "type" to "entity". Signed-off-by: Rishabh Dave <ridave@redhat.com>
This was referenced Aug 4, 2023
aaSharma14
pushed a commit
to rhcs-dashboard/ceph
that referenced
this pull request
Jan 2, 2024
Since PR ceph#50874 has been merged, this method can do the exact same job in much lesser code. Also since we are here, let's rename variable "type" to "entity". Signed-off-by: Rishabh Dave <ridave@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variable g_ceph_context is global, therefore use it directly instead of
passing it as a parameter to method.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows