qa/cephfs: add more helper methods to caps_helper.py#50497
qa/cephfs: add more helper methods to caps_helper.py#50497rishabh-d-dave merged 1 commit intoceph:mainfrom
Conversation
a44d476 to
880b810
Compare
|
jenkins test make check |
qa/tasks/cephfs/caps_helper.py
Outdated
| self.test_set] | ||
|
|
||
| self.conduct_pos_test_for_read_caps() | ||
| self.run_pos_test_for_read_caps() |
There was a problem hiding this comment.
This commit says "Give these this methods a smaller name"
Does this change really help in any way?
There was a problem hiding this comment.
Yes, it would more helpful if it could be contracted further.
There was a problem hiding this comment.
I hate to nit pick of these things, but how small is small? :)
There was a problem hiding this comment.
Umm, true. I should remove this change I guess...
We usually name our methods as run_abcd(). At least this change aligns this method name with general manner of naming. If this doesn't seem like a good reason, I'll remove this change. :)
e05a25e to
493eaff
Compare
493eaff to
025d0cb
Compare
vshankar
left a comment
There was a problem hiding this comment.
Minor comment - otherwise LGTM.
@rishabh-d-dave Please run this through QA.
Replied - #50497 (comment). Let me know whatever you think is appropriate and I'll make the change accordingly.
This has been tested before but I'll give this one more run - #50497 (comment) |
Add methods that will accept read/write permissions, CephFS names and CephFS mount point and in return will generate string form of MON, OSD and MDS caps exactly as it is reported in Ceph keyrings. Replace similar code in test_multifs_auth.py with calls to these helper methods. Signed-off-by: Rishabh Dave <ridave@redhat.com>
025d0cb to
969a93d
Compare
The code on this PR first appeared on
fs authPR (PR #41779) since that PR needs more time to be reviewed and merged. This code is needed byfs swapPR (PR #50212) too, I am creating a new PR for this code hoping this will merge faster and thereby this code will become available to both the PRs.Add methods that will accept read/write permissions, CephFS names and
CephFS mount point and in return will generate string form of MON, OSD
and MDS caps exactly as it is reported in Ceph keyrings.
Replace similar code in test_multifs_auth.py with calls to these helper
methods.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows