cephfs: add command "ceph fs swap" by rishabh-d-dave · Pull Request #50212 · ceph/ceph

rishabh-d-dave · 2023-02-22T13:55:33Z

Add a FS command that enables users to swap names of two file systems in
a single PAXOS transaction.

Fixes: https://tracker.ceph.com/issues/58129

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows

src/mon/FSCommands.cc

rishabh-d-dave · 2023-03-21T20:05:38Z

@batrick

test_fs_swap is passing locally every time but with teuthology fails every time at this line - https://github.com/ceph/ceph/pull/50212/files#diff-534e44897921b6dcac93d2c7bb1cf04a3727bf1f025c579f83d898e2c2257400R836.

From output of fs dump it looks like the fs swap command had no effect, FS names are unswapped. I added a sleep (of 5 minutes) to test code after fs swap command gets executed thinking maybe it needs a little time to upgrade map but that didn't help.

Can you please take a quick look and let me know if current changes look okay?

Following is the link to latest run, in case you want to take a look - http://pulpito.front.sepia.ceph.com/rishabh-2023-03-21_17:30:06-fs:functional-wip-rishabh-fs-swap-subcmd-distro-default-smithi/

And here's the branch that I passed to --suite-branch option - https://github.com/rishabh-d-dave/ceph/tree/fs-swap-subcmd-temp

src/mds/FSMap.h

github-actions · 2023-03-23T14:03:51Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

rishabh-d-dave · 2023-03-23T17:50:08Z

http://pulpito.front.sepia.ceph.com/rishabh-2023-03-23_16:40:45-fs:functional-wip-rishabh-fs-swap-subcmd-distro-default-smithi/

Signed-off-by: Rishabh Dave <ridave@redhat.com>

When assert fails for equality of two variables and when both the variables are printed in error message, print each variable on a new line. Signed-off-by: Rishabh Dave <ridave@redhat.com>

PendingReleaseNotes

src/mon/FSCommands.cc

When two values (say x and y) are being printed because assert for equality of both failed (assert x == y), print both the values on a new line. Signed-off-by: Rishabh Dave <ridave@redhat.com>

Signed-off-by: Rishabh Dave <ridave@redhat.com>

Commands issued by negtest_ceph_cmd() aren't printed because log level (due to code for teuthology) changes from DEBUG to INFO in case of some files. This patch ensures that users can see commands being executed regardless of whether log level is changed or not. Signed-off-by: Rishabh Dave <ridave@redhat.com>

batrick

Thanks for writing tests cases for all the edge cases!

PendingReleaseNotes

doc/cephfs/administration.rst

doc/man/8/ceph.rst

src/mds/FSMap.cc

src/mon/FSCommands.cc

rishabh-d-dave · 2023-10-13T05:44:25Z

http://pulpito.front.sepia.ceph.com:80/rishabh-2023-10-13_05:42:39-fs-fs-swap-subcmd-testing-default-smithi/
http://pulpito.front.sepia.ceph.com/rishabh-2023-10-13_06:21:51-fs-fs-swap-subcmd-testing-default-smithi/

PendingReleaseNotes

doc/cephfs/administration.rst

batrick

Good work!

rishabh-d-dave · 2023-10-13T19:37:59Z

Last push was about bits of minor fixes and improvements I made while running tests locally.

vshankar

LGTM. @rishabh-d-dave please proceed to integration runs.

rishabh-d-dave · 2023-11-02T19:07:40Z

Tests needs some minor debugging and fixing.

Add a FS command that enables users to swap names of two file systems in a single PAXOS transaction. Add an option to this command that swaps FSCIDS along with FS names. This commands also updates the application pool tags and fails when mirroring is enabled on either or both FSs. Fixes: https://tracker.ceph.com/issues/58129 Signed-off-by: Rishabh Dave <ridave@redhat.com>

Create an alias so "APP_NAME_CEPHFS" can be written instead of "pg_pool_t::APPLICATION_NAME_CEPHFS". Signed-off-by: Rishabh Dave <ridave@redhat.com>

When working with large group tests (18 in this case), it gets very tedious to debug and fix tests when all 18 have to be run again for every mistake. Cheap fix for this to split these 18 tests into several classes. But when modification are made to the feature, all these 18 tests needs to exercised and previous solution forces developer to intitiate all these test classes to run one by one. Best of both worlds can be achieved if we split tests into group but move all these related group to a new file. Signed-off-by: Rishabh Dave <ridave@redhat.com>

rishabh-d-dave · 2023-11-03T09:56:54Z

Ran tests a bunch of times locally, tests are working fine now.

rishabh-d-dave · 2023-11-03T16:43:22Z

https://pulpito.ceph.com/rishabh-2023-11-03_16:37:16-fs:functional-rishabh-fs-swap-testing-default-smithi

rishabh-d-dave

CephFS integration tests were successful - https://tracker.ceph.com/projects/cephfs/wiki/Main#7-Nov-2023

rishabh-d-dave · 2023-11-07T17:53:53Z

jenkins test make check

rishabh-d-dave requested a review from a team as a code owner February 22, 2023 13:55

rishabh-d-dave added cephfs Ceph File System tests labels Feb 22, 2023

github-actions bot added core mon labels Feb 22, 2023

rishabh-d-dave marked this pull request as draft February 22, 2023 13:56

batrick requested changes Feb 23, 2023

View reviewed changes

src/mon/FSCommands.cc Outdated Show resolved Hide resolved

src/mon/FSCommands.cc Show resolved Hide resolved

This was referenced Mar 13, 2023

mon,osd,mds: allow fs authorize to update caps #41779

Merged

qa/cephfs: add more helper methods to caps_helper.py #50497

Merged

rishabh-d-dave force-pushed the fs-swap-subcmd branch from 5d74639 to 58485bc Compare March 13, 2023 13:10

rishabh-d-dave marked this pull request as ready for review March 13, 2023 13:18

rishabh-d-dave requested a review from a team March 13, 2023 13:18

rishabh-d-dave force-pushed the fs-swap-subcmd branch from 58485bc to fe21648 Compare March 13, 2023 13:35

rishabh-d-dave force-pushed the fs-swap-subcmd branch 4 times, most recently from fab9697 to 2c56e70 Compare March 20, 2023 19:34

rishabh-d-dave requested a review from batrick March 21, 2023 19:54

rishabh-d-dave force-pushed the fs-swap-subcmd branch 2 times, most recently from 7fa7cae to 13781c5 Compare March 23, 2023 13:13

rishabh-d-dave commented Mar 23, 2023

View reviewed changes

src/mds/FSMap.h Outdated Show resolved Hide resolved

rishabh-d-dave force-pushed the fs-swap-subcmd branch from 13781c5 to 7bbad74 Compare March 23, 2023 14:01

rishabh-d-dave requested a review from a team as a code owner March 23, 2023 14:01

github-actions bot added documentation needs-rebase labels Mar 23, 2023

rishabh-d-dave force-pushed the fs-swap-subcmd branch from 7bbad74 to aec07d8 Compare March 23, 2023 17:51

github-actions bot removed the needs-rebase label Mar 23, 2023

rishabh-d-dave added 3 commits October 10, 2023 16:38

mds/FSMap: add logging facility

be78b3e

Signed-off-by: Rishabh Dave <ridave@redhat.com>

qa/cephfs: import only sleep() from time

69e4c9e

Signed-off-by: Rishabh Dave <ridave@redhat.com>

qa/cephfs: minor improvement caps_helper.py

6ac58b0

When assert fails for equality of two variables and when both the variables are printed in error message, print each variable on a new line. Signed-off-by: Rishabh Dave <ridave@redhat.com>

rishabh-d-dave force-pushed the fs-swap-subcmd branch from b689c2b to 7980b58 Compare October 10, 2023 11:08

github-actions bot removed the needs-rebase label Oct 10, 2023

rishabh-d-dave requested review from batrick and lxbsz October 10, 2023 15:02

vshankar reviewed Oct 11, 2023

View reviewed changes

PendingReleaseNotes Outdated Show resolved Hide resolved

src/mon/FSCommands.cc Show resolved Hide resolved

rishabh-d-dave force-pushed the fs-swap-subcmd branch from 7980b58 to c89589d Compare October 11, 2023 10:00

rishabh-d-dave added 3 commits October 12, 2023 14:49

qa: minor improvement in ceph_test_case.py

edec8f3

When two values (say x and y) are being printed because assert for equality of both failed (assert x == y), print both the values on a new line. Signed-off-by: Rishabh Dave <ridave@redhat.com>

qa: log stdout for commands being run through negtest_ceph_cmd

bd4cb58

Signed-off-by: Rishabh Dave <ridave@redhat.com>

rishabh-d-dave force-pushed the fs-swap-subcmd branch from c89589d to 80a5527 Compare October 12, 2023 09:19

batrick requested changes Oct 12, 2023

View reviewed changes

batrick requested changes Oct 13, 2023

View reviewed changes

PendingReleaseNotes Outdated Show resolved Hide resolved

doc/cephfs/administration.rst Outdated Show resolved Hide resolved

doc/cephfs/administration.rst Outdated Show resolved Hide resolved

batrick approved these changes Oct 13, 2023

View reviewed changes

vshankar approved these changes Oct 20, 2023

View reviewed changes

rishabh-d-dave added 3 commits November 3, 2023 13:05

mon/FSCommands: use alias for higher brevity

4a12f6e

Create an alias so "APP_NAME_CEPHFS" can be written instead of "pg_pool_t::APPLICATION_NAME_CEPHFS". Signed-off-by: Rishabh Dave <ridave@redhat.com>

rishabh-d-dave commented Nov 7, 2023

View reviewed changes

rishabh-d-dave mentioned this pull request Nov 8, 2023

cephfs,mon: fs rename must require FS to be offline and refuse_client_session to be set #53899

Merged

14 tasks

This was referenced Dec 18, 2023

reef: cephfs: add command "ceph fs swap" #54942

Merged

quincy: cephfs: add command "ceph fs swap" #54943

Closed

Conversation

rishabh-d-dave commented Feb 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution Guidelines

Checklist

Uh oh!

Uh oh!

Uh oh!

rishabh-d-dave commented Mar 21, 2023

Uh oh!

Uh oh!

github-actions bot commented Mar 23, 2023

Uh oh!

rishabh-d-dave commented Mar 23, 2023

Uh oh!

Uh oh!

Uh oh!

batrick left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rishabh-d-dave commented Oct 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

batrick left a comment

Choose a reason for hiding this comment

Uh oh!

rishabh-d-dave commented Oct 13, 2023

Uh oh!

vshankar left a comment

Choose a reason for hiding this comment

Uh oh!

rishabh-d-dave commented Nov 2, 2023

Uh oh!

rishabh-d-dave commented Nov 3, 2023

Uh oh!

rishabh-d-dave commented Nov 3, 2023

Uh oh!

rishabh-d-dave left a comment

Choose a reason for hiding this comment

Uh oh!

rishabh-d-dave commented Nov 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rishabh-d-dave commented Feb 22, 2023 •

edited

Loading

rishabh-d-dave commented Oct 13, 2023 •

edited

Loading