Fix FTBFS on gcc 13 by tserong · Pull Request #50438 · ceph/ceph

tserong · 2023-03-08T11:52:49Z

There's a few things in here:

0024-gcc-13.patch from https://tracker.ceph.com/issues/58477
extra patches to rocksdb
tweaks to osd/scrubber to disambiguate format_to calls

These fix a bunch of gcc 13 build failures. Unfortunately there remains at least one outstanding issue:

[ 5881s] /home/abuild/rpmbuild/BUILD/ceph-18.0.0-2849-g2dba3d74341/src/rgw/driver/rados/rgw_sync_trace.cc: In member function 'int RGWSyncTraceManager::hook_to_admin_command()':
[ 5881s] /home/abuild/rpmbuild/BUILD/ceph-18.0.0-2849-g2dba3d74341/src/rgw/driver/rados/rgw_sync_trace.cc:149:137: internal compiler error: in gimplify_var_or_parm_decl, at gimplify.cc:3058
[ 5881s]   149 |                      { "sync trace active_short name=search,type=CephString,req=false", "show active multisite sync entities entries" } };

This was already reported to the GCC folks a few weeks ago:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108773

Hopefully we're good once that ICE is fixed, but in case we're not, I'll leave this PR in draft status for the time being.

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows

src/common/subsys_types.h

rzarzynski · 2023-03-08T12:09:17Z

cmake/modules/BuildRocksDB.cmake

    SOURCE_DIR "${rocksdb_SOURCE_DIR}"
    CMAKE_ARGS ${rocksdb_CMAKE_ARGS}
    BINARY_DIR "${rocksdb_BINARY_DIR}"
+    PATCH_COMMAND ${PATCH_EXECUTABLE} -p1 -i ${_build_rocksdb_list_dir}/rocksdb-gcc-13.patch


Do we need to patch rocksdb on our own? How about merging those changes with the rockdb's upsteam and moving forward the ceph/rocksdb fork?

agreed, we shouldn't need to patch our own submodule; we could start by merging this change to the ceph/rocksdb fork and carry it there until it merges upstream

Right, good point. The patch was because I actually started working on fixing gcc 13 issues in SUSE's downstream pacific version, and I wasn't sure I wanted to touch the rocksdb submodule in that context.

Submitted in ceph/rocksdb#44

src/msg/async/compression_onwire.h

src/osd/scrubber/scrub_backend.cc

tserong · 2023-03-09T11:11:46Z

OK, that's a bit cleaner now - thanks everyone!

Still need to sort out rocksdb separately and see how the GCC folks go with that ICE.

src/librbd/api/PoolMetadata.h

cbodley · 2023-05-15T17:23:48Z

is it maybe worth splitting the rocksdb submodule part into a separate PR, so we can merge the rest of it?

tserong · 2023-05-18T02:57:11Z

is it maybe worth splitting the rocksdb submodule part into a separate PR, so we can merge the rest of it?

good idea - I've just removed the rocksdb patch bits

idryomov

"osd: use std::format_to(...) to fix FTBFS on gcc 13" commit title needs updating since it's switching to fmt::format_to(), not std::format_to()
fold "test/librados: fix FTBFS on gcc 13" commit into "common, librbd, msg, test: fix FTBFS on gcc 13" -- no need to have two commits for the same cstdint include issue

src/common/Cycles.h

src/osd/scrubber/scrub_backend.cc

This is based on 0024-gcc-13.patch from https://tracker.ceph.com/issues/58477 but with an extra #include <cstdint> to avoid dropping std:: prefixes on integer types. Fixes: https://tracker.ceph.com/issues/58477 Signed-off-by: Tim Serong <tserong@suse.com>

tserong · 2023-05-19T07:00:37Z

jenkins test make check

idryomov

Otherwise LGTM

src/osd/scrubber/scrub_backend.cc

Without this the build will fail on gcc 13 with errors like: src/osd/scrubber/scrub_backend.cc:1309:14: error: call of overloaded 'format_to(std::back_insert_iterator<fmt::v9::basic_memory_buffer<char> >, const char [35], const char*, const uint64_t&, const uint64_t&, pg_shard_t&)' is ambiguous 1309 | format_to(std::back_inserter(out), | ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1310 | "{}size {} != size {} from shard {}", | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1311 | sep(error), | ~~~~~~~~~~~ 1312 | candidate.size, | ~~~~~~~~~~~~~~~ 1313 | auth.size, | ~~~~~~~~~~ 1314 | auth_shard); | ~~~~~~~~~~~ /usr/include/fmt/core.h:3233:17: note: candidate: 'OutputIt fmt::v9::format_to(OutputIt, format_string<T ...>, T&& ...) [with OutputIt = std::back_insert_iterator<basic_memory_buffer<char> >; T = {const char*, const long unsigned int&, const long unsigned int&, pg_shard_t&}; typename std::enable_if<detail::is_output_iterator<OutputIt, char>::value, int>::type <anonymous> = 0; format_string<T ...> = basic_format_string<char, const char*, const long unsigned int&, const long unsigned int&, pg_shard_t&>]' 3233 | FMT_INLINE auto format_to(OutputIt out, format_string<T...> fmt, T&&... args) | ^~~~~~~~~ /usr/include/c++/13/format:3761:5: note: candidate: '_Out std::format_to(_Out, format_string<_Args ...>, _Args&& ...) [with _Out = back_insert_iterator<fmt::v9::basic_memory_buffer<char> >; _Args = {const char*, const long unsigned int&, const long unsigned int&, pg_shard_t&}; format_string<_Args ...> = basic_format_string<char, const char*, const long unsigned int&, const long unsigned int&, pg_shard_t&>]' 3761 | format_to(_Out __out, format_string<_Args...> __fmt, _Args&&... __args) | ^~~~~~~~~ Fixes: https://tracker.ceph.com/issues/58477 Signed-off-by: Tim Serong <tserong@suse.com>

cbodley · 2023-05-23T19:14:06Z

@idryomov do you think this needs full qa? all of the builds except arm64 succeeded in https://shaman.ceph.com/builds/ceph/pr-50438/

idryomov · 2023-05-23T20:01:38Z

@idryomov do you think this needs full qa? all of the builds except arm64 succeeded in https://shaman.ceph.com/builds/ceph/pr-50438/

Probably not. If the builds succeed, it should be fine to merge.

The changes within are now included in the upstream, and are no longer needed Upstream-ref: ceph/ceph#50438

Upstream-ref: ceph/ceph#50438

The changes within are now included in the upstream, and are no longer needed Upstream-ref: ceph/ceph#50438

Upstream-ref: ceph/ceph#50438

from: ceph/ceph#50438 ceph/ceph#48661

The changes within are now included in the upstream, and are no longer needed Upstream-ref: ceph/ceph#50438

apteryks · 2025-12-19T12:12:06Z

Is ceph going to be updated to a newer rocksdb version? The 7.9 ish patched old copy it's using doesn't make it easy for downstream users that care about untangling the build (packaging it separately).

tserong requested review from a team as code owners March 8, 2023 11:52

tserong marked this pull request as draft March 8, 2023 11:52

github-actions bot added build/ops common core mon rbd tests labels Mar 8, 2023

rzarzynski reviewed Mar 8, 2023

View reviewed changes

rzarzynski requested a review from ronen-fr March 8, 2023 12:10

ronen-fr reviewed Mar 8, 2023

View reviewed changes

src/msg/async/compression_onwire.h Show resolved Hide resolved

ronen-fr reviewed Mar 8, 2023

View reviewed changes

src/osd/scrubber/scrub_backend.cc Show resolved Hide resolved

tserong force-pushed the wip-fix-58477 branch from 2dba3d7 to dfa98a2 Compare March 9, 2023 08:56

idryomov reviewed Mar 9, 2023

View reviewed changes

src/librbd/api/PoolMetadata.h Outdated Show resolved Hide resolved

tserong force-pushed the wip-fix-58477 branch from dfa98a2 to aa39d11 Compare March 9, 2023 19:55

tserong mentioned this pull request Mar 20, 2023

Fix FTBFS on gcc 13 ceph/rocksdb#44

Merged

cbodley mentioned this pull request May 8, 2023

GCC13 Fixes #51395

Closed

14 tasks

tserong force-pushed the wip-fix-58477 branch from ce3df98 to 2e55f27 Compare May 18, 2023 02:56

tserong marked this pull request as ready for review May 18, 2023 02:56

idryomov reviewed May 18, 2023

View reviewed changes

src/common/Cycles.h Outdated Show resolved Hide resolved

src/osd/scrubber/scrub_backend.cc Outdated Show resolved Hide resolved

tserong force-pushed the wip-fix-58477 branch from 2e55f27 to 8aa9872 Compare May 19, 2023 04:11

idryomov reviewed May 19, 2023

View reviewed changes

src/osd/scrubber/scrub_backend.cc Outdated Show resolved Hide resolved

tserong force-pushed the wip-fix-58477 branch from 8aa9872 to 1ae8eb6 Compare May 22, 2023 04:47

idryomov approved these changes May 22, 2023

View reviewed changes

idryomov added the needs-qa label May 22, 2023

idryomov merged commit 9363297 into ceph:main May 23, 2023

tserong deleted the wip-fix-58477 branch May 24, 2023 06:16

This was referenced Jun 19, 2023

reef: Fix FTBFS on gcc 13 #52119

Merged

quincy: Fix FTBFS on gcc 13 #52120

Merged

bazaah added a commit to bazaah/aur-ceph that referenced this pull request Jun 23, 2023

pkgbuild: rm upstreamed gcc13 patches

a094efd

The changes within are now included in the upstream, and are no longer needed Upstream-ref: ceph/ceph#50438

bazaah added a commit to bazaah/aur-ceph that referenced this pull request Jun 23, 2023

NOMERGE: add temp patch for upstream gcc13 fixes

5ca4163

Upstream-ref: ceph/ceph#50438

bazaah added a commit to bazaah/aur-ceph that referenced this pull request Jun 23, 2023

pkgbuild: rm upstreamed gcc13 patches

ac0a3bb

The changes within are now included in the upstream, and are no longer needed Upstream-ref: ceph/ceph#50438

bazaah added a commit to bazaah/aur-ceph that referenced this pull request Jun 23, 2023

NOMERGE: add temp patch for upstream gcc13 fixes

ef5b639

Upstream-ref: ceph/ceph#50438

pld-gitsync pushed a commit to pld-linux/ceph that referenced this pull request Jul 2, 2023

upstream fixes for gcc 13

ae1d774

from: ceph/ceph#50438 ceph/ceph#48661

irq0 mentioned this pull request Jul 5, 2023

Backport gcc13 fixes aquarist-labs/ceph#169

Merged

11 tasks

bazaah added a commit to bazaah/aur-ceph that referenced this pull request Jul 7, 2023

pkgbuild: rm upstreamed gcc13 patches

b97c78a

The changes within are now included in the upstream, and are no longer needed Upstream-ref: ceph/ceph#50438

bazaah added a commit to bazaah/aur-ceph that referenced this pull request Jul 7, 2023

pkgbuild: rm upstreamed gcc13 patches

d6623fc

The changes within are now included in the upstream, and are no longer needed Upstream-ref: ceph/ceph#50438

cbodley mentioned this pull request Jul 12, 2023

osd: an fmtlib formatter for OpSchedulerItem #52370

Merged

bazaah added a commit to bazaah/aur-ceph that referenced this pull request Aug 11, 2023

pkgbuild: rm upstreamed gcc13 patches

f36046c

The changes within are now included in the upstream, and are no longer needed Upstream-ref: ceph/ceph#50438

bazaah added a commit to bazaah/aur-ceph that referenced this pull request Aug 11, 2023

pkgbuild: rm upstreamed gcc13 patches

aa51012

The changes within are now included in the upstream, and are no longer needed Upstream-ref: ceph/ceph#50438

bazaah added a commit to bazaah/aur-ceph that referenced this pull request Aug 26, 2023

pkgbuild: rm upstreamed gcc13 patches

9771c63

The changes within are now included in the upstream, and are no longer needed Upstream-ref: ceph/ceph#50438

bazaah added a commit to bazaah/aur-ceph that referenced this pull request Aug 26, 2023

pkgbuild: rm upstreamed gcc13 patches

166465e

The changes within are now included in the upstream, and are no longer needed Upstream-ref: ceph/ceph#50438

bazaah added a commit to bazaah/aur-ceph that referenced this pull request Sep 2, 2023

pkgbuild: rm upstreamed gcc13 patches

cbeffa7

The changes within are now included in the upstream, and are no longer needed Upstream-ref: ceph/ceph#50438

bazaah added a commit to bazaah/aur-ceph that referenced this pull request Sep 7, 2023

pkgbuild: rm upstreamed gcc13 patches

0e5df5b

The changes within are now included in the upstream, and are no longer needed Upstream-ref: ceph/ceph#50438

bazaah added a commit to bazaah/aur-ceph that referenced this pull request Sep 7, 2023

pkgbuild: rm upstreamed gcc13 patches

c55c55f

The changes within are now included in the upstream, and are no longer needed Upstream-ref: ceph/ceph#50438

bazaah added a commit to bazaah/aur-ceph that referenced this pull request Sep 9, 2023

pkgbuild: rm upstreamed gcc13 patches

435ed3e

The changes within are now included in the upstream, and are no longer needed Upstream-ref: ceph/ceph#50438

bazaah added a commit to bazaah/aur-ceph that referenced this pull request Sep 9, 2023

pkgbuild: rm upstreamed gcc13 patches

5b923a5

The changes within are now included in the upstream, and are no longer needed Upstream-ref: ceph/ceph#50438

Conversation

tserong commented Mar 8, 2023

Contribution Guidelines

Checklist

Uh oh!

Uh oh!

rzarzynski Mar 8, 2023

Choose a reason for hiding this comment

Uh oh!

cbodley Mar 8, 2023

Choose a reason for hiding this comment

Uh oh!

tserong Mar 9, 2023

Choose a reason for hiding this comment

Uh oh!

tserong Mar 20, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tserong commented Mar 9, 2023

Uh oh!

Uh oh!

cbodley commented May 15, 2023

Uh oh!

tserong commented May 18, 2023

Uh oh!

idryomov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tserong commented May 19, 2023

Uh oh!

idryomov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cbodley commented May 23, 2023

Uh oh!

idryomov commented May 23, 2023

Uh oh!

apteryks commented Dec 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants