rgw: don't dereference nullopt in DeleteMultiObj#50171
Merged
Conversation
yuvalif
reviewed
Feb 20, 2023
| }); | ||
| } else { | ||
| handle_individual_object(obj_key, y, &*formatter_flush_cond); | ||
| handle_individual_object(obj_key, y, nullptr); |
Contributor
There was a problem hiding this comment.
what about the case that we got here because max_aio = 1?
the formatter_flush_cond would not be null
Contributor
Author
There was a problem hiding this comment.
thanks, i removed the max_aio > 1 condition above
Signed-off-by: Casey Bodley <cbodley@redhat.com>
yuvalif
approved these changes
Feb 20, 2023
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/58793
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows